Re: [hibernate-dev] Unit test failures using the new metamodel

2012-08-07 Thread Steve Ebersole
On Tue 07 Aug 2012 11:24:34 AM CDT, Steve Ebersole wrote: >>> What John and I discussed when we worked out the >>> @FailureExpectedWithNewMetamodel was to possibly "store" start up >>> failures (exceptions) and use them for each grouped test method. I >>> think that is not unreasonable, even lon

Re: [hibernate-dev] Unit test failures using the new metamodel

2012-08-07 Thread Steve Ebersole
On Tue 07 Aug 2012 11:08:27 AM CDT, Hardy Ferentschik wrote: > > Exactly what I was trying to say a :-) And this is exactly why I > rewrote the tests we have been discussed in this thread. Most of them > were not even doing/asserting anything when reaching the second phase. > The "test" was just re

Re: [hibernate-dev] Unit test failures using the new metamodel

2012-08-07 Thread Hardy Ferentschik
On 7 Aug 2012, at 15:02, Steve Ebersole wrote: >> I'm not sure I understand what you mean? Do you mean that the >> FailureExpected code is not intended to expect failures in @Before, >> @BeforeClass, and @BeforeClassOnce callbacks? > > That is exactly what I am saying. You have to step back

Re: [hibernate-dev] Unit test failures using the new metamodel

2012-08-07 Thread Steve Ebersole
On Tue 07 Aug 2012 01:01:37 AM CDT, Gail Badner wrote: >>> IIRC, there were some tests that were annotated with >>> @FailureExpected that were only expected to fail using some >>> dialects. This was causing what looked like failures on the >>> dialects where the test was expected to pass. When we

Re: [hibernate-dev] Unit test failures using the new metamodel

2012-08-06 Thread Gail Badner
- Original Message - > From: "Steve Ebersole" > To: "Gail Badner" > Cc: "Hardy Ferentschik" , "Hibernate hibernate-dev" > > Sent: Monday, August 6, 2012 7:02:54 AM > Subject: Re: [hibernate-dev] Unit test failures using the

Re: [hibernate-dev] Unit test failures using the new metamodel

2012-08-06 Thread Gail Badner
- Original Message - > From: "Steve Ebersole" > To: "Gail Badner" > Cc: "Hibernate hibernate-dev" > Sent: Monday, August 6, 2012 6:24:42 AM > Subject: Re: [hibernate-dev] Unit test failures using the new metamodel > > > On 08/02/

Re: [hibernate-dev] Unit test failures using the new metamodel

2012-08-06 Thread Steve Ebersole
On 08/02/2012 07:39 PM, Gail Badner wrote: > > IIRC, there were some tests that were annotated with @FailureExpected that > were only expected to fail using some dialects. This was causing what looked > like failures on the dialects where the test was expected to pass. When we > were trying to

Re: [hibernate-dev] Unit test failures using the new metamodel

2012-08-06 Thread Steve Ebersole
On 08/02/2012 12:56 AM, Gail Badner wrote: > These tests fail with org.hibernate.cfg.NotYetImplementedException when the > sources are being processed. For some reason. this failure is not recognized > as an expected failure. I'm not sure of the reason for this. I was looking at this a little be

Re: [hibernate-dev] Unit test failures using the new metamodel

2012-08-03 Thread Hardy Ferentschik
On 3 Jan 2012, at 11:35 PM, Gail Badner wrote: > Now I'm seeing the following failures with the old metadata (using > hibernate.test.new_metadata_mappings=false): > Test org.hibernate.test.annotations.interfaces.InterfacesTest FAILED > Test org.hibernate.test.annotations.lob.VersionedLobTest FAI

Re: [hibernate-dev] Unit test failures using the new metamodel

2012-08-03 Thread Hardy Ferentschik
On 3 Jan 2012, at 11:21 PM, John Verhaeg wrote: > > On Aug 3, 2012, at 6:39 AM, Hardy Ferentschik wrote: > >> As I said before, the problem is that @FailureExpectedWithNewMetamodel is >> not honored by BaseCoreFunctionalTestCase when >> an error occurs in the setup (BeforeClass handlers). We

Re: [hibernate-dev] Unit test failures using the new metamodel

2012-08-03 Thread Hardy Ferentschik
On 3 Jan 2012, at 11:17 PM, John Verhaeg wrote: > > On Aug 3, 2012, at 1:54 AM, Hardy Ferentschik wrote: > >> Hi, >> >>> I'm seeing some more failures today using >>> -Dhibernate.test.new_metadata_mappings=true >>> -Dhibernate.test.validatefailureexpected=true: >>> - org.hibernate.test.annot

Re: [hibernate-dev] Unit test failures using the new metamodel

2012-08-03 Thread Gail Badner
erhaeg" > To: "Hardy Ferentschik" > Cc: "Gail Badner" , "Hibernate hibernate-dev" > > Sent: Friday, August 3, 2012 2:21:02 PM > Subject: Re: [hibernate-dev] Unit test failures using the new metamodel > > > On Aug 3, 2012, at 6:39 A

Re: [hibernate-dev] Unit test failures using the new metamodel

2012-08-03 Thread Gail Badner
- Original Message - > From: "John Verhaeg" > To: "Hardy Ferentschik" > Cc: "Gail Badner" , "Hibernate hibernate-dev" > > Sent: Friday, August 3, 2012 2:21:02 PM > Subject: Re: [hibernate-dev] Unit test failures using t

Re: [hibernate-dev] Unit test failures using the new metamodel

2012-08-03 Thread John Verhaeg
On Aug 3, 2012, at 6:39 AM, Hardy Ferentschik wrote: > As I said before, the problem is that @FailureExpectedWithNewMetamodel is not > honored by BaseCoreFunctionalTestCase when > an error occurs in the setup (BeforeClass handlers). We could try to address > this in BaseCoreFunctionalTestCase,

Re: [hibernate-dev] Unit test failures using the new metamodel

2012-08-03 Thread John Verhaeg
On Aug 3, 2012, at 1:54 AM, Hardy Ferentschik wrote: > Hi, > >> I'm seeing some more failures today using >> -Dhibernate.test.new_metadata_mappings=true >> -Dhibernate.test.validatefailureexpected=true: >> - org.hibernate.test.annotations.lob.VersionedLobTest FAILED >> - org.hibernate.test.ann

Re: [hibernate-dev] Unit test failures using the new metamodel

2012-08-03 Thread Gail Badner
- Original Message - > From: "Hardy Ferentschik" > To: "Gail Badner" > Cc: "Hibernate hibernate-dev" > Sent: Friday, August 3, 2012 4:39:31 AM > Subject: Re: [hibernate-dev] Unit test failures using the new metamodel > > > On

Re: [hibernate-dev] Unit test failures using the new metamodel

2012-08-03 Thread Hardy Ferentschik
On 3 Jan 2012, at 10:14 AM, Gail Badner wrote > I've pushed a commit that takes care of these and changes the default for > both flags to true. Cool, even though I would have expected that the build completes after the push. Anyways, ... > VersionedLobTest.testVersionUnchangedByteArray is ma

Re: [hibernate-dev] Unit test failures using the new metamodel

2012-08-03 Thread Gail Badner
- Original Message - > From: "Hardy Ferentschik" > To: "Gail Badner" > Cc: "Hibernate hibernate-dev" > Sent: Thursday, August 2, 2012 11:54:33 PM > Subject: Re: [hibernate-dev] Unit test failures using the new metamodel > > Hi

Re: [hibernate-dev] Unit test failures using the new metamodel

2012-08-02 Thread Hardy Ferentschik
Hi, > I'm seeing some more failures today using > -Dhibernate.test.new_metadata_mappings=true > -Dhibernate.test.validatefailureexpected=true: > - org.hibernate.test.annotations.lob.VersionedLobTest FAILED > - org.hibernate.test.annotations.genericsinheritance.GenericsInheritanceTest > FAILED

Re: [hibernate-dev] Unit test failures using the new metamodel

2012-08-02 Thread Gail Badner
ursday, August 2, 2012 5:39:37 PM > Subject: Re: [hibernate-dev] Unit test failures using the new metamodel > > > > - Original Message - > > From: "Hardy Ferentschik" > > To: "Gail Badner" > > Cc: "Hibernate hibernate-dev" >

Re: [hibernate-dev] Unit test failures using the new metamodel

2012-08-02 Thread Gail Badner
- Original Message - > From: "Hardy Ferentschik" > To: "Gail Badner" > Cc: "Hibernate hibernate-dev" > Sent: Wednesday, August 1, 2012 11:26:40 PM > Subject: Re: [hibernate-dev] Unit test failures using the new metamodel > > >

Re: [hibernate-dev] Unit test failures using the new metamodel

2012-08-02 Thread John Verhaeg
On Aug 2, 2012, at 9:34 AM, Hardy Ferentschik wrote: > On 2 Jan 2012, at 4:10 PM, John Verhaeg wrote: > >> >> On Aug 2, 2012, at 1:26 AM, Hardy Ferentschik wrote: >> When hibernate.test.validatefailureexpected is false (the default), the result from FailureExpected tests is simply i

Re: [hibernate-dev] Unit test failures using the new metamodel

2012-08-02 Thread Hardy Ferentschik
On 2 Jan 2012, at 4:10 PM, John Verhaeg wrote: > > On Aug 2, 2012, at 1:26 AM, Hardy Ferentschik wrote: > >>> When hibernate.test.validatefailureexpected is false (the default), the >>> result from FailureExpected tests is simply ignored. >> >> :-( > > Hardy, I'm assuming from your frown, yo

Re: [hibernate-dev] Unit test failures using the new metamodel

2012-08-02 Thread John Verhaeg
On Aug 2, 2012, at 1:26 AM, Hardy Ferentschik wrote: >> When hibernate.test.validatefailureexpected is false (the default), the >> result from FailureExpected tests is simply ignored. > > :-( Hardy, I'm assuming from your frown, you don't like this for some reason. This is the expected behav

Re: [hibernate-dev] Unit test failures using the new metamodel

2012-08-01 Thread Hardy Ferentschik
On 2 Aug 2012, at 07:56, Gail Badner wrote: > I'm seeing the following failures using > hibernate.test.new_metadata_mappings=true that appear to be regressions: > > - org.hibernate.jpa.test.connection.DataSourceInjectionTest fails (also fails > using the old metadata); > - org.hibernate.te