On Aug 3, 2012, at 1:54 AM, Hardy Ferentschik wrote: > Hi, > >> I'm seeing some more failures today using >> -Dhibernate.test.new_metadata_mappings=true >> -Dhibernate.test.validatefailureexpected=true: >> - org.hibernate.test.annotations.lob.VersionedLobTest FAILED >> - org.hibernate.test.annotations.genericsinheritance.GenericsInheritanceTest >> FAILED >> - org.hibernate.test.criteria.ComplexJoinAliasTest FAILED >> >> Are these expected to fail as well (rather than a regression)? > > I could not tell you. Here is what I do. > > 1. Update the code > 2. Make sure it builds (in the default settings) > 3. Fix my stuff and add tests > 4. Rebase > 5. Make sure build works > 6. Push > > AFAICT there were no test failures when I checked in yesterday. I did not and > will not keep lists of failing tests using the metamodel flag.
Not sure what you mean about keeping lists. Now that we have all the annotations in place, the only expectation is to run the build once using the default settings (which are now with both flags set to true) and once more with the new metadata flag turned off. If both pass w/o errors, check in. No lists required. JPAV _______________________________________________ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
