On Aug 3, 2012, at 6:39 AM, Hardy Ferentschik wrote:

> As I said before, the problem is that @FailureExpectedWithNewMetamodel is not 
> honored by BaseCoreFunctionalTestCase when 
> an error occurs in the setup (BeforeClass handlers). We could try to address 
> this in BaseCoreFunctionalTestCase, but in this case I decided
> to move BaseAnnotationBindingTestCase into the testing module and make it the 
> base class for these tests. I was using this base class for 
> testing some annotation based binding tests and it is imo much more suitable 
> for the tests above.

Again, not sure why you're saying this.  The annotation is indeed honored in 
the setup.   That's where most of the errors where occurring before the 
annotation was applied.

> 
> Right now we have the hibernate-core module passing with the new metamodel 
> enabled and the expected failures validated. Hopefully we can
> keep it this way.

Until we finish work on the metamodel, it's still going to be important to run 
the tests twice, once with the metamodel flag on, once off, and check in only 
if there are no errors for either run.

JPAV





_______________________________________________
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev

Reply via email to