Re: Review request for https://issues.apache.org/jira/browse/HDFS-15413

2023-11-06 Thread Bryan Beaudreault
Thank you for the quick response here everyone! On Fri, Nov 3, 2023 at 7:13 AM Ayush Saxena wrote: > I just had a quick pass, In general the logic looks good. But there is > no test added, We should add some tests around this & cover all > possible scenarios, EC is pretty complex & quite prone t

Re: Review request for https://issues.apache.org/jira/browse/HDFS-15413

2023-11-03 Thread Ayush Saxena
I just had a quick pass, In general the logic looks good. But there is no test added, We should add some tests around this & cover all possible scenarios, EC is pretty complex & quite prone to Data corruption, so we should have proper test coverage around it. Xiaoqiao He has also invited folks for

Re: Review request for https://issues.apache.org/jira/browse/HDFS-15413

2023-11-02 Thread Xiaoqiao He
Hi Bryan, Thanks for reaching out and sorry for the late response for this JIRA issue. I tried to contact one HDFS EC expert to get involved. Hope we can push this forward. Thanks again. Best Regards, - He Xiaoqiao On Fri, Nov 3, 2023 at 12:49 AM Bryan Beaudreault wrote: > Hello devs, > > Ther

Review request for https://issues.apache.org/jira/browse/HDFS-15413

2023-11-02 Thread Bryan Beaudreault
Hello devs, There is a PR available on https://issues.apache.org/jira/browse/HDFS-15413 for a few months. This problem is painful for hbase users looking to use Erasure Coding. Any chance a reviewer could take a look? Hopefully the dev who submitted the PR is still around to respond to any feedbac

Review Request

2017-08-24 Thread Brahma Reddy Battula
Hi All If you get chance, can you please review the following. I feel, these two are good candidates for 2.8.2 which is going to release soon. https://issues.apache.org/jira/browse/HDFS-12084 https://issues.apache.org/jira/browse/HDFS-12299 --Brahma Reddy Battula

Review request for HDFS-8631

2017-02-07 Thread surendrasingh lilhore
Hi All, Can someone review HDFS-8631. This jira implement the quota API in WebHdfs File System. It will be help full for managing hdfs quota from REST API. Thanks -Surendra

[Review Request] For HDFS patches

2013-08-22 Thread Vinayakumar B
Hi all, I have posted patches on following Jiras and all are in Patch available state. Some of them are there in that state for quite some time. Please review these patches and post your comments. Thanks in advance. HDFS-5112 HDFS-5031

Code Review Request

2013-04-23 Thread Wang Tianhong
Please review patch: https://issues.apache.org/jira/browse/HDFS-4730 https://issues.apache.org/jira/browse/HDFS-4709 https://issues.apache.org/jira/browse/HDFS-4681 Thanks

Re: Review Request: HDFS-3058 HA: Bring BookKeeperJournalManager up to date with HA changes

2012-05-18 Thread Ivan Kelly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4230/ --- (Updated 2012-05-18 15:43:52.712478) Review request for hadoop-hdfs. Summary

Re: Review Request: HDFS-3058 HA: Bring BookKeeperJournalManager up to date with HA changes

2012-05-10 Thread Ivan Kelly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4230/ --- (Updated 2012-05-10 14:44:08.706764) Review request for hadoop-hdfs. Summary

Re: Review Request: ByteBuffer-based read API for DFSInputStream (review 2)

2012-03-20 Thread Henry Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4212/ --- (Updated 2012-03-20 16:29:56.616292) Review request for hadoop-hdfs and Todd

Re: Review Request: ByteBuffer-based read API for DFSInputStream (review 2)

2012-03-20 Thread Henry Robinson
is is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4212/#review6103 --- On 2012-03-09 00:47:24, Henry Robinson wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request: ByteBuffer-based read API for DFSInputStream (review 2)

2012-03-19 Thread Todd Lipcon
To reply, visit: > https://reviews.apache.org/r/4212/ > ------- > > (Updated 2012-03-09 00:47:24) > > > Review request for hadoop-hdfs and Todd Lipcon. > > > Summary > --- > > New patch for HDFS-28

Re: Review Request: ByteBuffer-based read API for DFSInputStream (review 2)

2012-03-08 Thread Henry Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4212/ --- (Updated 2012-03-09 00:47:24.765130) Review request for hadoop-hdfs and Todd

Review Request: HDFS-3058 HA: Bring BookKeeperJournalManager up to date with HA changes

2012-03-07 Thread Ivan Kelly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4230/ --- Review request for hadoop-hdfs. Summary --- There's a couple of TO

Re: Review Request: ByteBuffer-based read API for DFSInputStream (review 2)

2012-03-06 Thread Todd Lipcon
if some debug flag is set hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs.c <https://reviews.apache.org/r/4212/#comment12344> style, } else { - Todd On 2012-03-06 23:14:07, Henry Robinson wrote: > > ----------- > This is an

Review Request: ByteBuffer-based read API for DFSInputStream (review 2)

2012-03-06 Thread Henry Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4212/ --- Review request for hadoop-hdfs and Todd Lipcon. Summary --- New patch for

Re: Review Request: ByteBuffer-based read API for DFSInputStream

2012-03-05 Thread Todd Lipcon
-- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4184/ > --- > > (Updated 2012-03-05 21:00:55) > > > Review request for hadoop-hdfs and Todd Lipcon. >

Review Request: ByteBuffer-based read API for DFSInputStream

2012-03-05 Thread Todd Lipcon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4184/ --- Review request for hadoop-hdfs and Todd Lipcon. Summary --- Posting patch

Re: Review request: trunk->HDFS-1623 merge

2012-02-09 Thread Todd Lipcon
Thanks Suresh. I committed the merge to the branch. -Todd On Thu, Feb 9, 2012 at 4:32 PM, Suresh Srinivas wrote: > I looked at the merge. It looks good. +1. > > On Wed, Feb 8, 2012 at 9:08 PM, Todd Lipcon wrote: > >> The branch developed some new conflicts due to recent changes in trunk >> affe

Re: Review request: trunk->HDFS-1623 merge

2012-02-09 Thread Suresh Srinivas
I looked at the merge. It looks good. +1. On Wed, Feb 8, 2012 at 9:08 PM, Todd Lipcon wrote: > The branch developed some new conflicts due to recent changes in trunk > affecting the RPC between the DN and the NN (the "StorageReport" > stuff). I've done a new merge to address these conflicts here

Re: Review request: trunk->HDFS-1623 merge

2012-02-09 Thread Todd Lipcon
con wrote: > On Thu, Feb 9, 2012 at 12:54 PM, Konstantin Shvachko > wrote: >> Ok I misunderstood the current direction of the merge. >> >> On the review request: >> >>> we don't deal with the case where OP_ADD >>> contains blocks on a new file

Re: Review request: trunk->HDFS-1623 merge

2012-02-09 Thread Todd Lipcon
On Thu, Feb 9, 2012 at 12:54 PM, Konstantin Shvachko wrote: > Ok I misunderstood the current direction of the merge. > > On the review request: > >> we don't deal with the case where OP_ADD >> contains blocks on a new file -- this is a case that doesn't happen

Re: Review request: trunk->HDFS-1623 merge

2012-02-09 Thread Konstantin Shvachko
Ok I misunderstood the current direction of the merge. On the review request: > we don't deal with the case where OP_ADD > contains blocks on a new file -- this is a case that doesn't happen on > real clusters, but currently happens with synthetic logs generated > from t

Re: Review request: trunk->HDFS-1623 merge

2012-02-09 Thread Todd Lipcon
Hi Konstantin, To be clear, this review request is a merge from the trunk branch into the HA branch (NOT a merge INTO trunk) - we've been doing these pretty much daily since the project began, so that we track trunk closely. The idea is so that we don't have unexpected integration issu

Re: Review request: trunk->HDFS-1623 merge

2012-02-09 Thread Konstantin Shvachko
I was wondering 1. What was the test plan that has been executed for testing this implementation of HA? Besides unit tests. 2. Have you done any benchmarks, comparing current cluster performance against the branch. Would be good to have numbers for both cases with HA off and HA on. I'll post these

Re: Review request: trunk->HDFS-1623 merge

2012-02-08 Thread Todd Lipcon
The branch developed some new conflicts due to recent changes in trunk affecting the RPC between the DN and the NN (the "StorageReport" stuff). I've done a new merge to address these conflicts here: https://github.com/toddlipcon/hadoop-common/tree/ha-merge-20120208 I've also addressed Aaron's com

Re: Review request: trunk->HDFS-1623 merge

2012-02-03 Thread Aaron T. Myers
On Fri, Feb 3, 2012 at 6:45 PM, Suresh Srinivas wrote: > Todd, can you please hold off for the merge till Tuesday, until some of the > other folks working on HA could catch up with some of the recent changes. > Note that this merge doesn't have anything to do with any *recent* changes to the HA b

Re: Review request: trunk->HDFS-1623 merge

2012-02-03 Thread Suresh Srinivas
Todd, can you please hold off for the merge till Tuesday, until some of the other folks working on HA could catch up with some of the recent changes. On Fri, Feb 3, 2012 at 2:10 PM, Todd Lipcon wrote: > I've got a merge pending of trunk into HDFS-1623 -- it was a bit > complicated so wanted to a

Re: Review request: trunk->HDFS-1623 merge

2012-02-03 Thread Aaron T. Myers
Hey Todd, The merge largely looks good. I agree with the general approach you took. A few small comments: 1. There's a comment in the OP_ADD case blockabout handling OP_CLOSE. This makes sense in 0.22/0.23/0.24, but in the HA branch the OP_ADD and OP_CLOSE cases are completely separate case block

Review request: trunk->HDFS-1623 merge

2012-02-03 Thread Todd Lipcon
I've got a merge pending of trunk into HDFS-1623 -- it was a bit complicated so wanted to ask for another set of eyes: https://github.com/toddlipcon/hadoop-common/tree/ha-merge-20120203 (using github since it's hard to review a merge patch via JIRA) The interesting bit of the merge was to deal wit

Review Request: HDFS-234 Integration with BookKeeper logging system

2011-11-15 Thread Ivan Kelly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2835/ --- Review request for hadoop-hdfs. Summary --- BookKeeper is a system to

Re: Review Request: HDFS-1580: Add interface for generic Write Ahead Logging mechanisms

2011-11-03 Thread Ivan Kelly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2672/ --- (Updated 2011-11-03 11:25:09.526158) Review request for hadoop-hdfs. Summary

Re: Review Request: HDFS-1580: Add interface for generic Write Ahead Logging mechanisms

2011-11-02 Thread Ivan Kelly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2672/ --- (Updated 2011-11-02 20:54:27.126053) Review request for hadoop-hdfs. Summary

Re: Review Request: HDFS-1580: Add interface for generic Write Ahead Logging mechanisms

2011-11-02 Thread Todd Lipcon
tation below - Todd On 2011-11-02 14:33:47, Ivan Kelly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2672/ > ------

Review Request: HDFS-1580: Add interface for generic Write Ahead Logging mechanisms

2011-11-02 Thread Ivan Kelly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2672/ --- Review request for hadoop-hdfs. Summary --- This is the final piece to

Re: Review Request: HDFS-2334: Add Closeable to JournalManager

2011-10-24 Thread Ivan Kelly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2247/ --- (Updated 2011-10-24 09:18:46.680787) Review request for hadoop-hdfs. Changes

Re: Review Request: HDFS-2334: Add Closeable to JournalManager

2011-10-20 Thread Ivan Kelly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2247/ --- (Updated 2011-10-20 09:00:57.815922) Review request for hadoop-hdfs. Summary

Review Request for HDFS-140

2011-10-11 Thread Uma Maheswara Rao G 72686
Hi, Provided the patch for HDFS-140. If you have some free time, can you please review it? HDFS-140 (When a file is deleted, its blocks remain in the blocksmap till the next block report from Datanode) It will give advantage in terms of memory usage at NN side. Thanks & Regards, Uma

Re: Review Request: HDFS-2301 Start/stop appropriate namenode internal services during transition to active and standby

2011-10-10 Thread Suresh Srinivas
-- On 2011-10-06 23:25:18, Todd Lipcon wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2150/ > --------

Re: Review Request: HDFS-2301 Start/stop appropriate namenode internal services during transition to active and standby

2011-10-06 Thread Todd Lipcon
---- > > (Updated 2011-10-06 23:25:18) > > > Review request for hadoop-hdfs and Todd Lipcon. > > > Summary > --- > > Uploading Suresh's patch to reviewboard > (https://issues.apache.org/jira/secure/attachment/12496953/HDFS-2301.txt from &g

Re: Review Request: HDFS-2301 Start/stop appropriate namenode internal services during transition to active and standby

2011-10-06 Thread Todd Lipcon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2150/ --- (Updated 2011-10-06 23:25:18.391776) Review request for hadoop-hdfs and Todd

Re: Review Request: HDFS-2301 Start/stop appropriate namenode internal services during transition to active and standby

2011-10-06 Thread Todd Lipcon
e.org/r/2150/#review2277 --- On 2011-10-03 18:36:41, Todd Lipcon wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21

Review Request: Add Closeable to JournalManager

2011-10-06 Thread Ivan Kelly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2247/ --- Review request for hadoop-hdfs. Summary --- A JournalManager may take hold

Re: Review Request: HDFS-2301 Start/stop appropriate namenode internal services during transition to active and standby

2011-10-03 Thread Todd Lipcon
it shows the trace. - Todd On 2011-10-03 18:36:41, Todd Lipcon wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2150/ > ----------- > > (Update

Review Request: HDFS-2301 Start/stop appropriate namenode internal services during transition to active and standby

2011-10-03 Thread Todd Lipcon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2150/ --- Review request for hadoop-hdfs and Todd Lipcon. Summary --- Uploading

Re: Review Request: HDFS-395 DFS Scalability: Incremental block reports

2011-08-24 Thread Tomasz Nykiel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/998/ --- (Updated 2011-08-23 22:55:47.297820) Review request for hadoop-hdfs, Dhruba

Re: Review Request: HDFS-395 DFS Scalability: Incremental block reports

2011-08-24 Thread Tomasz Nykiel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/998/ --- (Updated 2011-08-24 03:33:32.850921) Review request for hadoop-hdfs, Dhruba

Re: Review Request: HDFS-395 DFS Scalability: Incremental block reports

2011-07-27 Thread Tomasz Nykiel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/998/ --- (Updated 2011-07-28 00:40:14.000447) Review request for hadoop-hdfs, Dhruba

Re: Review Request: HDFS-395 DFS Scalability: Incremental block reports

2011-07-11 Thread Tomasz Nykiel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/998/ --- (Updated 2011-07-11 21:06:02.473171) Review request for hadoop-hdfs, Dhruba

Re: Review Request: HDFS-395 DFS Scalability: Incremental block reports

2011-07-01 Thread Tomasz Nykiel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/998/ --- (Updated 2011-07-01 20:34:17.116645) Review request for hadoop-hdfs, Dhruba

Review Request: HDFS-395 DFS Scalability: Incremental block reports

2011-07-01 Thread Tomasz Nykiel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/998/ --- Review request for hadoop-hdfs, Dhruba Borthakur and Hairong Kuang. Summary

Re: Review Request: Misc improvements to HDFS HTML

2011-05-18 Thread Todd Lipcon
--- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/754/ > --- > > (Updated 2011-05-18 19:17:02) > > > Review request for hadoop-hdfs, Todd Lipcon and Eugene Koontz. &

Review Request: Misc improvements to HDFS HTML

2011-05-18 Thread Todd Lipcon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/754/ --- Review request for hadoop-hdfs, Todd Lipcon and Eugene Koontz. Summary

Re: Review Request: Make exiting safemode a lot faster.

2011-01-24 Thread Todd Lipcon
he.org/r/196/ > --- > > (Updated 2011-01-23 20:24:11) > > > Review request for hadoop-hdfs. > > > Summary > --- > > Make exiting safemode a lot faster. > > > This addresses bug HDFS-1391. > https://issues.apache.org/jira/browse/HDFS-1391 > > >

Review Request: Allow a datanode to copy a block to a datanode on a foreign HDFS cluster

2011-01-24 Thread Dhruba Borthakur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/346/ --- Review request for hadoop-hdfs. Summary --- This patch introduces an RPC to

Re: Review Request: Make exiting safemode a lot faster.

2011-01-23 Thread Dhruba Borthakur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/196/ --- (Updated 2011-01-23 20:24:11.634622) Review request for hadoop-hdfs. Changes

Re: Review Request: Make exiting safemode a lot faster.

2010-12-30 Thread Todd Lipcon
e: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/196/ > ------- > > (Updated 2010-12-28 11:12:46) > > > R

Re: Review Request: Make Datanode handle errors to namenode.register call more elegantly

2010-12-28 Thread Dhruba Borthakur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/195/ --- (Updated 2010-12-28 14:09:46.364223) Review request for hadoop-hdfs. Summary

Re: Review Request: Make Datanode handle errors to namenode.register call more elegantly

2010-12-28 Thread Dhruba Borthakur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/195/ --- (Updated 2010-12-28 13:55:18.599061) Review request for hadoop-hdfs. Changes

Review Request: Make exiting safemode a lot faster.

2010-12-28 Thread Dhruba Borthakur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/196/ --- Review request for hadoop-hdfs. Summary --- Make exiting safemode a lot

Review Request: Make Datanode handle errors to namenode.register call more elegantly

2010-12-28 Thread Dhruba Borthakur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/195/ --- Review request for hadoop-hdfs. Summary --- Make Datanode handle errors to

Re: Review Request: Populate needed replication queues before leaving safe mode.

2010-12-09 Thread Patrick Kling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/105/ --- (Updated 2010-12-09 19:52:13.188412) Review request for hadoop-hdfs. Changes

Re: Review Request: Ability to do savenamespace without being in safemode

2010-12-07 Thread Dhruba Borthakur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/125/ --- (Updated 2010-12-07 11:01:28.866525) Review request for hadoop-hdfs. Changes

Re: Review Request: Ability to do savenamespace without being in safemode

2010-12-02 Thread Dhruba Borthakur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/125/ --- (Updated 2010-12-02 11:21:23.394822) Review request for hadoop-hdfs. Changes

Re: Review Request: Ability to do savenamespace without being in safemode

2010-12-01 Thread Dhruba Borthakur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/125/ --- (Updated 2010-12-01 23:05:00.973158) Review request for hadoop-hdfs. Changes

Review Request: Ability to do savenamespace without being in safemode

2010-11-30 Thread Dhruba Borthakur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/125/ --- Review request for hadoop-hdfs. Summary --- The namenode need not be in

Re: Review Request: Add listCorruptFileBlocks to DistributedFileSystem (and ClientProtocol)

2010-11-22 Thread Patrick Kling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18/ --- (Updated 2010-11-22 13:47:46.894388) Review request for hadoop-hdfs. Changes

Re: Review Request: Populate needed replication queues before leaving safe mode.

2010-11-19 Thread Patrick Kling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/105/ --- (Updated 2010-11-19 13:07:20.231197) Review request for hadoop-hdfs. Changes

Re: Review Request: Add listCorruptFileBlocks to DistributedFileSystem (and ClientProtocol)

2010-11-18 Thread Patrick Kling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18/ --- (Updated 2010-11-18 20:10:36.970120) Review request for hadoop-hdfs. Changes

Re: Review Request: Populate needed replication queues before leaving safe mode.

2010-11-18 Thread Patrick Kling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/105/ --- (Updated 2010-11-18 10:49:38.102334) Review request for hadoop-hdfs. Changes

Re: Review Request: Populate needed replication queues before leaving safe mode.

2010-11-16 Thread Patrick Kling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/105/ --- (Updated 2010-11-16 18:01:44.268029) Review request for hadoop-hdfs. Changes

Re: Review Request: Populate needed replication queues before leaving safe mode.

2010-11-16 Thread Dhruba Borthakur
tps://reviews.apache.org/r/105/ > --- > > (Updated 2010-11-16 16:39:18) > > > Review request for hadoop-hdfs. > > > Summary > --- > > This patch introduces a new configuration variable > dfs.namenode.replqueue.threshold-pct that determines the fraction of blocks &

Review Request: Populate needed replication queues before leaving safe mode.

2010-11-16 Thread Patrick Kling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/105/ --- Review request for hadoop-hdfs. Summary --- This patch introduces a new

Re: Review Request: Add listCorruptFileBlocks to DistributedFileSystem (and ClientProtocol)

2010-11-08 Thread Patrick Kling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18/ --- (Updated 2010-11-08 19:01:36.459005) Review request for hadoop-hdfs. Changes

Re: Review Request: DFSClient.getBlockLocations returns BlockLocations with no indication that the corresponding blocks are corrupt

2010-11-04 Thread Todd Lipcon
Hi Arun, I filed https://issues.apache.org/jira/browse/INFRA-3153 Thanks -Todd On Wed, Nov 3, 2010 at 9:47 PM, Arun C Murthy wrote: > > On Nov 3, 2010, at 5:03 PM, Todd Lipcon wrote: > > I wrote such a procmail script for review.hbase.org and

Re: Review Request: DFSClient.getBlockLocations returns BlockLocations with no indication that the corresponding blocks are corrupt

2010-11-03 Thread Arun C Murthy
On Nov 3, 2010, at 5:03 PM, Todd Lipcon wrote: I wrote such a procmail script for review.hbase.org and posted it for the ASF Infra guys a few weeks ago. We can file a new INFRA JIRA to get them to install/configure it. +1, thanks Todd!

Re: Review Request: DFSClient.getBlockLocations returns BlockLocations with no indication that the corresponding blocks are corrupt

2010-11-03 Thread Todd Lipcon
;> --- >>> This is an automatically generated e-mail. To reply, visit: >>> https://reviews.apache.org/r/27/ >>> --- >>> >>> (Updated 2010-11-02 21:12:28) >>

Re: Review Request: DFSClient.getBlockLocations returns BlockLocations with no indication that the corresponding blocks are corrupt

2010-11-03 Thread Arun C Murthy
g/r/27/ --- (Updated 2010-11-02 21:12:28) Review request for hadoop-hdfs. Summary --- DFSClient.getBlockLocations returns BlockLocations with no indication that the corresponding blocks are corrupt When there are no uncorrupted replicas of a

Re: Review Request: DFSClient.getBlockLocations returns BlockLocations with no indication that the corresponding blocks are corrupt

2010-11-03 Thread Patrick Kling
s an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27/ > --- > > (Updated 2010-11-03 11:33:39) > > > Review request for hadoop-hdfs. > > > Summary > --- > > DFSClient.ge

Re: Review Request: DFSClient.getBlockLocations returns BlockLocations with no indication that the corresponding blocks are corrupt

2010-11-03 Thread Ramkumar Vadali
- > > (Updated 2010-11-03 11:33:39) > > > Review request for hadoop-hdfs. > > > Summary > --- > > DFSClient.getBlockLocations returns BlockLocations with no indication that > the corresponding blocks are corrupt > > When there are no uncorrupt

Re: Review Request: DFSClient.getBlockLocations returns BlockLocations with no indication that the corresponding blocks are corrupt

2010-11-03 Thread Patrick Kling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27/ --- (Updated 2010-11-03 11:33:39.415750) Review request for hadoop-hdfs. Changes

Re: Review Request: DFSClient.getBlockLocations returns BlockLocations with no indication that the corresponding blocks are corrupt

2010-11-03 Thread Ramkumar Vadali
wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27/ > --- > > (Updated 2010-11-02 21:12:28) > > > Review requ

Review Request: DFSClient.getBlockLocations returns BlockLocations with no indication that the corresponding blocks are corrupt

2010-11-02 Thread Patrick Kling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27/ --- Review request for hadoop-hdfs. Summary --- DFSClient.getBlockLocations

Re: Review Request: Add listCorruptFileBlocks to DistributedFileSystem (and ClientProtocol)

2010-11-01 Thread Patrick Kling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18/ --- (Updated 2010-11-01 11:50:37.134842) Review request for hadoop-hdfs. Changes

Re: Review Request: Add listCorruptFileBlocks to DistributedFileSystem (and ClientProtocol)

2010-11-01 Thread Dhruba Borthakur
--- > > (Updated 2010-10-29 09:50:27) > > > Review request for hadoop-hdfs. > > > Summary > --- > > Add listCorruptFileBlocks to DistributedFileSystem (and ClientProtocol) > > As discussed in HDFS-, it would be beneficial for tools suc

Review Request: Add listCorruptFileBlocks to DistributedFileSystem (and ClientProtocol)

2010-10-29 Thread Patrick Kling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18/ --- Review request for hadoop-hdfs. Summary --- Add listCorruptFileBlocks to

Re: Review Request: Test review

2010-10-26 Thread Dhruba Borthakur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13/ --- (Updated 2010-10-26 17:27:35.304640) Review request for hadoop-hdfs and Dmytro

Review Request: Test review

2010-10-26 Thread Dhruba Borthakur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13/ --- Review request for hadoop-hdfs and Dmytro Molkov. Summary --- Test Review