----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4212/#review6103 -----------------------------------------------------------
Real close now! hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocal.java <https://reviews.apache.org/r/4212/#comment13128> this comment seems like it's in the wrong spot, since the code that comes after it doesn't reference offsetFromChunkBoundary. hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockReaderLocal.java <https://reviews.apache.org/r/4212/#comment13130> shouldn't this be true? hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockReaderLocal.java <https://reviews.apache.org/r/4212/#comment13132> no reason to use DFSClient here. Instead you can just use the filesystem, right? Then downcast the stream you get back? hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockReaderLocal.java <https://reviews.apache.org/r/4212/#comment13131> don't you want an assert on sawException here? You can also use GenericTestUtils.assertExceptionContains() if you want to check the text of it - Todd On 2012-03-09 00:47:24, Henry Robinson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4212/ > ----------------------------------------------------------- > > (Updated 2012-03-09 00:47:24) > > > Review request for hadoop-hdfs and Todd Lipcon. > > > Summary > ------- > > New patch for HDFS-2834 (I can't update the old review request). > > > This addresses bug HDFS-2834. > http://issues.apache.org/jira/browse/HDFS-2834 > > > Diffs > ----- > > > hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/BlockReader.java > dfab730 > > hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocal.java > cc61697 > > hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java > 4187f1c > > hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java > 2b817ff > > hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java > b7da8d4 > > hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java > ea24777 > > hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/BlockReaderTestUtil.java > 9d4f4a2 > > hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockReaderLocal.java > PRE-CREATION > > hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestParallelRead.java > bbd0012 > > hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestShortCircuitLocalRead.java > eb2a1d8 > > Diff: https://reviews.apache.org/r/4212/diff > > > Testing > ------- > > > Thanks, > > Henry > >
