----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2150/#review2422 -----------------------------------------------------------
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java <https://reviews.apache.org/r/2150/#comment5514> perhaps should be abstract since it won't ever be instantiated? these functions are meant only for the server side, right? Otherwise they should all take an authority, and look at configs prefixed/suffixed with that authority? let me jump over to HDFS-2231 and try to review that first.. having a hard time following this. branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java <https://reviews.apache.org/r/2150/#comment5515> !collection.isEmpty() branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java <https://reviews.apache.org/r/2150/#comment5516> long line branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java <https://reviews.apache.org/r/2150/#comment5518> strange formatting branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java <https://reviews.apache.org/r/2150/#comment5517> so this patch now depends on HDFS-2231 (Conf changes for HA NN), right? - Todd On 2011-10-06 23:25:18, Todd Lipcon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2150/ > ----------------------------------------------------------- > > (Updated 2011-10-06 23:25:18) > > > Review request for hadoop-hdfs and Todd Lipcon. > > > Summary > ------- > > Uploading Suresh's patch to reviewboard > (https://issues.apache.org/jira/secure/attachment/12496953/HDFS-2301.txt from > 29/Sep/11 00:56) > > > This addresses bug HDFS-2301. > https://issues.apache.org/jira/browse/HDFS-2301 > > > Diffs > ----- > > > branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java > PRE-CREATION > > branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java > 1179521 > > branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java > 1179521 > > branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java > 1179521 > > branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ActiveState.java > 1179521 > > branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/HAContext.java > PRE-CREATION > > branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/HAState.java > 1179521 > > branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/StandbyState.java > 1179521 > > branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHAUtil.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/2150/diff > > > Testing > ------- > > > Thanks, > > Todd > >
