----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/754/#review682 -----------------------------------------------------------
a few preliminary comments. I also want to load this up and see how it looks :) trunk/src/java/org/apache/hadoop/hdfs/server/common/JspHelper.java <https://reviews.apache.org/r/754/#comment1362> these lines are missing </td> and </tr> still trunk/src/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java <https://reviews.apache.org/r/754/#comment1363> missing </td></tr> on this line and lines below trunk/src/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java <https://reviews.apache.org/r/754/#comment1364> do we need warning class on both the div and the a? trunk/src/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java <https://reviews.apache.org/r/754/#comment1365> can we kill off these table attributes and use CSS styles to style all the tables consistently? - Todd On 2011-05-18 19:17:02, Todd Lipcon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/754/ > ----------------------------------------------------------- > > (Updated 2011-05-18 19:17:02) > > > Review request for hadoop-hdfs, Todd Lipcon and Eugene Koontz. > > > Summary > ------- > > Uploading Eugene's patch > https://issues.apache.org/jira/secure/attachment/12479631/HDFS-1013.patch for > easier review > > > This addresses bug HDFS-1013. > https://issues.apache.org/jira/browse/HDFS-1013 > > > Diffs > ----- > > trunk/src/java/org/apache/hadoop/hdfs/server/common/JspHelper.java 1124363 > > trunk/src/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java > 1124363 > trunk/src/webapps/hdfs/dfshealth.jsp 1124363 > trunk/src/webapps/static/hadoop.css PRE-CREATION > > Diff: https://reviews.apache.org/r/754/diff > > > Testing > ------- > > > Thanks, > > Todd > >
