Re: [PATCH] Refuse to install on XFS destroying its superblock

2009-10-24 Thread Robert Millan
Ok, let's try this: We refuse to install on a partition UNLESS: - A filesystem can be identified in it. - This filesystem is known to reserve the first block for DOS-style chainload. If these conditions aren't met, user will have to override our check. Patch attached. Also in people/

Re: [PATCH] Refuse to install on XFS destroying its superblock

2009-10-20 Thread Vladimir 'phcoder' Serbinenko
Robert Millan wrote: > On Sun, Oct 18, 2009 at 06:30:11PM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> Robert Millan wrote: >> >>> On Sat, Oct 17, 2009 at 02:09:31PM +0200, Vladimir 'phcoder' Serbinenko >>> wrote: >>> >>> >> The danger is that fs_probe may reject filesyst

Re: [PATCH] Refuse to install on XFS destroying its superblock

2009-10-20 Thread Robert Millan
On Sun, Oct 18, 2009 at 06:30:11PM +0200, Vladimir 'phcoder' Serbinenko wrote: > Robert Millan wrote: > > On Sat, Oct 17, 2009 at 02:09:31PM +0200, Vladimir 'phcoder' Serbinenko > > wrote: > > > The danger is that fs_probe may reject filesystem as valid just because > it's newer than

Re: [PATCH] Refuse to install on XFS destroying its superblock

2009-10-18 Thread Vladimir 'phcoder' Serbinenko
richardvo...@gmail.com wrote: > On Sat, Oct 17, 2009 at 7:09 AM, Vladimir 'phcoder' Serbinenko > wrote: > >> Robert Millan wrote: >> >>> On Sat, Oct 17, 2009 at 01:43:37PM +0200, Vladimir 'phcoder' Serbinenko >>> wrote: >>> >>> Robert Millan wrote: > On

Re: [PATCH] Refuse to install on XFS destroying its superblock

2009-10-18 Thread Vladimir 'phcoder' Serbinenko
Robert Millan wrote: > On Sat, Oct 17, 2009 at 02:09:31PM +0200, Vladimir 'phcoder' Serbinenko wrote: > The danger is that fs_probe may reject filesystem as valid just because it's newer than expected. >>> What do you mean with "reject filesystem as valid"? >>>

Re: [PATCH] Refuse to install on XFS destroying its superblock

2009-10-18 Thread Robert Millan
On Sat, Oct 17, 2009 at 02:09:31PM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> The danger is that fs_probe may reject filesystem as valid just because > >> it's newer than expected. > >> > > > > What do you mean with "reject filesystem as valid"? > > > > > Sorry for being unclear. I ju

Re: [PATCH] Refuse to install on XFS destroying its superblock

2009-10-17 Thread richardvo...@gmail.com
On Sat, Oct 17, 2009 at 7:09 AM, Vladimir 'phcoder' Serbinenko wrote: > Robert Millan wrote: >> On Sat, Oct 17, 2009 at 01:43:37PM +0200, Vladimir 'phcoder' Serbinenko >> wrote: >> >>> Robert Millan wrote: >>> On Sat, Oct 17, 2009 at 12:18:05AM +0200, Vladimir 'phcoder' Serbinenko wrot

Re: [PATCH] Refuse to install on XFS destroying its superblock

2009-10-17 Thread Vladimir 'phcoder' Serbinenko
Robert Millan wrote: > On Sat, Oct 17, 2009 at 01:43:37PM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> Robert Millan wrote: >> >>> On Sat, Oct 17, 2009 at 12:18:05AM +0200, Vladimir 'phcoder' Serbinenko >>> wrote: >>> >>> 2009-10-16 Vladimir Serbinenko +

Re: [PATCH] Refuse to install on XFS destroying its superblock

2009-10-17 Thread Felix Zielcke
Am Samstag, den 17.10.2009, 14:00 +0200 schrieb Robert Millan: > On Sat, Oct 17, 2009 at 01:43:37PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > Robert Millan wrote: > > > On Sat, Oct 17, 2009 at 12:18:05AM +0200, Vladimir 'phcoder' Serbinenko > > > wrote: > > > > > >> 2009-10-16 Vladimir

Re: [PATCH] Refuse to install on XFS destroying its superblock

2009-10-17 Thread Robert Millan
On Sat, Oct 17, 2009 at 01:43:37PM +0200, Vladimir 'phcoder' Serbinenko wrote: > Robert Millan wrote: > > On Sat, Oct 17, 2009 at 12:18:05AM +0200, Vladimir 'phcoder' Serbinenko > > wrote: > > > >> 2009-10-16 Vladimir Serbinenko > >> > >> + * util/i386/pc/grub-setup.c (setup): Refuse to

Re: [PATCH] Refuse to install on XFS destroying its superblock

2009-10-17 Thread Vladimir 'phcoder' Serbinenko
Robert Millan wrote: > On Sat, Oct 17, 2009 at 12:18:05AM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> 2009-10-16 Vladimir Serbinenko >> >> +* util/i386/pc/grub-setup.c (setup): Refuse to overwrite XFS superblock. >> +(options): New option --destroy-xfs. >> +(main): Handle

Re: [PATCH] Refuse to install on XFS destroying its superblock

2009-10-17 Thread Robert Millan
On Sat, Oct 17, 2009 at 12:18:05AM +0200, Vladimir 'phcoder' Serbinenko wrote: > 2009-10-16 Vladimir Serbinenko > > + * util/i386/pc/grub-setup.c (setup): Refuse to overwrite XFS superblock. > + (options): New option --destroy-xfs. > + (main): Handle --destroy-xfs. I gave this so

Re: [PATCH] Refuse to install on XFS destroying its superblock

2009-10-16 Thread Vladimir 'phcoder' Serbinenko
Robert Millan wrote: > On Fri, Oct 16, 2009 at 11:08:31PM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> Robert Millan wrote: >> >>> On Fri, Oct 16, 2009 at 10:09:41PM +0200, Vladimir 'phcoder' Serbinenko >>> wrote: >>> >>> Robert Millan wrote:

Re: [PATCH] Refuse to install on XFS destroying its superblock

2009-10-16 Thread Robert Millan
On Fri, Oct 16, 2009 at 11:08:31PM +0200, Vladimir 'phcoder' Serbinenko wrote: > Robert Millan wrote: > > On Fri, Oct 16, 2009 at 10:09:41PM +0200, Vladimir 'phcoder' Serbinenko > > wrote: > > > >> Robert Millan wrote: > >> > >>> On Fri, Oct 16, 2009 at 06:01:56PM +0200, Jordi Mallach wrot

Re: [PATCH] Refuse to install on XFS destroying its superblock

2009-10-16 Thread Vladimir 'phcoder' Serbinenko
Robert Millan wrote: > On Fri, Oct 16, 2009 at 10:09:41PM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> Robert Millan wrote: >> >>> On Fri, Oct 16, 2009 at 06:01:56PM +0200, Jordi Mallach wrote: >>> >>> On Fri, Oct 16, 2009 at 04:03:01PM +0200, Vladimir 'phcoder' Serbinenk

Re: [PATCH] Refuse to install on XFS destroying its superblock

2009-10-16 Thread Robert Millan
On Fri, Oct 16, 2009 at 10:09:41PM +0200, Vladimir 'phcoder' Serbinenko wrote: > Robert Millan wrote: > > On Fri, Oct 16, 2009 at 06:01:56PM +0200, Jordi Mallach wrote: > > > >> On Fri, Oct 16, 2009 at 04:03:01PM +0200, Vladimir 'phcoder' Serbinenko > >> wrote: > >> > >>> + if (memcmp (tm

Re: [PATCH] Refuse to install on XFS destroying its superblock

2009-10-16 Thread Vladimir 'phcoder' Serbinenko
Robert Millan wrote: > On Fri, Oct 16, 2009 at 06:01:56PM +0200, Jordi Mallach wrote: > >> On Fri, Oct 16, 2009 at 04:03:01PM +0200, Vladimir 'phcoder' Serbinenko >> wrote: >> >>> + if (memcmp (tmp_img, "XFSB", 4) == 0) >>> +grub_util_error ("Can't install on XFS."); >>> >> Can

Re: [PATCH] Refuse to install on XFS destroying its superblock

2009-10-16 Thread Robert Millan
On Fri, Oct 16, 2009 at 06:01:56PM +0200, Jordi Mallach wrote: > On Fri, Oct 16, 2009 at 04:03:01PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > + if (memcmp (tmp_img, "XFSB", 4) == 0) > > +grub_util_error ("Can't install on XFS."); > > Can this error message give some more detail on what

Re: [PATCH] Refuse to install on XFS destroying its superblock

2009-10-16 Thread Jordi Mallach
On Fri, Oct 16, 2009 at 04:03:01PM +0200, Vladimir 'phcoder' Serbinenko wrote: > + if (memcmp (tmp_img, "XFSB", 4) == 0) > +grub_util_error ("Can't install on XFS."); Can this error message give some more detail on what the problem is? Jordi -- Jordi Mallach Pérez -- Debian developer

Re: [PATCH] Refuse to install on XFS destroying its superblock

2009-10-16 Thread Vladimir 'phcoder' Serbinenko
Sorry, patch had a problem Vladimir 'phcoder' Serbinenko wrote: -- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git diff --git a/ChangeLog b/ChangeLog index b0864a9..a67fdfd 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2009-10-16 V

[PATCH] Refuse to install on XFS destroying its superblock

2009-10-16 Thread Vladimir 'phcoder' Serbinenko
-- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git diff --git a/ChangeLog b/ChangeLog index b0864a9..a67fdfd 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2009-10-16 Vladimir Serbinenko + + * util/i386/pc/grub-setup.c (setup): Re