Robert Millan wrote: > On Sat, Oct 17, 2009 at 01:43:37PM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> Robert Millan wrote: >> >>> On Sat, Oct 17, 2009 at 12:18:05AM +0200, Vladimir 'phcoder' Serbinenko >>> wrote: >>> >>> >>>> 2009-10-16 Vladimir Serbinenko <phco...@gmail.com> >>>> >>>> + * util/i386/pc/grub-setup.c (setup): Refuse to overwrite XFS superblock. >>>> + (options): New option --destroy-xfs. >>>> + (main): Handle --destroy-xfs. >>>> >>>> >>> I gave this some more thought, and I think this could be less ad-hoc. We're >>> treating XFS as if it were a "weird", unique thing just because it isn't >>> biased >>> towards DOS-style boot like most filesystems are. >>> >>> Instead, I've done something more generic, using our standard filesystem >>> probing engine which should be more reliable than a single memcmp. >>> >>> >>> >> The danger is that fs_probe may reject filesystem as valid just because >> it's newer than expected. >> > > What do you mean with "reject filesystem as valid"? > > Sorry for being unclear. I just meant that if some XFS structures are updated then our xfs driver won't recognise it as xfs
-- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
