findepi commented on PR #16670:
URL: https://github.com/apache/datafusion/pull/16670#issuecomment-3033380496
test added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
rishvin commented on PR #1971:
URL:
https://github.com/apache/datafusion-comet/pull/1971#issuecomment-3033380721
@andygrove : Could you please review and check if this is how you envisioned
these changes?
--
This is an automated message from the Apache Git Service.
To respond to the mess
alamb commented on PR #16647:
URL: https://github.com/apache/datafusion/pull/16647#issuecomment-3032383269
> @alamb could you maybe run it on `sort_tpch10`. Perhaps the difference is
different when using more cores (16 vs 10 I believe?).
I have queued this up and it should run in a fe
alamb commented on PR #16647:
URL: https://github.com/apache/datafusion/pull/16647#issuecomment-3032511251
🤖 `./gh_compare_branch.sh` [Benchmark
Script](https://github.com/alamb/datafusion-benchmarking/blob/main/gh_compare_branch.sh)
Running
Linux aal-dev 6.11.0-1016-gcp #16~24.04.1-Ubun
findepi commented on PR #16625:
URL: https://github.com/apache/datafusion/pull/16625#issuecomment-3032514381
We might be able to get away with just one and I agree this would be
eventually preferred -- just like it was implemented earlier in this PR. As you
know this didn't work for the pro
andygrove opened a new issue, #1982:
URL: https://github.com/apache/datafusion-comet/issues/1982
### Describe the bug
I am fuzz testing Comet 0.10.0-SNAPSHOT and Iceberg 1.8.1 and running into
an error for queries with `ORDER BY` clauses:
```
SELECT c5, Sqrt(c5) AS x FROM lo
adriangb commented on code in PR #16641:
URL: https://github.com/apache/datafusion/pull/16641#discussion_r2183060691
##
datafusion/physical-optimizer/src/enforce_sorting/sort_pushdown.rs:
##
@@ -216,7 +218,42 @@ fn pushdown_sorts_helper(
fn pushdown_requirement_to_children(
alamb commented on PR #16647:
URL: https://github.com/apache/datafusion/pull/16647#issuecomment-3032659548
🤖: Benchmark completed
Details
```
Comparing HEAD and reuse_rows
Benchmark clickbench_extended.json
┏━━
alamb commented on PR #16647:
URL: https://github.com/apache/datafusion/pull/16647#issuecomment-3032659676
🤖 `./gh_compare_branch.sh` [Benchmark
Script](https://github.com/alamb/datafusion-benchmarking/blob/main/gh_compare_branch.sh)
Running
Linux aal-dev 6.11.0-1016-gcp #16~24.04.1-Ubun
zhuqi-lucas commented on PR #16641:
URL: https://github.com/apache/datafusion/pull/16641#issuecomment-3032766023
> left a minor nit to reduce indentation but otherwise approved, great job!
Thank you @adriangb for patient review, addressed it in latest PR.
--
This is an automated mes
findepi merged PR #16615:
URL: https://github.com/apache/datafusion/pull/16615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafu
findepi closed issue #12195: Convert `Option>` to
`Vec`
URL: https://github.com/apache/datafusion/issues/12195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
andygrove commented on PR #1971:
URL:
https://github.com/apache/datafusion-comet/pull/1971#issuecomment-3033423639
> @andygrove : Could you please review and check if this is how you
envisioned these changes?
Thanks @rishvin. I took a first pass through, and this looks great. Thanks
lliangyu-lin commented on code in PR #16633:
URL: https://github.com/apache/datafusion/pull/16633#discussion_r2183648969
##
datafusion/sqllogictest/bin/sqllogictests.rs:
##
@@ -243,7 +243,7 @@ async fn run_test_file_substrait_round_trip(
};
setup_scratch_dir(&relative_
blaginin merged PR #15928:
URL: https://github.com/apache/datafusion/pull/15928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
blaginin closed issue #13009: Add regexp function - regexp_instr()
URL: https://github.com/apache/datafusion/issues/13009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
tglanz commented on code in PR #1954:
URL: https://github.com/apache/datafusion-comet/pull/1954#discussion_r2184397234
##
native/spark-expr/src/bloom_filter/spark_bit_array.rs:
##
@@ -102,8 +101,10 @@ impl SparkBitArray {
}
}
+/// Returns the number of 64-bit words neede
2010YOUY01 commented on PR #15610:
URL: https://github.com/apache/datafusion/pull/15610#issuecomment-3034531555
> This PR has a significant strength in that it works reliably even under a
fairly conservative memory limit, which is impressive. I also learned a lot
while reviewing it :). Howe
tglanz commented on code in PR #1954:
URL: https://github.com/apache/datafusion-comet/pull/1954#discussion_r2184397234
##
native/spark-expr/src/bloom_filter/spark_bit_array.rs:
##
@@ -102,8 +101,10 @@ impl SparkBitArray {
}
}
+/// Returns the number of 64-bit words neede
jatin510 commented on issue #16676:
URL: https://github.com/apache/datafusion/issues/16676#issuecomment-3034536746
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
ozankabak commented on PR #16625:
URL: https://github.com/apache/datafusion/pull/16625#issuecomment-3032265152
OK, I see. I will think about the interplay between the two and if we can
somehow can get away with just one.
--
This is an automated message from the Apache Git Service.
To resp
comphead commented on PR #16672:
URL: https://github.com/apache/datafusion/pull/16672#issuecomment-3032828771
cc @crepererum
There is another PR pending for `SchemaError`
https://github.com/apache/datafusion/pull/16653
--
This is an automated message from the Apache Git Service.
To res
andygrove commented on issue #1934:
URL:
https://github.com/apache/datafusion-comet/issues/1934#issuecomment-3032848449
> [@andygrove](https://github.com/andygrove)
[@parthchandra](https://github.com/parthchandra) Do we want to keep the current
Arrow shading in Iceberg as is and put both t
andygrove closed issue #1934: Fix shading issues with Iceberg integration
URL: https://github.com/apache/datafusion-comet/issues/1934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
iffyio merged PR #1908:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
iffyio closed issue #1907: Postgres NOT VALID and VALIDATE CONSTRAINT not
parsed for ALTER TABLE
URL: https://github.com/apache/datafusion-sqlparser-rs/issues/1907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
iffyio merged PR #1912:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
andygrove merged PR #1980:
URL: https://github.com/apache/datafusion-comet/pull/1980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
huaxingao commented on issue #1934:
URL:
https://github.com/apache/datafusion-comet/issues/1934#issuecomment-3032844548
@andygrove @parthchandra
Do we want to keep the current Arrow shading in Iceberg as is and put both
the Comet and Iceberg JARs on the classpath? If that's the plan, I
iffyio merged PR #1917:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
iffyio merged PR #1919:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
zhuqi-lucas commented on PR #16647:
URL: https://github.com/apache/datafusion/pull/16647#issuecomment-3032768991
> > 🤖: Benchmark completed
> > Details
> > ```
> > Comparing HEAD and reuse_rows
> >
> > Benchmark sort_tpch10.json
> >
comphead merged PR #1:
URL: https://github.com/apache/datafusion/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
adriangb commented on PR #16641:
URL: https://github.com/apache/datafusion/pull/16641#issuecomment-3032778175
> > left a minor nit to reduce indentation but otherwise approved, great job!
>
> Thank you @adriangb for patient review, addressed it in latest PR.
Btw, I think you mea
solontsev commented on PR #1914:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1914#issuecomment-3032911536
Thanks @iffyio! Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
andygrove opened a new pull request, #1985:
URL: https://github.com/apache/datafusion-comet/pull/1985
## Which issue does this PR close?
Closes #.
## Rationale for this change
## What changes are included in this PR?
## How are these changes
alamb commented on PR #16615:
URL: https://github.com/apache/datafusion/pull/16615#issuecomment-3033391089
> Do i understand correctly the next major is the next release going off
main branch?
yes
> I.e. we can merge as is now?
Let's do it!
--
This is an a
ozankabak commented on PR #16625:
URL: https://github.com/apache/datafusion/pull/16625#issuecomment-3032589803
I think we will find a solution that avoids this redundancy. Expect some
feedback from me (or someone on my team) in a few days
--
This is an automated message from the Apache Gi
kazuyukitanimura commented on code in PR #78:
URL: https://github.com/apache/datafusion-site/pull/78#discussion_r2183211451
##
content/blog/2025-07-01-datafusion-comet-0.9.0.md:
##
@@ -0,0 +1,176 @@
+---
+layout: post
+title: Apache DataFusion Comet 0.9.0 Release
+date: 2025-07-
adriangb merged PR #16641:
URL: https://github.com/apache/datafusion/pull/16641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
mvzink opened a new issue, #1923:
URL: https://github.com/apache/datafusion-sqlparser-rs/issues/1923
When specifying explicit precision and scale for numerics, Postgres allows
the ranges `0..=1000` for precision and `-1000..=1000` for scale. Currently,
`ExactNumberInfo` uses `u64` to repres
andygrove merged PR #1985:
URL: https://github.com/apache/datafusion-comet/pull/1985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
andygrove closed issue #1983: [iceberg] Incorrect results when reading decimal
fields
URL: https://github.com/apache/datafusion-comet/issues/1983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
andygrove commented on issue #1983:
URL:
https://github.com/apache/datafusion-comet/issues/1983#issuecomment-3033259469
Fixed in https://github.com/apache/datafusion-comet/pull/1985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
alamb commented on PR #16671:
URL: https://github.com/apache/datafusion/pull/16671#issuecomment-3032178617
🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
adriangb commented on code in PR #16583:
URL: https://github.com/apache/datafusion/pull/16583#discussion_r2182722840
##
datafusion/core/src/datasource/listing/table.rs:
##
@@ -67,8 +69,62 @@ pub enum SchemaSource {
/// Configuration for creating a [`ListingTable`]
///
+/// #
alamb commented on PR #16671:
URL: https://github.com/apache/datafusion/pull/16671#issuecomment-3032179243
Thanks @zhuqi-lucas and @Dandandan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
adriangb commented on code in PR #16583:
URL: https://github.com/apache/datafusion/pull/16583#discussion_r2182725943
##
datafusion/core/src/datasource/listing/table.rs:
##
@@ -302,11 +405,58 @@ impl ListingTableConfig {
file_schema: self.file_schema,
adriangb commented on code in PR #16642:
URL: https://github.com/apache/datafusion/pull/16642#discussion_r2182744547
##
datafusion/physical-plan/src/execution_plan.rs:
##
@@ -520,10 +520,19 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
parent_filters: Ve
kosiew opened a new pull request, #16672:
URL: https://github.com/apache/datafusion/pull/16672
## Which issue does this PR close?
- Part of a series of PR to address #16652.
## Rationale for this change
This change standardizes the internal representation of several
`Dat
andygrove commented on code in PR #1981:
URL: https://github.com/apache/datafusion-comet/pull/1981#discussion_r2182758032
##
docs/source/user-guide/installation.md:
##
@@ -61,12 +61,13 @@ Cloud Service Providers.
Comet jar files are available in [Maven
Central](https://central
andygrove commented on code in PR #1981:
URL: https://github.com/apache/datafusion-comet/pull/1981#discussion_r2182760995
##
docs/source/user-guide/tuning.md:
##
@@ -21,18 +21,6 @@ under the License.
Comet provides some tuning options to help you get the best performance from
alamb commented on PR #16647:
URL: https://github.com/apache/datafusion/pull/16647#issuecomment-3032716133
🤖: Benchmark completed
Details
```
Comparing HEAD and reuse_rows
Benchmark sort_tpch1.json
┏━━┳
LiaCastaneda commented on code in PR #16454:
URL: https://github.com/apache/datafusion/pull/16454#discussion_r2183300447
##
datafusion/core/src/physical_planner.rs:
##
@@ -1502,6 +1521,64 @@ fn get_null_physical_expr_pair(
Ok((Arc::new(null_value), physical_name))
}
+///
comphead commented on issue #16577:
URL: https://github.com/apache/datafusion/issues/16577#issuecomment-3032986631
> > I'd still keep it in a format of `from_unixtime(ts, [fmt])`
>
> That would mean either smart parsing the second arg (fmt? tz?) or breaking
existing usages. I'm fine w
LiaCastaneda commented on code in PR #16454:
URL: https://github.com/apache/datafusion/pull/16454#discussion_r2183300447
##
datafusion/core/src/physical_planner.rs:
##
@@ -1502,6 +1521,64 @@ fn get_null_physical_expr_pair(
Ok((Arc::new(null_value), physical_name))
}
+///
LiaCastaneda commented on code in PR #16454:
URL: https://github.com/apache/datafusion/pull/16454#discussion_r2183300447
##
datafusion/core/src/physical_planner.rs:
##
@@ -1502,6 +1521,64 @@ fn get_null_physical_expr_pair(
Ok((Arc::new(null_value), physical_name))
}
+///
LiaCastaneda commented on code in PR #16454:
URL: https://github.com/apache/datafusion/pull/16454#discussion_r2183300447
##
datafusion/core/src/physical_planner.rs:
##
@@ -1502,6 +1521,64 @@ fn get_null_physical_expr_pair(
Ok((Arc::new(null_value), physical_name))
}
+///
codecov-commenter commented on PR #1985:
URL:
https://github.com/apache/datafusion-comet/pull/1985#issuecomment-3033005396
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1985?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
LiaCastaneda commented on code in PR #16454:
URL: https://github.com/apache/datafusion/pull/16454#discussion_r2183300447
##
datafusion/core/src/physical_planner.rs:
##
@@ -1502,6 +1521,64 @@ fn get_null_physical_expr_pair(
Ok((Arc::new(null_value), physical_name))
}
+///
NGA-TRAN commented on code in PR #16662:
URL: https://github.com/apache/datafusion/pull/16662#discussion_r2183328514
##
datafusion/proto/tests/cases/roundtrip_physical_plan.rs:
##
@@ -1736,3 +1737,57 @@ async fn roundtrip_physical_plan_node() {
let _ = plan.execute(0, ctx
hsiang-c opened a new pull request, #1987:
URL: https://github.com/apache/datafusion-comet/pull/1987
## Which issue does this PR close?
Closes #. https://github.com/apache/datafusion-comet/issues/1685
## Rationale for this change
When we enabled Iceberg Sp
alamb opened a new pull request, #16673:
URL: https://github.com/apache/datafusion/pull/16673
## Which issue does this PR close?
- part of https://github.com/apache/datafusion/issues/16652
- related to https://github.com/apache/datafusion/pull/16653
## Rationale for t
alamb commented on code in PR #16653:
URL: https://github.com/apache/datafusion/pull/16653#discussion_r2183785894
##
datafusion/common/src/error.rs:
##
@@ -1179,4 +1180,9 @@ mod test {
assert_eq!(errs[1].strip_backtrace(), "Error during planning: b");
assert_eq
alamb commented on PR #16653:
URL: https://github.com/apache/datafusion/pull/16653#issuecomment-3033743371
Doc PR:
- https://github.com/apache/datafusion/pull/16673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
alamb commented on PR #16659:
URL: https://github.com/apache/datafusion/pull/16659#issuecomment-3033748969
I plan to merge this in tomorrow unless there is any more feedback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
jatin510 commented on issue #16667:
URL: https://github.com/apache/datafusion/issues/16667#issuecomment-3031632431
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
jatin510 opened a new issue, #16667:
URL: https://github.com/apache/datafusion/issues/16667
### Describe the bug
The binary operation between Unsigned Integer and Decimal type produces
wrong output.
### To Reproduce
Eg queries:
```
select arrow_cast(1.23,
jatin510 opened a new pull request, #16668:
URL: https://github.com/apache/datafusion/pull/16668
## Which issue does this PR close?
Closes: https://github.com/apache/datafusion/issues/16667
## Rationale for this change
## What changes are included
zhuqi-lucas opened a new pull request, #16671:
URL: https://github.com/apache/datafusion/pull/16671
## Which issue does this PR close?
Currently we only have sort_tpch for benchmark, recently when optimizing
sort, i found sort_tpch10 will show more stable result sometimes, so i added
jonathanc-n commented on code in PR #16443:
URL: https://github.com/apache/datafusion/pull/16443#discussion_r2182837993
##
datafusion/physical-plan/src/joins/utils.rs:
##
@@ -843,24 +844,56 @@ pub(crate) fn apply_join_filter_to_indices(
probe_indices: UInt32Array,
filt
andygrove opened a new issue, #1983:
URL: https://github.com/apache/datafusion-comet/issues/1983
### Describe the bug
During fuzz testing, I am seeing errors reading decimals.
```
## SQL
```
SELECT c7, cast(c7 as SMALLINT), try_cast(c7 as SMALLINT) FROM
local.db.test0
Omega359 commented on PR #15928:
URL: https://github.com/apache/datafusion/pull/15928#issuecomment-3032478116
Run extended tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
Omega359 commented on issue #16577:
URL: https://github.com/apache/datafusion/issues/16577#issuecomment-3032483374
Likely this can be closed as there is a valid and easy alternative.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
UBarney commented on code in PR #16443:
URL: https://github.com/apache/datafusion/pull/16443#discussion_r2182935284
##
datafusion/physical-plan/src/joins/utils.rs:
##
@@ -843,24 +844,56 @@ pub(crate) fn apply_join_filter_to_indices(
probe_indices: UInt32Array,
filter:
alamb commented on PR #16647:
URL: https://github.com/apache/datafusion/pull/16647#issuecomment-3032712630
🤖: Benchmark completed
Details
```
Comparing HEAD and reuse_rows
Benchmark sort_tpch10.json
┏━━
alamb commented on PR #16647:
URL: https://github.com/apache/datafusion/pull/16647#issuecomment-3032712753
🤖 `./gh_compare_branch.sh` [Benchmark
Script](https://github.com/alamb/datafusion-benchmarking/blob/main/gh_compare_branch.sh)
Running
Linux aal-dev 6.11.0-1016-gcp #16~24.04.1-Ubun
comphead commented on code in PR #16653:
URL: https://github.com/apache/datafusion/pull/16653#discussion_r2183170224
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -2535,16 +2535,17 @@ mod tests {
match plan {
Err(DataFusionError::SchemaError(
-
andygrove commented on code in PR #78:
URL: https://github.com/apache/datafusion-site/pull/78#discussion_r2183172953
##
content/blog/2025-07-01-datafusion-comet-0.9.0.md:
##
@@ -0,0 +1,176 @@
+---
+layout: post
+title: Apache DataFusion Comet 0.9.0 Release
+date: 2025-07-01
+aut
andygrove commented on code in PR #78:
URL: https://github.com/apache/datafusion-site/pull/78#discussion_r2183173425
##
content/blog/2025-07-01-datafusion-comet-0.9.0.md:
##
@@ -0,0 +1,176 @@
+---
+layout: post
+title: Apache DataFusion Comet 0.9.0 Release
+date: 2025-07-01
+aut
comphead commented on code in PR #16647:
URL: https://github.com/apache/datafusion/pull/16647#discussion_r2183175335
##
datafusion/physical-plan/src/sorts/stream.rs:
##
@@ -105,26 +110,57 @@ impl RowCursorStream {
})
.collect::>>()?;
-let stre
andygrove commented on PR #78:
URL: https://github.com/apache/datafusion-site/pull/78#issuecomment-3032821765
Thanks for the reviews @kazuyukitanimura @parthchandra @comphead.
I'll plan on merging this tomorrow once the release vote passes.
--
This is an automated message from the A
alamb commented on PR #16663:
URL: https://github.com/apache/datafusion/pull/16663#issuecomment-3033663294
Thanks @melroy12 -- I started the CI tests
I suspect this PR will fail at least `clippy` -- you'll perhaps have to run
Clippy and make the changes it suggests (note you can als
alamb commented on PR #16642:
URL: https://github.com/apache/datafusion/pull/16642#issuecomment-3033664854
Looks like has one more failure (and maybe we can merge up too)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
alamb merged PR #16670:
URL: https://github.com/apache/datafusion/pull/16670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on code in PR #16670:
URL: https://github.com/apache/datafusion/pull/16670#discussion_r2183767743
##
datafusion/common/src/scalar/mod.rs:
##
@@ -895,17 +919,8 @@ fn dict_from_values(
}
macro_rules! typed_cast_tz {
-($array:expr, $index:expr, $ARRAYTYPE:id
alamb commented on PR #16605:
URL: https://github.com/apache/datafusion/pull/16605#issuecomment-3033684735
@Dandandan can i trouble you for a review of this PR (it makes no code
changes, just comments0
--
This is an automated message from the Apache Git Service.
To respond to the message
alamb merged PR #16395:
URL: https://github.com/apache/datafusion/pull/16395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb closed issue #16559: Refactor statement execution logic in
`datafusion-cli`
URL: https://github.com/apache/datafusion/issues/16559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
alamb merged PR #16634:
URL: https://github.com/apache/datafusion/pull/16634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #16395:
URL: https://github.com/apache/datafusion/pull/16395#issuecomment-3033685921
This is so great -- now we just need to write up a blog post 🎣
Thanks again @zhuqi-lucas -- this is going to be great
--
This is an automated message from the Apache Git
alamb closed issue #16374: Add an example of embedding indexes *inside* a
parquet file
URL: https://github.com/apache/datafusion/issues/16374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
alamb commented on PR #16634:
URL: https://github.com/apache/datafusion/pull/16634#issuecomment-3033686652
Thanks again @liamzwbao -- keeping the code clean 💯
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
melroy12 commented on PR #16663:
URL: https://github.com/apache/datafusion/pull/16663#issuecomment-3033691052
> Thanks @melroy12 -- I started the CI tests
>
> I suspect this PR will fail at least `clippy` -- you'll perhaps have to
run Clippy and make the changes it suggests (note you
alamb commented on PR #16653:
URL: https://github.com/apache/datafusion/pull/16653#issuecomment-3033688762
I think technically this is an API change so it would nice to leave a note
in the upgrade guide. I'll make a PR
--
This is an automated message from the Apache Git Service.
To respon
adriangb commented on PR #16642:
URL: https://github.com/apache/datafusion/pull/16642#issuecomment-3033712468
> Looks like has one more failure (and maybe we can merge up too)
done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
melroy12 commented on PR #16663:
URL: https://github.com/apache/datafusion/pull/16663#issuecomment-3033695701
> Thanks @melroy12 -- I started the CI tests
>
> I suspect this PR will fail at least `clippy` -- you'll perhaps have to
run Clippy and make the changes it suggests (note you
adriangb commented on issue #14993:
URL: https://github.com/apache/datafusion/issues/14993#issuecomment-3033503866
I started looking into this and where it gets messy is:
1. Partition columns. I think this needs a rethink. I suggest pushing
partition column generation down into the actual
alamb commented on code in PR #16639:
URL: https://github.com/apache/datafusion/pull/16639#discussion_r2183689441
##
datafusion/sqllogictest/test_files/timestamps.slt:
##
@@ -394,12 +503,12 @@ SELECT COUNT(*) FROM ts_data_secs where ts >
to_timestamp_seconds('2020-09-08 12
que
alamb commented on PR #1914:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1914#issuecomment-3033540449
THank you @iffyio for being a coding machine -- it is pretty amazing to see
all this code go in -- its like we don't really have any idea how many crazy
variants of SQL th
1 - 100 of 199 matches
Mail list logo
