comphead commented on issue #16577: URL: https://github.com/apache/datafusion/issues/16577#issuecomment-3032986631
> > I'd still keep it in a format of `from_unixtime(ts, [fmt])` > > That would mean either smart parsing the second arg (fmt? tz?) or breaking existing usages. I'm fine with breaking things as long as it's well documented in the upgrade guide but I tend to be in the minority. Having a timezone along with the format is confusing I agree. Frankly speaking not sure why it was done that way in the first place 🤔 The only place with the same signature I found is the starburst https://docs.starburst.io/latest/functions/datetime.html#from_unixtime The major others support it in the format of `from_unixtime(ts, [fmt])` Perhaps we can add another one like `from_unixtime_tz(ts, [tz])` WDYT @Omega359 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
