alamb commented on code in PR #16653: URL: https://github.com/apache/datafusion/pull/16653#discussion_r2183785894
########## datafusion/common/src/error.rs: ########## @@ -1179,4 +1180,9 @@ mod test { assert_eq!(errs[1].strip_backtrace(), "Error during planning: b"); assert_eq!(errs[2].strip_backtrace(), "Error during planning: c"); } + + #[test] + fn test_error_size() { + assert_eq!(size_of::<SchemaError>(), 40); Review Comment: I think context would help too ```suggestion // Since Errors influence the size of Result which influence the size of the stack // please don't allow this to grow larger assert_eq!(size_of::<SchemaError>(), 40); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org