comphead commented on code in PR #16653: URL: https://github.com/apache/datafusion/pull/16653#discussion_r2183170224
########## datafusion/expr/src/logical_plan/builder.rs: ########## @@ -2535,16 +2535,17 @@ mod tests { match plan { Err(DataFusionError::SchemaError( - SchemaError::AmbiguousReference { - field: - Column { - relation: Some(TableReference::Bare { table }), - name, - spans: _, - }, - }, + SchemaError::AmbiguousReference { field }, _, )) => { + let Column { + relation, + name, + spans: _, + } = *field; + let Some(TableReference::Bare { table }) = relation else { + return plan_err!("wrong relation"); Review Comment: ```suggestion return plan_err!("wrong relation: {relation}, expected table name"); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org