[I] `describe` does not handle mixed case or dots in column names [datafusion]

2025-05-10 Thread via GitHub
johnkerl opened a new issue, #16017: URL: https://github.com/apache/datafusion/issues/16017 ### Describe the bug Doing `describe` with any upper-case or dot characters in column names results in ``` Error: Execution("Schema error: No field named ...") ``` ### To Reprod

[PR] feat: Improve performance tracing feature [datafusion-comet]

2025-05-10 Thread via GitHub
andygrove opened a new pull request, #1730: URL: https://github.com/apache/datafusion-comet/pull/1730 ## Which issue does this PR close? N/A ## Rationale for this change Various improvements to the performance tracing feature. ## What changes are in

Re: [PR] Minor: Add unit tests for `ceil`/`floor` functions [datafusion-comet]

2025-05-10 Thread via GitHub
codecov-commenter commented on PR #1728: URL: https://github.com/apache/datafusion-comet/pull/1728#issuecomment-2868991301 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1728?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca

Re: [PR] Enable repartitioning on MemTable. [datafusion]

2025-05-10 Thread via GitHub
alamb commented on PR #15409: URL: https://github.com/apache/datafusion/pull/15409#issuecomment-2868765074 Thank you @wiedld and @2010YOUY01 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [I] Sort query won't get round-robin repartitioned if input is `MemTable` [datafusion]

2025-05-10 Thread via GitHub
alamb closed issue #15088: Sort query won't get round-robin repartitioned if input is `MemTable` URL: https://github.com/apache/datafusion/issues/15088 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Enable repartitioning on MemTable. [datafusion]

2025-05-10 Thread via GitHub
alamb merged PR #15409: URL: https://github.com/apache/datafusion/pull/15409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] Migrate Optimizer tests to insta, part7 [datafusion]

2025-05-10 Thread via GitHub
alamb commented on PR #16010: URL: https://github.com/apache/datafusion/pull/16010#issuecomment-2868777561 Amazing -- thank you @qstommyshu @blaginin and @xudong963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] Migrate optimizer tests to `insta` [datafusion]

2025-05-10 Thread via GitHub
alamb closed issue #15396: Migrate optimizer tests to `insta` URL: https://github.com/apache/datafusion/issues/15396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] Migrate Optimizer tests to insta, part7 [datafusion]

2025-05-10 Thread via GitHub
alamb merged PR #16010: URL: https://github.com/apache/datafusion/pull/16010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

[PR] build(deps): bump tokio from 1.44.2 to 1.45.0 [datafusion-python]

2025-05-10 Thread via GitHub
dependabot[bot] opened a new pull request, #1125: URL: https://github.com/apache/datafusion-python/pull/1125 Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.44.2 to 1.45.0. Release notes Sourced from https://github.com/tokio-rs/tokio/releases";>tokio's releases. Tokio

[PR] chore: Replace MSRV link on main page with Github badge [datafusion]

2025-05-10 Thread via GitHub
comphead opened a new pull request, #16020: URL: https://github.com/apache/datafusion/pull/16020 ## Which issue does this PR close? - Closes #. ## Rationale for this change Main page is too technical describing Rust MSRV and policy, moved this to `introduction` d

[PR] Add support for `GO` batch delimiter in SQL Server [datafusion-sqlparser-rs]

2025-05-10 Thread via GitHub
aharpervc opened a new pull request, #1809: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1809 Reference: https://learn.microsoft.com/en-us/sql/t-sql/language-elements/sql-server-utilities-statements-go Lots of conventional SQL Server tooling supports `GO`, so it seems r

Re: [PR] Add support for `GO` batch delimiter in SQL Server [datafusion-sqlparser-rs]

2025-05-10 Thread via GitHub
iffyio commented on PR #1809: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1809#issuecomment-2869271634 > are you closing the PR because you're opposed to supporting batch delimiters at all in this library, or is it that you don't want to accept this particular approach

Re: [PR] Add support for `DENY` statements [datafusion-sqlparser-rs]

2025-05-10 Thread via GitHub
iffyio commented on code in PR #1836: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1836#discussion_r2083361188 ## src/parser/mod.rs: ## @@ -13020,14 +13035,18 @@ impl<'a> Parser<'a> { GranteesType::Share } else if self.parse_keyword(

Re: [PR] fix: Skip row index Spark SQL tests for native_datafusion Parquet scan [datafusion-comet]

2025-05-10 Thread via GitHub
parthchandra commented on PR #1724: URL: https://github.com/apache/datafusion-comet/pull/1724#issuecomment-2869176308 > > I thought the plan was to fix this by falling back to Spark? We can check if the schema has a field name matching `FileFormat.ROW_INDEX_TEMPORARY_COLUMN_NAME` and fall

Re: [PR] Add support for table valued functions for SQL Server [datafusion-sqlparser-rs]

2025-05-10 Thread via GitHub
iffyio commented on code in PR #1839: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1839#discussion_r2083356065 ## src/parser/mod.rs: ## @@ -5203,19 +5203,79 @@ impl<'a> Parser<'a> { let (name, args) = self.parse_create_function_name_and_params()?;

[PR] refactor: framework for subquery unnesting [datafusion]

2025-05-10 Thread via GitHub
duongcongtoai opened a new pull request, #16016: URL: https://github.com/apache/datafusion/pull/16016 ## Which issue does this PR close? - Closes #5492 ## Rationale for this change ## What changes are included in this PR? Purpose of this PR is to unify

Re: [PR] feat: Improve performance tracing feature [datafusion-comet]

2025-05-10 Thread via GitHub
codecov-commenter commented on PR #1730: URL: https://github.com/apache/datafusion-comet/pull/1730#issuecomment-2869011503 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1730?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca

[I] Include datatypes in logicalplan for inferred statements [datafusion]

2025-05-10 Thread via GitHub
brayanjuls opened a new issue, #16018: URL: https://github.com/apache/datafusion/issues/16018 Given a prepare statement: `PREPARE my_plan AS SELECT id, age FROM person WHERE age BETWEEN $1 AND $2` The generated logical plan would look like this:
 ``` Prepare: "my_plan" []

Re: [I] Include datatypes in logicalplan for inferred statements [datafusion]

2025-05-10 Thread via GitHub
brayanjuls commented on issue #16018: URL: https://github.com/apache/datafusion/issues/16018#issuecomment-2869031591 take -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] feat: split scheduler gprc creation [datafusion-ballista]

2025-05-10 Thread via GitHub
milenkovicm opened a new pull request, #1261: URL: https://github.com/apache/datafusion-ballista/pull/1261 # Which issue does this PR close? Closes #. # Rationale for this change split scheduler and scheduler grpc creation process, making scheduler accessible #

Re: [PR] Introduce Async User Defined Functions [datafusion]

2025-05-10 Thread via GitHub
adriangb commented on PR #14837: URL: https://github.com/apache/datafusion/pull/14837#issuecomment-2869167967 > What if we just added a new method to the PhysicalExpr trait, like `evaluate_async()`? We could then call this from streams that might involve async work. The default implementati

[I] Add lint rule to enforce string formatting style [datafusion]

2025-05-10 Thread via GitHub
2010YOUY01 opened a new issue, #16021: URL: https://github.com/apache/datafusion/issues/16021 ### Is your feature request related to a problem or challenge? https://github.com/apache/datafusion/pull/15999 changed the string format style as follows to improve readability: ```rust

Re: [PR] style: simplify some strings for readability [datafusion]

2025-05-10 Thread via GitHub
hamirmahal commented on PR #15999: URL: https://github.com/apache/datafusion/pull/15999#issuecomment-2869414757 You’re welcome! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Introduce Async User Defined Functions [datafusion]

2025-05-10 Thread via GitHub
berkaysynnada commented on code in PR #14837: URL: https://github.com/apache/datafusion/pull/14837#discussion_r2083270057 ## datafusion/core/src/physical_planner.rs: ## @@ -775,12 +776,44 @@ impl DefaultPhysicalPlanner { let runtime_expr =

Re: [PR] chore: Replace MSRV link on main page with Github badge [datafusion]

2025-05-10 Thread via GitHub
comphead commented on PR #16020: URL: https://github.com/apache/datafusion/pull/16020#issuecomment-2869141396 Related to https://github.com/apache/datafusion/issues/14389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] Include data types in logical plans of inferred prepare statements [datafusion]

2025-05-10 Thread via GitHub
brayanjuls opened a new pull request, #16019: URL: https://github.com/apache/datafusion/pull/16019 ## Which issue does this PR close? Closes #16018 ## Rationale for this change As data types of prepare statement without explicit types declaration are not included in the

Re: [PR] style: simplify some strings for readability [datafusion]

2025-05-10 Thread via GitHub
hamirmahal commented on PR #15999: URL: https://github.com/apache/datafusion/pull/15999#issuecomment-2869064003 > Great effort in finding all format! positional arguments! Thanks! `clippy` actually did this for me. I'll push up commits for the suggestions right now. > +1 for be

Re: [PR] Fix Infer prepare statement type tests [datafusion]

2025-05-10 Thread via GitHub
qstommyshu commented on code in PR #15743: URL: https://github.com/apache/datafusion/pull/15743#discussion_r2083261051 ## datafusion/sql/src/statement.rs: ## @@ -710,6 +710,7 @@ impl SqlToRel<'_, S> { *statement, &mut planner_context,