hamirmahal commented on PR #15999: URL: https://github.com/apache/datafusion/pull/15999#issuecomment-2869064003
> Great effort in finding all format! positional arguments! Thanks! `clippy` actually did this for me. I'll push up commits for the suggestions right now. > +1 for better readability. I'm wondering is there any clippy configurations to enforce this style? There is. Since there are already a lot of changes in this pull request, I can look into adding the configuration in a future PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org