berkaysynnada commented on code in PR #14837:
URL: https://github.com/apache/datafusion/pull/14837#discussion_r2083270057


##########
datafusion/core/src/physical_planner.rs:
##########
@@ -775,12 +776,44 @@ impl DefaultPhysicalPlanner {
 
                 let runtime_expr =
                     self.create_physical_expr(predicate, input_dfschema, 
session_state)?;
+
+                let filter = match self.try_plan_async_exprs(

Review Comment:
   Do we need to apply this pattern for every operator which has 
`PhysicalExpr`s inside it that need to be evaluated during runtime? I think we 
can figure out another way to not make people modify the planner code for such 
every operator



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to