aharpervc opened a new pull request, #1809:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1809

   Reference: 
https://learn.microsoft.com/en-us/sql/t-sql/language-elements/sql-server-utilities-statements-go
   
   Lots of conventional SQL Server tooling supports `GO`, so it seems really 
useful & prudent to be able to parse it. I realize that strictly speaking, it 
isn't a SQL "statement". However, I think it makes sense to model here as a 
statement since it acts as one in all regards except documentation.
   
   In terms of parsing, `GO` has some peculiarities I tried to express with the 
new tests, such as with regards to position and basically treating newline as a 
delimiter. This also starts to nudge on 
https://github.com/apache/datafusion-sqlparser-rs/issues/1800, where newlines 
may possibly be interpreted as statement delimiters in a general case. However, 
my approach here for `GO` is isolated to only that statement, at least for the 
time being.
   
   ---
   
   Also, this will conflict with 
https://github.com/apache/datafusion-sqlparser-rs/pull/1808 when either is 
merged, because I'm adding things that end up being adjacent to each other 
which can confuse git, depending on merge strategy. There's no _actual_ 
conflict.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to