logan-keede opened a new pull request, #14662:
URL: https://github.com/apache/datafusion/pull/14662
## Which issue does this PR close?
- Closes #6107
## Rationale for this change
a step towards https://github.com/apache/datafusion/issues/5504
## What change
codecov-commenter commented on PR #1401:
URL:
https://github.com/apache/datafusion-comet/pull/1401#issuecomment-2658617707
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1401?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
logan-keede commented on PR #14662:
URL: https://github.com/apache/datafusion/pull/14662#issuecomment-2658628564
@alamb Check this out.
do we have some documentation on json format? that would be helpful if we
want to show more arguments in `tag set`.
--
This is an automated messag
Kontinuation commented on code in PR #14644:
URL: https://github.com/apache/datafusion/pull/14644#discussion_r1955829354
##
datafusion/physical-plan/src/sorts/sort.rs:
##
@@ -408,50 +395,114 @@ impl ExternalSorter {
debug!("Spilling sort data of ExternalSorter to disk
viirya commented on issue #1389:
URL:
https://github.com/apache/datafusion-comet/issues/1389#issuecomment-2660573325
Because this?
```
// When Comet shuffle is disabled, we don't want to transform the
HashAggregate
// to CometHashAggregate. Otherwise, we probably get partial Co
kazuyukitanimura commented on PR #1405:
URL:
https://github.com/apache/datafusion-comet/pull/1405#issuecomment-2660613861
The title says `[branch-0.6]` but this PR is against `main`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
andygrove commented on PR #1405:
URL:
https://github.com/apache/datafusion-comet/pull/1405#issuecomment-2660614850
> The title says `[branch-0.6]` but this PR is against `main`?
Thanks. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message,
andygrove opened a new issue, #1406:
URL: https://github.com/apache/datafusion-comet/issues/1406
### What is the problem the feature request solves?
We hard-code the current snapshot version in some GitHub actions. We should
get the version number from the pom.xml instead to remove th
andygrove commented on PR #1405:
URL:
https://github.com/apache/datafusion-comet/pull/1405#issuecomment-2660616259
> What about `.github/actions/setup-spark-builder/action.yaml`?
There is no need to override the default value since it gets replace
dynamically, but I filed an issue to
milenkovicm commented on PR #14631:
URL: https://github.com/apache/datafusion/pull/14631#issuecomment-2660174463
@alamb this PR looks fine I verified it with
`datafusion.execution.parquet.pushdown_filters=true` but still same problem
like https://github.com/apache/datafusion/pull/14631#iss
alamb commented on PR #14631:
URL: https://github.com/apache/datafusion/pull/14631#issuecomment-2660160341
Thanks @milenkovicm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
alamb closed issue #14654: feat: add `TableSource` to `DML` `proto` to
eliminate need for table lookup after deserialisation
URL: https://github.com/apache/datafusion/issues/14654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
alamb merged PR #14631:
URL: https://github.com/apache/datafusion/pull/14631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
Omega359 commented on issue #14661:
URL: https://github.com/apache/datafusion/issues/14661#issuecomment-2660211300
https://github.com/apache/datafusion/issues/8282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
wiedld commented on code in PR #14650:
URL: https://github.com/apache/datafusion/pull/14650#discussion_r1956722551
##
datafusion/physical-optimizer/src/enforce_sorting/mod.rs:
##
@@ -119,7 +119,7 @@ fn update_sort_ctx_children(
}
node.data = data;
-node.update_pl
wiedld opened a new pull request, #14673:
URL: https://github.com/apache/datafusion/pull/14673
## Which issue does this PR close?
Helps with the docs effort https://github.com/apache/datafusion/issues/7013.
## Rationale for this change
Noticed while reviewing https://gith
wiedld commented on code in PR #14650:
URL: https://github.com/apache/datafusion/pull/14650#discussion_r1956722551
##
datafusion/physical-optimizer/src/enforce_sorting/mod.rs:
##
@@ -119,7 +119,7 @@ fn update_sort_ctx_children(
}
node.data = data;
-node.update_pl
comphead commented on code in PR #1359:
URL: https://github.com/apache/datafusion-comet/pull/1359#discussion_r1956765242
##
native/core/Cargo.toml:
##
@@ -77,6 +77,7 @@ datafusion-comet-proto = { workspace = true }
object_store = { workspace = true }
url = { workspace = true }
parthchandra commented on PR #1387:
URL:
https://github.com/apache/datafusion-comet/pull/1387#issuecomment-2660476596
@kazuyukitanimura please go ahead and merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
kazuyukitanimura commented on code in PR #1390:
URL: https://github.com/apache/datafusion-comet/pull/1390#discussion_r1956865360
##
common/src/main/scala/org/apache/comet/CometConf.scala:
##
@@ -216,6 +216,17 @@ object CometConf extends ShimCometConf {
val COMET_EXEC_INITCAP_
kazuyukitanimura commented on code in PR #1390:
URL: https://github.com/apache/datafusion-comet/pull/1390#discussion_r1956799716
##
common/src/main/scala/org/apache/comet/CometConf.scala:
##
@@ -216,6 +216,17 @@ object CometConf extends ShimCometConf {
val COMET_EXEC_INITCAP_
comphead opened a new pull request, #14676:
URL: https://github.com/apache/datafusion/pull/14676
## Which issue does this PR close?
Related to #14389
- Closes #.
## Rationale for this change
## What changes are included in this PR?
## Are th
simonvandel commented on PR #14675:
URL: https://github.com/apache/datafusion/pull/14675#issuecomment-2660484055
Oops, need to generate valid uuidv4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
comphead commented on code in PR #14675:
URL: https://github.com/apache/datafusion/pull/14675#discussion_r1956877727
##
datafusion/functions/src/string/uuid.rs:
##
@@ -87,7 +88,13 @@ impl ScalarUDFImpl for UuidFunc {
if !args.is_empty() {
return internal_er
parthchandra commented on code in PR #1359:
URL: https://github.com/apache/datafusion-comet/pull/1359#discussion_r1956879942
##
native/core/src/execution/planner.rs:
##
@@ -1155,12 +1154,9 @@ impl PhysicalPlanner {
))
});
-
andygrove merged PR #1398:
URL: https://github.com/apache/datafusion-comet/pull/1398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
parthchandra commented on code in PR #1398:
URL: https://github.com/apache/datafusion-comet/pull/1398#discussion_r1956903894
##
spark/src/main/scala/org/apache/comet/DataTypeSupport.scala:
##
@@ -37,7 +37,7 @@ trait DataTypeSupport {
private def isGloballySupported(dt: Data
parthchandra commented on PR #1150:
URL:
https://github.com/apache/datafusion-comet/pull/1150#issuecomment-2660530828
> > @mbutrovich Do you plan to overwrite
spark/benchmarks/CometReadBenchmark-jdk11-results.txt ?
>
> > Thanks for running this benchmark @mbutrovich. Slowness in nati
kazuyukitanimura commented on PR #1150:
URL:
https://github.com/apache/datafusion-comet/pull/1150#issuecomment-2660569970
Merged thanks @mbutrovich @parthchandra @comphead @andygrove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
kazuyukitanimura merged PR #1150:
URL: https://github.com/apache/datafusion-comet/pull/1150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsub
irenjj commented on issue #14438:
URL: https://github.com/apache/datafusion/issues/14438#issuecomment-2660573715
> Hey [@irenjj](https://github.com/irenjj) how is it going with this ticket
:) Can I help with anything?
Hi, @eliaperantoni, Sorry for not updating my status for a long tim
kazuyukitanimura commented on issue #1389:
URL:
https://github.com/apache/datafusion-comet/issues/1389#issuecomment-2660587673
Thanks @viirya
@EmilyMatt Did you mean that we should be able to run Comet aggregation even
Comet shuffle is disabled by
> I believe I've seen a few
kazuyukitanimura commented on PR #14644:
URL: https://github.com/apache/datafusion/pull/14644#issuecomment-2660597523
Not directly related to the point of this PR but regarding
`
I had a hard time making DataFusion Comet work on cloud instances with 4GB
memory per CPU core, partially b
kazuyukitanimura commented on code in PR #1404:
URL: https://github.com/apache/datafusion-comet/pull/1404#discussion_r1956946498
##
dev/diffs/3.4.3.diff:
##
@@ -7,7 +7,7 @@ index d3544881af1..26ab186c65d 100644
2.5.1
2.0.8
+3.4
-+0.5.0-SNAPSHOT
Review Comme
kazuyukitanimura commented on issue #1389:
URL:
https://github.com/apache/datafusion-comet/issues/1389#issuecomment-2660567872
cc @viirya
I forgot why we did this in #991
https://github.com/apache/datafusion-comet/blob/f099e6e40aa18441c7882e5bffd9d6dfb10c6c19/spark/src/main/scala/or
kazuyukitanimura merged PR #1387:
URL: https://github.com/apache/datafusion-comet/pull/1387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsub
kazuyukitanimura commented on PR #1359:
URL:
https://github.com/apache/datafusion-comet/pull/1359#issuecomment-2660574425
oops, @comphead would you mind merging the latest main into this PR branch
in order to resolve the conflict?
--
This is an automated message from the Apache Git Servi
andygrove opened a new pull request, #1405:
URL: https://github.com/apache/datafusion-comet/pull/1405
## Which issue does this PR close?
Fix incorrect Comet version in Spark diffs.
## Rationale for this change
Fixing this just in case anyone wants to run S
andygrove commented on code in PR #1404:
URL: https://github.com/apache/datafusion-comet/pull/1404#discussion_r1956971872
##
dev/diffs/3.4.3.diff:
##
@@ -7,7 +7,7 @@ index d3544881af1..26ab186c65d 100644
2.5.1
2.0.8
+3.4
-+0.5.0-SNAPSHOT
Review Comment:
github-actions[bot] commented on PR #13420:
URL: https://github.com/apache/datafusion/pull/13420#issuecomment-2660627372
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
github-actions[bot] closed pull request #13699: PoC Adaptive round robin
repartitioning
URL: https://github.com/apache/datafusion/pull/13699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
github-actions[bot] closed pull request #1581: Reorganize the Parser module
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
findepi merged PR #14667:
URL: https://github.com/apache/datafusion/pull/14667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafu
Dandandan commented on PR #14411:
URL: https://github.com/apache/datafusion/pull/14411#issuecomment-2659343979
I ran some tests yesterday and I can confirm the runtime improvements.
I do get some high memory usage however especially with some queries (TPC-H
Query 18 I believe) than with t
timsaucer commented on code in PR #14636:
URL: https://github.com/apache/datafusion/pull/14636#discussion_r1956153542
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -834,10 +834,16 @@ impl LogicalPlanBuilder {
plan: &LogicalPlan,
column: impl Into,
milenkovicm commented on code in PR #14631:
URL: https://github.com/apache/datafusion/pull/14631#discussion_r1956209104
##
datafusion/expr/src/logical_plan/dml.rs:
##
@@ -91,31 +91,64 @@ impl Hash for CopyTo {
/// The operator that modifies the content of a database (adapted
milenkovicm commented on code in PR #14631:
URL: https://github.com/apache/datafusion/pull/14631#discussion_r1956209104
##
datafusion/expr/src/logical_plan/dml.rs:
##
@@ -91,31 +91,64 @@ impl Hash for CopyTo {
/// The operator that modifies the content of a database (adapted
andygrove commented on PR #1398:
URL:
https://github.com/apache/datafusion-comet/pull/1398#issuecomment-2659469471
@kazuyukitanimura @comphead could I get a committer approval?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
andygrove commented on code in PR #1398:
URL: https://github.com/apache/datafusion-comet/pull/1398#discussion_r1956227422
##
docs/templates/compatibility-template.md:
##
@@ -17,12 +17,43 @@
under the License.
-->
+
+
# Compatibility Guide
Comet aims to provide consiste
andygrove commented on PR #1398:
URL:
https://github.com/apache/datafusion-comet/pull/1398#issuecomment-2659468163
Thanks for the review @mbutrovich and @parthchandra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
alamb commented on issue #13816:
URL: https://github.com/apache/datafusion/issues/13816#issuecomment-2659471604
At a high level, I think this ticket has 2 parts:
1. Figure out what is contributing to code size increase
2. Then perhaps figure out how to make it better
I think the
alamb closed pull request #14666: hack out parqeut feature from datafusion-cli
URL: https://github.com/apache/datafusion/pull/14666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
alamb commented on PR #14650:
URL: https://github.com/apache/datafusion/pull/14650#issuecomment-2659552185
@wiedld can you please review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
milenkovicm commented on code in PR #14631:
URL: https://github.com/apache/datafusion/pull/14631#discussion_r1956211885
##
datafusion/sql/src/statement.rs:
##
@@ -1709,18 +1709,22 @@ impl SqlToRel<'_, S> {
// Do a table lookup to verify the table exists
let tab
Omega359 commented on issue #13631:
URL: https://github.com/apache/datafusion/issues/13631#issuecomment-2659449432
I did a quick test using
cargo fix --edition and there are a lot of concerns with drop ordering and
if let scoping:
```
warning: `if let` assigns a shorter lif
alamb opened a new pull request, #14667:
URL: https://github.com/apache/datafusion/pull/14667
## Which issue does this PR close?
A small logical conflict came in from
- https://github.com/apache/datafusion/pull/12116
## Rationale for this change
CI is broken o
alamb commented on PR #12116:
URL: https://github.com/apache/datafusion/pull/12116#issuecomment-2659540056
This PR caused a CI failure on main (due to a logical conflict). Small PR to
fix:
- https://github.com/apache/datafusion/pull/14667
--
This is an automated message from the Apach
alamb opened a new pull request, #14669:
URL: https://github.com/apache/datafusion/pull/14669
## Which issue does this PR close?
- Part of #7013
## Rationale for this change
I have been listening to CMU's [A Journey Through Database Query
Optimization](https://15799
alamb commented on PR #14667:
URL: https://github.com/apache/datafusion/pull/14667#issuecomment-2659701690
Thanks @findepi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
getChan commented on PR #14651:
URL: https://github.com/apache/datafusion/pull/14651#issuecomment-2659691325
I'll reopen when the datafusion-datasource crate is arranged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
alamb commented on code in PR #14669:
URL: https://github.com/apache/datafusion/pull/14669#discussion_r1956364643
##
datafusion/sql/src/planner.rs:
##
@@ -224,7 +224,24 @@ impl PlannerContext {
}
}
-/// SQL query planner
+/// SQL query planner and binder
Review Comment:
alamb commented on code in PR #14669:
URL: https://github.com/apache/datafusion/pull/14669#discussion_r1956363618
##
datafusion/core/src/lib.rs:
##
@@ -229,9 +229,9 @@
//! 1. The query string is parsed to an Abstract Syntax Tree (AST)
//![`Statement`] using [sqlparser].
/
getChan closed pull request #14651: WIP : create `datafusion-datasource-avro`
crate
URL: https://github.com/apache/datafusion/pull/14651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
andygrove commented on code in PR #1374:
URL: https://github.com/apache/datafusion-comet/pull/1374#discussion_r1956385448
##
spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala:
##
@@ -116,12 +116,49 @@ abstract class CometTestBase
require(absTol > 0 && absTol <=
jkosh44 commented on issue #14613:
URL: https://github.com/apache/datafusion/issues/14613#issuecomment-2659528279
I just noticed a pattern about the errors. In the `array_prepend` function,
`FixedSizeList` is coerced to a `List`. So all of the queries that succeed are
coerced to the same in
milenkovicm commented on PR #14631:
URL: https://github.com/apache/datafusion/pull/14631#issuecomment-2659498586
I will push those small changes later, and will have a look if tests can be
improved.
Issue I have is that we can have one table ref but different table source if
I'm not mist
timsaucer commented on PR #14653:
URL: https://github.com/apache/datafusion/pull/14653#issuecomment-2659395911
I suspect you're right about that assumption not being correct. I've dug
through a bit, but I'd probably need to write up a unit test to verify.
--
This is an automated message f
alamb opened a new pull request, #14665:
URL: https://github.com/apache/datafusion/pull/14665
## Which issue does this PR close?
- Part of #7013
## Rationale for this change
While reviewing https://github.com/apache/datafusion/pull/14631 from
@milenkovicm I not
alamb merged PR #12116:
URL: https://github.com/apache/datafusion/pull/12116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #1395:
URL:
https://github.com/apache/datafusion-comet/pull/1395#issuecomment-2660157127
Reusing DataFusion operators for the win!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
kazuyukitanimura commented on PR #1387:
URL:
https://github.com/apache/datafusion-comet/pull/1387#issuecomment-2660195143
@parthchandra any other comments? otherwise I can merge this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
friendlymatthew opened a new pull request, #14672:
URL: https://github.com/apache/datafusion/pull/14672
Closes #14613
`array_prepend` would error when attempting to concatenate certain `List`
data types due to an incorrect offset type assumption. The error occurs because
the impleme
wiedld commented on code in PR #14673:
URL: https://github.com/apache/datafusion/pull/14673#discussion_r1956718287
##
datafusion/physical-optimizer/src/enforce_sorting/mod.rs:
##
@@ -84,42 +84,56 @@ impl EnforceSorting {
}
}
-/// This object is used within the [`EnforceS
wiedld commented on code in PR #14650:
URL: https://github.com/apache/datafusion/pull/14650#discussion_r1956722551
##
datafusion/physical-optimizer/src/enforce_sorting/mod.rs:
##
@@ -119,7 +119,7 @@ fn update_sort_ctx_children(
}
node.data = data;
-node.update_pl
findepi commented on PR #14668:
URL: https://github.com/apache/datafusion/pull/14668#issuecomment-2660287208
i now also have support for
various numeric
```rust
#[excalibur_function]
fn add(a: i32, b: u32) -> i64 {
a as i64 + b as i64
}
```
nullable fu
wiedld commented on code in PR #14650:
URL: https://github.com/apache/datafusion/pull/14650#discussion_r1956722551
##
datafusion/physical-optimizer/src/enforce_sorting/mod.rs:
##
@@ -119,7 +119,7 @@ fn update_sort_ctx_children(
}
node.data = data;
-node.update_pl
comphead commented on issue #14580:
URL: https://github.com/apache/datafusion/issues/14580#issuecomment-2660433774
I'll try to chase
https://github.com/apache/datafusion/issues/13816
https://github.com/apache/datafusion/issues/14389
--
This is an automated message from the Apache Git
simonvandel opened a new pull request, #14675:
URL: https://github.com/apache/datafusion/pull/14675
## Which issue does this PR close?
N/A
## Rationale for this change
It seems to be faster to generate random u128's in bulk, and then converting
them to Uuids.
kazuyukitanimura commented on code in PR #1398:
URL: https://github.com/apache/datafusion-comet/pull/1398#discussion_r1956696728
##
spark/src/main/scala/org/apache/comet/DataTypeSupport.scala:
##
@@ -37,7 +37,7 @@ trait DataTypeSupport {
private def isGloballySupported(dt:
findepi opened a new pull request, #14674:
URL: https://github.com/apache/datafusion/pull/14674
GitHub runs include this warning
The Ubuntu-20.04 brownout takes place from 2025-02-01.
For more details, see
https://github.com/actions/runner-images/issues/11101
Let's t
mbutrovich commented on PR #1150:
URL:
https://github.com/apache/datafusion-comet/pull/1150#issuecomment-2660305494
> Sorry, one more question @mbutrovich do we need to add the
DataFusion/IcebergCompat scans to `readerBenchmark` as well?
That benchmark is more of a microbenchmark tha
andygrove merged PR #1402:
URL: https://github.com/apache/datafusion-comet/pull/1402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
andygrove closed pull request #1261: feat: Add support for distinct aggregates
URL: https://github.com/apache/datafusion-comet/pull/1261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
andygrove opened a new pull request, #1404:
URL: https://github.com/apache/datafusion-comet/pull/1404
## Which issue does this PR close?
Closes #.
## Rationale for this change
## What changes are included in this PR?
## How are these changes
andygrove commented on code in PR #1404:
URL: https://github.com/apache/datafusion-comet/pull/1404#discussion_r1956753958
##
dev/diffs/3.4.3.diff:
##
@@ -7,7 +7,7 @@ index d3544881af1..26ab186c65d 100644
2.5.1
2.0.8
+3.4
-+0.5.0-SNAPSHOT
Review Comment:
andygrove commented on code in PR #1404:
URL: https://github.com/apache/datafusion-comet/pull/1404#discussion_r1956760901
##
dev/diffs/3.4.3.diff:
##
@@ -7,7 +7,7 @@ index d3544881af1..26ab186c65d 100644
2.5.1
2.0.8
+3.4
-+0.5.0-SNAPSHOT
Review Comment:
andygrove commented on code in PR #1398:
URL: https://github.com/apache/datafusion-comet/pull/1398#discussion_r1956762065
##
spark/src/main/scala/org/apache/comet/DataTypeSupport.scala:
##
@@ -37,7 +37,7 @@ trait DataTypeSupport {
private def isGloballySupported(dt: DataTyp
andygrove commented on code in PR #1404:
URL: https://github.com/apache/datafusion-comet/pull/1404#discussion_r1956760033
##
dev/diffs/3.4.3.diff:
##
@@ -7,7 +7,7 @@ index d3544881af1..26ab186c65d 100644
2.5.1
2.0.8
+3.4
-+0.5.0-SNAPSHOT
Review Comment:
alamb commented on code in PR #14650:
URL: https://github.com/apache/datafusion/pull/14650#discussion_r1956785686
##
datafusion/physical-optimizer/src/enforce_sorting/replace_with_order_preserving_variants.rs:
##
@@ -45,7 +45,7 @@ use itertools::izip;
pub type OrderPreservation
alamb commented on PR #14650:
URL: https://github.com/apache/datafusion/pull/14650#issuecomment-2660389460
FYI @ozankabak and @berkaysynnada
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
alamb commented on code in PR #14673:
URL: https://github.com/apache/datafusion/pull/14673#discussion_r1956781210
##
datafusion/physical-optimizer/src/enforce_sorting/mod.rs:
##
@@ -151,10 +165,51 @@ fn update_coalesce_ctx_children(
};
}
-/// The boolean flag `repartitio
codecov-commenter commented on PR #1404:
URL:
https://github.com/apache/datafusion-comet/pull/1404#issuecomment-2660420263
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1404?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
kazuyukitanimura commented on PR #1390:
URL:
https://github.com/apache/datafusion-comet/pull/1390#issuecomment-2660546336
#1389 mentioned
https://github.com/apache/datafusion-comet/blob/f099e6e40aa18441c7882e5bffd9d6dfb10c6c19/spark/src/main/scala/org/apache/comet/CometSparkSessionExtens
comphead commented on code in PR #1359:
URL: https://github.com/apache/datafusion-comet/pull/1359#discussion_r1956937048
##
native/core/src/execution/planner.rs:
##
@@ -1155,12 +1154,9 @@ impl PhysicalPlanner {
))
});
-let
comphead commented on PR #14675:
URL: https://github.com/apache/datafusion/pull/14675#issuecomment-2660554270
@simonvandel I'd like to ask you to create a slt test for UUID(), I know it
is non guaranteed output, but we can check the v4 validity format I suppose.
--
This is an automated me
zhuqi-lucas commented on PR #14644:
URL: https://github.com/apache/datafusion/pull/14644#issuecomment-2660771854
> > Thank you @kazuyukitanimura for the PR, i applied the PR try to fix the
testing, but the above testing is still failed for me, i am not sure if i am
missing something.
>
Weijun-H commented on code in PR #14411:
URL: https://github.com/apache/datafusion/pull/14411#discussion_r1957051847
##
datafusion/physical-plan/src/repartition/on_demand_repartition.rs:
##
@@ -0,0 +1,1589 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or
zhuqi-lucas commented on code in PR #14644:
URL: https://github.com/apache/datafusion/pull/14644#discussion_r1957051337
##
datafusion/physical-plan/src/sorts/sort.rs:
##
@@ -302,31 +299,16 @@ impl ExternalSorter {
}
self.reserve_memory_for_merge()?;
-
Weijun-H commented on code in PR #14411:
URL: https://github.com/apache/datafusion/pull/14411#discussion_r1957051847
##
datafusion/physical-plan/src/repartition/on_demand_repartition.rs:
##
@@ -0,0 +1,1589 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or
dentiny opened a new issue, #14678:
URL: https://github.com/apache/datafusion/issues/14678
### Is your feature request related to a problem or challenge?
When I was building datafusion for the first time (with `cargo test`), I met
an error:
```
error: failed to run custom build
1 - 100 of 219 matches
Mail list logo
