parthchandra commented on PR #1150: URL: https://github.com/apache/datafusion-comet/pull/1150#issuecomment-2660530828
> > @mbutrovich Do you plan to overwrite spark/benchmarks/CometReadBenchmark-jdk11-results.txt ? > > > Thanks for running this benchmark @mbutrovich. Slowness in native iceberg compat is probably because of no predicate pushdown. We should update `spark/benchmarks/CometReadBenchmark-jdk11-results.txt` > > @kazuyukitanimura @parthchandra I don't understand these comments. Did we previously have benchmark results in the repo? I don't see anything in spark/benchmarks. Oops. I was sure we were checking in the benchmark results into spark/benchmarks (following what Spark also does). But I see now that we are not doing that. Let's drop this for the moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
