andygrove commented on code in PR #1404:
URL: https://github.com/apache/datafusion-comet/pull/1404#discussion_r1956760901
##########
dev/diffs/3.4.3.diff:
##########
@@ -7,7 +7,7 @@ index d3544881af1..26ab186c65d 100644
<ivy.version>2.5.1</ivy.version>
<oro.version>2.0.8</oro.version>
+ <spark.version.short>3.4</spark.version.short>
-+ <comet.version>0.5.0-SNAPSHOT</comet.version>
Review Comment:
We also set the comet version dynamically:
```
../mvnw -nsu -q versions:set-property -Dproperty=comet.version
-DnewVersion=${{inputs.comet-version}} -DgenerateBackupPoms=false
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
