wiedld commented on code in PR #14650:
URL: https://github.com/apache/datafusion/pull/14650#discussion_r1956722551
##########
datafusion/physical-optimizer/src/enforce_sorting/mod.rs:
##########
@@ -119,7 +119,7 @@ fn update_sort_ctx_children(
}
node.data = data;
- node.update_plan_from_children()
Review Comment:
You also could have moved this to the start of this method, and rename as
something like `update_ctx_and_sync_children` (change the meaning). But that
doesn't really matter. 🤷🏼
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
