korowa commented on code in PR #13751:
URL: https://github.com/apache/datafusion/pull/13751#discussion_r1885543455
##
datafusion/physical-plan/src/joins/hash_join.rs:
##
@@ -90,9 +90,6 @@ struct JoinLeftData {
/// Counter of running probe-threads, potentially
/// able
alamb commented on code in PR #1591:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1591#discussion_r1885037004
##
src/keywords.rs:
##
@@ -973,3 +973,61 @@ pub const RESERVED_FOR_IDENTIFIER: &[Keyword] = &[
Keyword::STRUCT,
Keyword::TRIM,
];
+
+pub const
alamb commented on PR #1587:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1587#issuecomment-2543067810
I merged this PR up to main to resolve a conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
alamb opened a new pull request, #1603:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1603
# Rationale
Inspired by @davisp's
https://github.com/apache/datafusion-sqlparser-rs/pull/1591 I was looking at
`Token::make_word` and I noticed it made *2* clones (owned strings). Eac
alamb commented on PR #1603:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1603#issuecomment-2543080230
I was looking at our benchmarks, and they are very limited. If we want to
pursue optimizing sqlparser more I think it would probably be a good idea to
add many queries (li
alamb commented on PR #50:
URL: https://github.com/apache/datafusion-site/pull/50#issuecomment-2543111741
> Instead of changing the articles, what if we just adjust the css to auto
apply a different size? I did do a smaller adjustment already, but we can
certainly push it further. In
https
berkaysynnada commented on issue #13766:
URL: https://github.com/apache/datafusion/issues/13766#issuecomment-2543059309
I have experienced a similar problem for wasm,
https://github.com/apache/datafusion/issues/13513. After disabling it, got no
problem.
--
This is an automated message fr
alamb commented on code in PR #1591:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1591#discussion_r1885040511
##
src/keywords.rs:
##
@@ -973,3 +973,61 @@ pub const RESERVED_FOR_IDENTIFIER: &[Keyword] = &[
Keyword::STRUCT,
Keyword::TRIM,
];
+
+pub const
timsaucer opened a new pull request, #51:
URL: https://github.com/apache/datafusion-site/pull/51
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
findepi commented on issue #13774:
URL: https://github.com/apache/datafusion/issues/13774#issuecomment-2543131831
> ```
> > SELECT * FROM server NATURAL JOIN client AS client ORDER BY server.id;
> Schema error: No field named server.id. Valid fields are client.id,
client.name, client.s
alamb opened a new pull request, #13777:
URL: https://github.com/apache/datafusion/pull/13777
## Which issue does this PR close?
- Part of https://github.com/apache/datafusion/issues/13762
## Rationale for this change
When trying to write a unit test for
https://github.c
findepi commented on PR #13743:
URL: https://github.com/apache/datafusion/pull/13743#issuecomment-2543134041
float rounding could help with some of these eg
https://github.com/user-attachments/assets/df0d41ff-0a70-4577-b72a-2bb8025b9f97";
/>
https://github.com/user-attachments/
alamb commented on issue #13762:
URL: https://github.com/apache/datafusion/issues/13762#issuecomment-2543133819
I have debugged this a bit more - the issue appears to be in
`ScalarValue::to_array_of_size` where it always creates a sparse UnionArray.
This very non subtle.
I worked up
alamb commented on code in PR #13777:
URL: https://github.com/apache/datafusion/pull/13777#discussion_r1885081284
##
datafusion/common/src/scalar/mod.rs:
##
@@ -5554,6 +,196 @@ mod tests {
assert_eq!(&array, &expected);
}
+#[test]
+fn round_trip() {
+
timsaucer commented on PR #51:
URL: https://github.com/apache/datafusion-site/pull/51#issuecomment-2543133804
@alamb I believe this will temporarily fix the CI problem. I will open a PR
for asf-infra team to fix it upstream. I'm going to move this to draft not
because it isn't ready but bec
2010YOUY01 commented on code in PR #13752:
URL: https://github.com/apache/datafusion/pull/13752#discussion_r1885081435
##
datafusion/functions/src/unicode/initcap.rs:
##
@@ -74,7 +76,7 @@ impl ScalarUDFImpl for InitcapFunc {
DataType::LargeUtf8 => make_scalar_functi
alamb commented on code in PR #13777:
URL: https://github.com/apache/datafusion/pull/13777#discussion_r1885082987
##
datafusion/common/src/scalar/mod.rs:
##
@@ -5554,6 +,194 @@ mod tests {
assert_eq!(&array, &expected);
}
+#[test]
+fn round_trip() {
findepi commented on code in PR #13777:
URL: https://github.com/apache/datafusion/pull/13777#discussion_r1885081611
##
datafusion/common/src/scalar/mod.rs:
##
@@ -5554,6 +,196 @@ mod tests {
assert_eq!(&array, &expected);
}
+#[test]
+fn round_trip() {
alamb commented on code in PR #13777:
URL: https://github.com/apache/datafusion/pull/13777#discussion_r1885081284
##
datafusion/common/src/scalar/mod.rs:
##
@@ -5554,6 +,196 @@ mod tests {
assert_eq!(&array, &expected);
}
+#[test]
+fn round_trip() {
+
alamb commented on PR #51:
URL: https://github.com/apache/datafusion-site/pull/51#issuecomment-2543136764
Thank you 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
findepi commented on PR #13756:
URL: https://github.com/apache/datafusion/pull/13756#issuecomment-2543137271
> Given that we coerce fixed size list to list, the return type of
`array_element(fixed size list)` makes sense to be list.
in the unit test, we ask for `array_element(list(fix
alamb commented on PR #13761:
URL: https://github.com/apache/datafusion/pull/13761#issuecomment-2543104917
Thanks again @comphead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
alamb merged PR #13761:
URL: https://github.com/apache/datafusion/pull/13761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on issue #13766:
URL: https://github.com/apache/datafusion/issues/13766#issuecomment-2543106793
I have added this ticket to the the list of things we should fix before 44
release: https://github.com/apache/datafusion/issues/13334
--
This is an automated message from the Ap
alamb commented on issue #13766:
URL: https://github.com/apache/datafusion/issues/13766#issuecomment-2543106520
@blaginin has a PR to add recursive to sqlparser-rs as well:
- https://github.com/apache/datafusion-sqlparser-rs/pull/1522
Perhaps we can follow his model for making this
alamb commented on code in PR #13717:
URL: https://github.com/apache/datafusion/pull/13717#discussion_r1885065220
##
datafusion/core/src/catalog_common/information_schema.rs:
##
@@ -406,6 +406,7 @@ fn get_udf_args_and_return_types(
.into_iter()
.map(|ar
timsaucer commented on PR #50:
URL: https://github.com/apache/datafusion-site/pull/50#issuecomment-2543109867
Instead of changing the articles, what if we just adjust the css to auto
apply a different size?
--
This is an automated message from the Apache Git Service.
To respond to the mes
alamb commented on issue #8900:
URL: https://github.com/apache/datafusion/issues/8900#issuecomment-2543107473
This may have been fixed by
- https://github.com/apache/datafusion/pull/13310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
alamb commented on issue #13766:
URL: https://github.com/apache/datafusion/issues/13766#issuecomment-2543107565
FYI @peter-toth
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
andygrove merged PR #1150:
URL: https://github.com/apache/datafusion-ballista/pull/1150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr.
westonpace commented on PR #13582:
URL: https://github.com/apache/datafusion/pull/13582#issuecomment-2543112725
@alamb so I think this PR might still useful. 90% of the change here is not
coming from the planning path but rather from the registration path.
Your caching approach and P
timsaucer merged PR #51:
URL: https://github.com/apache/datafusion-site/pull/51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
findepi commented on issue #12604:
URL: https://github.com/apache/datafusion/issues/12604#issuecomment-2543146393
The introduction of a new IR and new Expressions has these challenges
- merit: actual design of the IR and new expressions
- work: actual step by step evolutionary intr
timsaucer commented on PR #43:
URL: https://github.com/apache/datafusion-site/pull/43#issuecomment-2543146788
@alamb I pulled the css font size changes for the index page into this PR
but we can easily pull it out. It is live right now on
https://datafusion.staged.apache.org/blog/ if you wa
findepi commented on issue #13766:
URL: https://github.com/apache/datafusion/issues/13766#issuecomment-2543138382
> * [Add `#[recursive]`
datafusion-sqlparser-rs#1522](https://github.com/apache/datafusion-sqlparser-rs/pull/1522)
>
> Perhaps we can follow his model for making this feat
findepi commented on code in PR #13756:
URL: https://github.com/apache/datafusion/pull/13756#discussion_r1885083552
##
datafusion/functions-nested/src/extract.rs:
##
@@ -993,3 +993,84 @@ where
let data = mutable.freeze();
Ok(arrow::array::make_array(data))
}
+
+#[cfg(
berkaysynnada commented on issue #13766:
URL: https://github.com/apache/datafusion/issues/13766#issuecomment-2543143643
cc @buraksenn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
peter-toth commented on issue #13766:
URL: https://github.com/apache/datafusion/issues/13766#issuecomment-2543150144
Seems like `rust_psm_stack_pointer ` is already on this wishlist for `miri`:
https://github.com/rust-lang/miri/issues/2057
--
This is an automated message from the Apache G
zhuqi-lucas commented on issue #13745:
URL: https://github.com/apache/datafusion/issues/13745#issuecomment-2543161340
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
buraksenn opened a new pull request, #13778:
URL: https://github.com/apache/datafusion/pull/13778
## Which issue does this PR close?
Closes #13766
## Rationale for this change
Adding recursive package causes issues for downstream projects
## What changes are includ
andygrove opened a new pull request, #53:
URL: https://github.com/apache/datafusion-ray/pull/53
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
peter-toth commented on issue #13513:
URL: https://github.com/apache/datafusion/issues/13513#issuecomment-2543156645
@berkaysynnada, is this sill an issue?
https://github.com/rustwasm/wasm-pack/issues/1381#issuecomment-2153142927 seems
to work for me too.
```
% export PATH=/opt/ho
buraksenn commented on issue #13766:
URL: https://github.com/apache/datafusion/issues/13766#issuecomment-2543167905
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
zhuqi-lucas commented on issue #13745:
URL: https://github.com/apache/datafusion/issues/13745#issuecomment-2543159151
Can i take this issue? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
Omega359 opened a new issue, #13779:
URL: https://github.com/apache/datafusion/issues/13779
### Describe the bug
sqlite random/expr/slt_good_10.slt:
```sql
SELECT ALL + + MIN ( - CAST ( + 6 AS INTEGER ) ) * CASE WHEN NULL BETWEEN -
88 AND ( - - 91 ) * - AVG ( 95 ) THEN COUNT ( -
Omega359 opened a new issue, #13780:
URL: https://github.com/apache/datafusion/issues/13780
### Describe the bug
```sql
SELECT - NULLIF ( + 15, - 27 + + CAST ( NULL AS REAL ) + + + MIN ( 35 ) * -
COUNT ( * ) * - 14 + 64 ) * 87 * + 75 * 34 * + 76 + - - 31 AS col0, - 10 * - +
33 * (
Omega359 commented on issue #13779:
URL: https://github.com/apache/datafusion/issues/13779#issuecomment-2543170448
I believe another sql that has the same cause is:
```
External error: query result mismatch:
[SQL] SELECT ALL + CASE WHEN AVG ( ALL + 88 ) >= 74 + + - 95 - CASE 23 W
buraksenn commented on issue #13766:
URL: https://github.com/apache/datafusion/issues/13766#issuecomment-2543167895
Thanks for the heads up @berkaysynnada . Opened a PR to make it optional
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Omega359 opened a new issue, #13781:
URL: https://github.com/apache/datafusion/issues/13781
### Describe the bug
```
External error: query result mismatch:
[SQL] SELECT + 99 * NULLIF ( 86, - CASE WHEN NOT COUNT ( * ) BETWEEN 84 AND
54 THEN NULLIF ( - 59, COUNT ( * ) ) + CAST ( N
Omega359 commented on issue #13781:
URL: https://github.com/apache/datafusion/issues/13781#issuecomment-2543173280
Another version of what I think may be the same thing:
```
External error: query result mismatch:
[SQL] SELECT DISTINCT - ( 43 ) * 42 + - + NULLIF ( + 90, - 49 - + C
tustvold commented on issue #13692:
URL: https://github.com/apache/datafusion/issues/13692#issuecomment-2543174655
I've pushed a simple example to
[io_stall](https://github.com/tustvold/io_stall/blob/main/src/rayon.rs) that
glues together [rayon](https://docs.rs/rayon/latest/rayon/) and
[a
Omega359 opened a new issue, #13782:
URL: https://github.com/apache/datafusion/issues/13782
### Describe the bug
```
External error: query result mismatch:
[SQL] SELECT - ( 74 ) * 62 + - 75 * + - 12 * + 68 * - + COUNT ( DISTINCT + 7
) * 52 * + + COALESCE ( - + SUM ( ALL - 67 ),
Omega359 commented on issue #13782:
URL: https://github.com/apache/datafusion/issues/13782#issuecomment-2543175789
Another example of what is probably the same cause:
Datafusion
```sql
> SELECT ALL + + 84 * + - COUNT ( * ) * - - COALESCE ( + 37, + 14 ) * -
NULLIF ( CASE + + COU
andygrove opened a new pull request, #13783:
URL: https://github.com/apache/datafusion/pull/13783
## Which issue does this PR close?
N/A
## Rationale for this change
In DataFusion Ray we have tests that check for an expected logical plan but
the plans are
berkaysynnada commented on issue #13513:
URL: https://github.com/apache/datafusion/issues/13513#issuecomment-2543177609
That worked for me now (and passed the tests). Perhaps I should have tried
with cargo clean 😞
--
This is an automated message from the Apache Git Service.
To respond to
andygrove commented on code in PR #43:
URL: https://github.com/apache/datafusion-site/pull/43#discussion_r1885116351
##
content/blog/2024-12-14-datafusion-python-43.1.0.md:
##
@@ -0,0 +1,199 @@
+---
+layout: post
+title: Apache DataFusion Python 43.1.0 Released
+date: 2024-12-14
andygrove closed pull request #13783: fix: Make `Display` implementation for
`InList` deterministic
URL: https://github.com/apache/datafusion/pull/13783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
blaginin commented on issue #13766:
URL: https://github.com/apache/datafusion/issues/13766#issuecomment-2543186845
i’m curious if there are any cases when downstream can’t use recursive yet
needs stack overflow protection 🤔 if so, we may need switch to iterative after
all
--
This is an a
jonahgao commented on code in PR #13741:
URL: https://github.com/apache/datafusion/pull/13741#discussion_r1885119711
##
datafusion/expr/src/expr_schema.rs:
##
@@ -453,6 +455,26 @@ impl ExprSchemable for Expr {
}
_ => Ok(Expr::Cast(Cast::new(Box:
Omega359 opened a new issue, #13784:
URL: https://github.com/apache/datafusion/issues/13784
### Describe the bug
This is an odd one that I'm unsure what to make of it
```sql
CREATE TABLE tab0(col0 INTEGER, col1 INTEGER, col2 INTEGER);
INSERT INTO tab0 VALUES(97,1,99);
I
edmondop commented on code in PR #53:
URL: https://github.com/apache/datafusion-ray/pull/53#discussion_r1885182636
##
src/query_stage.rs:
##
@@ -99,10 +99,14 @@ impl QueryStage {
/// Get the input partition count. This is the same as the number of
concurrent tasks
///
TheBuilderJR opened a new issue, #13785:
URL: https://github.com/apache/datafusion/issues/13785
### Describe the bug
I expected based on the published benchmarks to have improvements, but I
haven't seen any. I do see statistics are turned on and in theory optimizations
in the last fe
andygrove commented on code in PR #53:
URL: https://github.com/apache/datafusion-ray/pull/53#discussion_r1885291564
##
src/query_stage.rs:
##
@@ -99,10 +99,14 @@ impl QueryStage {
/// Get the input partition count. This is the same as the number of
concurrent tasks
//
Dandandan commented on issue #13785:
URL: https://github.com/apache/datafusion/issues/13785#issuecomment-2543275736
Hi @TheBuilderJR thanks for opening the issue.
Is there a way we could reproduce your results?
Did you compare performance to other engines (e.g. Spark, DuckDB)?
andygrove merged PR #53:
URL: https://github.com/apache/datafusion-ray/pull/53
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafu
rluvaton commented on code in PR #12474:
URL: https://github.com/apache/datafusion/pull/12474#discussion_r1885347287
##
datafusion/functions/src/core/greatest.rs:
##
@@ -0,0 +1,272 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
rluvaton opened a new pull request, #13786:
URL: https://github.com/apache/datafusion/pull/13786
## Which issue does this PR close?
Closes #6531
## Rationale for this change
adding more expressions support, and I already added `greatest`
## What changes are include
rluvaton commented on code in PR #13786:
URL: https://github.com/apache/datafusion/pull/13786#discussion_r1885350394
##
datafusion/functions/src/core/least.rs:
##
@@ -0,0 +1,283 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agr
rluvaton commented on issue #13334:
URL: https://github.com/apache/datafusion/issues/13334#issuecomment-2543309483
I'll give my 2 cents from my experience regarding how other popular projects
handle this issue
In Node.js (I'm a core collaborator) before each release we run the tests o
andygrove opened a new pull request, #54:
URL: https://github.com/apache/datafusion-ray/pull/54
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
buraksenn commented on issue #13037:
URL: https://github.com/apache/datafusion/issues/13037#issuecomment-2543312794
I've took another look into this and tried to change it but the issue is
that macro in arrow only accepts array literals such as:
[1,2,3]. However, in the datafusion macro i
korowa commented on code in PR #13751:
URL: https://github.com/apache/datafusion/pull/13751#discussion_r1884970634
##
datafusion/physical-plan/src/joins/hash_join.rs:
##
@@ -90,9 +90,6 @@ struct JoinLeftData {
/// Counter of running probe-threads, potentially
/// able
korowa commented on code in PR #13751:
URL: https://github.com/apache/datafusion/pull/13751#discussion_r1884970634
##
datafusion/physical-plan/src/joins/hash_join.rs:
##
@@ -90,9 +90,6 @@ struct JoinLeftData {
/// Counter of running probe-threads, potentially
/// able
korowa commented on code in PR #13751:
URL: https://github.com/apache/datafusion/pull/13751#discussion_r1884994212
##
datafusion/physical-plan/src/joins/hash_join.rs:
##
@@ -90,9 +90,6 @@ struct JoinLeftData {
/// Counter of running probe-threads, potentially
/// able
korowa commented on code in PR #13751:
URL: https://github.com/apache/datafusion/pull/13751#discussion_r1884977816
##
datafusion/physical-plan/src/joins/hash_join.rs:
##
@@ -90,9 +90,6 @@ struct JoinLeftData {
/// Counter of running probe-threads, potentially
/// able
jayzhan211 commented on code in PR #13751:
URL: https://github.com/apache/datafusion/pull/13751#discussion_r1884985362
##
datafusion/physical-plan/src/joins/hash_join.rs:
##
@@ -90,9 +90,6 @@ struct JoinLeftData {
/// Counter of running probe-threads, potentially
/// a
jayzhan211 commented on code in PR #13751:
URL: https://github.com/apache/datafusion/pull/13751#discussion_r1884985362
##
datafusion/physical-plan/src/joins/hash_join.rs:
##
@@ -90,9 +90,6 @@ struct JoinLeftData {
/// Counter of running probe-threads, potentially
/// a
dharanad commented on code in PR #1163:
URL: https://github.com/apache/datafusion-comet/pull/1163#discussion_r188497
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -2390,4 +2390,14 @@ class CometExpressionSuite extends CometTestBase with
Adaptive
dharanad commented on code in PR #1163:
URL: https://github.com/apache/datafusion-comet/pull/1163#discussion_r188497
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -2390,4 +2390,14 @@ class CometExpressionSuite extends CometTestBase with
Adaptive
andygrove closed issue #44: Cannot run benchmarks in k8s due to excessive
spilling & OOM
URL: https://github.com/apache/datafusion-ray/issues/44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
andygrove commented on issue #52:
URL: https://github.com/apache/datafusion-ray/issues/52#issuecomment-2543320317
Fixed in https://github.com/apache/datafusion-ray/pull/53
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
andygrove commented on issue #44:
URL: https://github.com/apache/datafusion-ray/issues/44#issuecomment-2543320623
this is resolved now that we reverted to disk-based shuffle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
andygrove closed issue #52: Single-node Python unit tests fail
URL: https://github.com/apache/datafusion-ray/issues/52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
milevin commented on issue #6951:
URL: https://github.com/apache/datafusion/issues/6951#issuecomment-2543336098
Is anybody working on this? cc: @alamb
I could really use it in the work that I am doing. (Supporting interval
multiplication/division by integers; supporting Date32 + integ
milevin commented on code in PR #13741:
URL: https://github.com/apache/datafusion/pull/13741#discussion_r1885383953
##
datafusion/expr/src/expr_schema.rs:
##
@@ -453,6 +455,26 @@ impl ExprSchemable for Expr {
}
_ => Ok(Expr::Cast(Cast::new(Box::
Omega359 commented on PR #13703:
URL: https://github.com/apache/datafusion/pull/13703#issuecomment-2543358335
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
Omega359 commented on PR #13520:
URL: https://github.com/apache/datafusion/pull/13520#issuecomment-2543359104
> @Omega359 do you wanna take this as you have better configuration?
I asked some months back in the discord channel if anyone was interested and
got no interest at that time.
tlm365 commented on code in PR #13752:
URL: https://github.com/apache/datafusion/pull/13752#discussion_r1885439459
##
datafusion/functions/src/unicode/initcap.rs:
##
@@ -74,7 +76,7 @@ impl ScalarUDFImpl for InitcapFunc {
DataType::LargeUtf8 => make_scalar_function(i
andygrove commented on code in PR #54:
URL: https://github.com/apache/datafusion-ray/pull/54#discussion_r1885382237
##
testdata/expected-plans/q1.txt:
##
@@ -42,7 +42,7 @@ ShuffleWriterExec(stage_id=1,
output_partitioning=Hash([Column { name: "l_return
CoalesceBatchesE
edmondop opened a new pull request, #56:
URL: https://github.com/apache/datafusion-ray/pull/56
In the query stage, we take the output partition count of the first child if
the plan has children, assuming all the plans have the same partition count.
While this is effectively true, if a
edmondop commented on PR #56:
URL: https://github.com/apache/datafusion-ray/pull/56#issuecomment-2543363471
I think this should be merged before #54 @andygrove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
Omega359 commented on PR #13606:
URL: https://github.com/apache/datafusion/pull/13606#issuecomment-2543364492
fyi https://github.com/apache/arrow-rs/issues/6714 was resolved recently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
Omega359 commented on code in PR #13420:
URL: https://github.com/apache/datafusion/pull/13420#discussion_r1885408928
##
datafusion/sqllogictest/test_files/scalar.slt:
##
@@ -1864,10 +1864,10 @@ query TT
EXPLAIN SELECT letter, letter = LEFT(letter2, 1) FROM simple_string;
edmondop closed pull request #50: Implementing Unit testing for Python
URL: https://github.com/apache/datafusion-ray/pull/50
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
edmondop commented on PR #50:
URL: https://github.com/apache/datafusion-ray/pull/50#issuecomment-2543363371
Superseded by @andygrove https://github.com/apache/datafusion-ray/pull/53
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
Omega359 commented on PR #13787:
URL: https://github.com/apache/datafusion/pull/13787#issuecomment-2543365042
LGTM, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Omega359 commented on code in PR #13786:
URL: https://github.com/apache/datafusion/pull/13786#discussion_r1885413349
##
datafusion/functions/src/core/least.rs:
##
@@ -0,0 +1,283 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agr
Omega359 commented on PR #13786:
URL: https://github.com/apache/datafusion/pull/13786#issuecomment-2543367795
LGTM. thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
jayzhan211 commented on code in PR #13751:
URL: https://github.com/apache/datafusion/pull/13751#discussion_r1885451028
##
datafusion/physical-plan/src/joins/hash_join.rs:
##
@@ -90,9 +90,6 @@ struct JoinLeftData {
/// Counter of running probe-threads, potentially
/// a
jayzhan211 commented on code in PR #13751:
URL: https://github.com/apache/datafusion/pull/13751#discussion_r1885451635
##
datafusion/physical-plan/src/joins/hash_join.rs:
##
@@ -90,9 +90,6 @@ struct JoinLeftData {
/// Counter of running probe-threads, potentially
/// a
1 - 100 of 108 matches
Mail list logo
