alamb opened a new pull request, #1603: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1603
# Rationale Inspired by @davisp's https://github.com/apache/datafusion-sqlparser-rs/pull/1591 I was looking at `Token::make_word` and I noticed it made *2* clones (owned strings). Each copy slows things down so let's avoid them # Changes 1. Change `Token::make_word` to reuse its argument and thus save a clone # API Changes This changes Token::make_word and Token::make_keyword to take `String` instead of `&str`. This would be a breaking API change. If it is a problem I can make owned variants (like `Token::make_word_owned` or something) 🤔 # Performance benchmarks: Running -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
