tlm365 commented on code in PR #13752:
URL: https://github.com/apache/datafusion/pull/13752#discussion_r1885439459
##########
datafusion/functions/src/unicode/initcap.rs:
##########
@@ -74,7 +76,7 @@ impl ScalarUDFImpl for InitcapFunc {
DataType::LargeUtf8 => make_scalar_function(initcap::<i64>,
vec![])(args),
DataType::Utf8View => make_scalar_function(initcap_utf8view,
vec![])(args),
other => {
- exec_err!("Unsupported data type {other:?} for function
initcap")
+ exec_err!("Unsupported data type {other:?} for function
`initcap`")
Review Comment:
@2010YOUY01 Thanks for reviewing,
> Incompatible arg should be checked during planning before, thus here is
unreachable, and we can use internal_err to indicate a potential bug if it's
executed
Make sense to međź‘Ť
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
