findepi commented on PR #13743: URL: https://github.com/apache/datafusion/pull/13743#issuecomment-2543134041
float rounding could help with some of these eg <img width="605" alt="image" src="https://github.com/user-attachments/assets/df0d41ff-0a70-4577-b72a-2bb8025b9f97"; /> <img width="463" alt="image" src="https://github.com/user-attachments/assets/7db70966-7c60-4785-8f14-c1b3431cc950"; /> However, the reason why i didn't finish this PR is that even for existing modest number of tests this is a problem. This is because we get types different. For example `2.0` is apparently decimal in PostgreSQL, while it's a float in DF. Maybe addressing https://github.com/apache/datafusion/issues/12817 and this PR would make landing sqlite slt tests easier? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
