findepi closed pull request #13517: Reject CREATE TABLE/VIEW with duplicate
column names
URL: https://github.com/apache/datafusion/pull/13517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
findepi commented on PR #13517:
URL: https://github.com/apache/datafusion/pull/13517#issuecomment-2612664105
Given no-one else was involved so far, your personal preference is a
verdict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
alamb commented on PR #13517:
URL: https://github.com/apache/datafusion/pull/13517#issuecomment-2612202625
> If we don't want them, we should close this PR, and solve the problem some
other way.
That is my personal preference
--
This is an automated message from the Apache Git Serv
findepi commented on PR #13517:
URL: https://github.com/apache/datafusion/pull/13517#issuecomment-2610880556
Correct. Apparently the only question was about how to enforce the
verification:
https://github.com/apache/datafusion/pull/13517#discussion_r1864259318
The new builder types are m
alamb commented on PR #13517:
URL: https://github.com/apache/datafusion/pull/13517#issuecomment-2597026346
What is the status of this PR? It appears to be stalled as we haven't
reached consensus -- it also has several conflicts. Marking it as a draft as we
figure out what to do with it next
findepi commented on code in PR #13517:
URL: https://github.com/apache/datafusion/pull/13517#discussion_r1867399241
##
datafusion/expr/src/logical_plan/ddl.rs:
##
@@ -288,8 +290,234 @@ impl PartialOrd for CreateExternalTable {
}
}
+impl CreateExternalTable {
+pub fn
alamb commented on code in PR #13517:
URL: https://github.com/apache/datafusion/pull/13517#discussion_r1866415719
##
datafusion/expr/src/logical_plan/ddl.rs:
##
@@ -288,8 +290,234 @@ impl PartialOrd for CreateExternalTable {
}
}
+impl CreateExternalTable {
+pub fn tr
findepi commented on code in PR #13517:
URL: https://github.com/apache/datafusion/pull/13517#discussion_r1865686316
##
datafusion/expr/src/logical_plan/ddl.rs:
##
@@ -288,8 +290,234 @@ impl PartialOrd for CreateExternalTable {
}
}
+impl CreateExternalTable {
+pub fn
jonahgao commented on code in PR #13517:
URL: https://github.com/apache/datafusion/pull/13517#discussion_r1864367427
##
datafusion/expr/src/logical_plan/ddl.rs:
##
@@ -288,8 +290,234 @@ impl PartialOrd for CreateExternalTable {
}
}
+impl CreateExternalTable {
+pub fn
alamb commented on code in PR #13517:
URL: https://github.com/apache/datafusion/pull/13517#discussion_r1864259318
##
datafusion/expr/src/logical_plan/ddl.rs:
##
@@ -288,8 +290,234 @@ impl PartialOrd for CreateExternalTable {
}
}
+impl CreateExternalTable {
+pub fn tr
findepi commented on code in PR #13517:
URL: https://github.com/apache/datafusion/pull/13517#discussion_r1862694059
##
datafusion/expr/src/logical_plan/ddl.rs:
##
@@ -303,12 +531,154 @@ pub struct CreateMemoryTable {
pub or_replace: bool,
/// Default values for columns
findepi commented on code in PR #13517:
URL: https://github.com/apache/datafusion/pull/13517#discussion_r1855231729
##
datafusion/expr/src/logical_plan/ddl.rs:
##
@@ -288,8 +290,234 @@ impl PartialOrd for CreateExternalTable {
}
}
+impl CreateExternalTable {
+pub fn
alamb commented on code in PR #13517:
URL: https://github.com/apache/datafusion/pull/13517#discussion_r1855195122
##
datafusion/expr/src/logical_plan/ddl.rs:
##
@@ -288,8 +290,234 @@ impl PartialOrd for CreateExternalTable {
}
}
+impl CreateExternalTable {
+pub fn ne
findepi commented on code in PR #13517:
URL: https://github.com/apache/datafusion/pull/13517#discussion_r1855189688
##
datafusion/expr/src/logical_plan/ddl.rs:
##
@@ -288,8 +290,234 @@ impl PartialOrd for CreateExternalTable {
}
}
+impl CreateExternalTable {
+pub fn
findepi commented on code in PR #13517:
URL: https://github.com/apache/datafusion/pull/13517#discussion_r1855189451
##
datafusion/expr/src/logical_plan/ddl.rs:
##
@@ -192,11 +193,12 @@ impl DdlStatement {
/// Creates an external table.
#[derive(Debug, Clone, PartialEq, Eq)]
findepi commented on code in PR #13517:
URL: https://github.com/apache/datafusion/pull/13517#discussion_r1855189329
##
datafusion/expr/src/logical_plan/ddl.rs:
##
@@ -288,8 +290,234 @@ impl PartialOrd for CreateExternalTable {
}
}
+impl CreateExternalTable {
+pub fn
alamb commented on code in PR #13517:
URL: https://github.com/apache/datafusion/pull/13517#discussion_r1855185944
##
datafusion/expr/src/logical_plan/ddl.rs:
##
@@ -303,12 +531,154 @@ pub struct CreateMemoryTable {
pub or_replace: bool,
/// Default values for columns
findepi commented on code in PR #13517:
URL: https://github.com/apache/datafusion/pull/13517#discussion_r1853493794
##
datafusion/expr/src/logical_plan/ddl.rs:
##
@@ -288,8 +290,234 @@ impl PartialOrd for CreateExternalTable {
}
}
+impl CreateExternalTable {
+pub fn
findepi commented on code in PR #13517:
URL: https://github.com/apache/datafusion/pull/13517#discussion_r1853498966
##
datafusion/common/src/error.rs:
##
@@ -150,6 +150,11 @@ pub enum SchemaError {
qualifier: Box,
name: String,
},
+/// Schema duplicate
findepi commented on code in PR #13517:
URL: https://github.com/apache/datafusion/pull/13517#discussion_r1853489879
##
datafusion/expr/src/logical_plan/ddl.rs:
##
@@ -633,4 +1160,87 @@ mod test {
assert_eq!(drop_view.partial_cmp(&catalog), Some(Ordering::Greater));
comphead commented on code in PR #13517:
URL: https://github.com/apache/datafusion/pull/13517#discussion_r1852945077
##
datafusion/common/src/error.rs:
##
@@ -150,6 +150,11 @@ pub enum SchemaError {
qualifier: Box,
name: String,
},
+/// Schema duplicat
comphead commented on code in PR #13517:
URL: https://github.com/apache/datafusion/pull/13517#discussion_r1852958033
##
datafusion/expr/src/logical_plan/ddl.rs:
##
@@ -633,4 +1160,87 @@ mod test {
assert_eq!(drop_view.partial_cmp(&catalog), Some(Ordering::Greater));
comphead commented on code in PR #13517:
URL: https://github.com/apache/datafusion/pull/13517#discussion_r1852953628
##
datafusion/expr/src/logical_plan/ddl.rs:
##
@@ -288,8 +290,234 @@ impl PartialOrd for CreateExternalTable {
}
}
+impl CreateExternalTable {
+pub fn
comphead commented on code in PR #13517:
URL: https://github.com/apache/datafusion/pull/13517#discussion_r1852954349
##
datafusion/expr/src/logical_plan/ddl.rs:
##
@@ -288,8 +290,234 @@ impl PartialOrd for CreateExternalTable {
}
}
+impl CreateExternalTable {
+pub fn
findepi commented on code in PR #13517:
URL: https://github.com/apache/datafusion/pull/13517#discussion_r1852277620
##
datafusion/sqllogictest/test_files/create_table.slt:
##
@@ -0,0 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor li
25 matches
Mail list logo
