findepi commented on code in PR #13517:
URL: https://github.com/apache/datafusion/pull/13517#discussion_r1862694059
##########
datafusion/expr/src/logical_plan/ddl.rs:
##########
@@ -303,12 +531,154 @@ pub struct CreateMemoryTable {
pub or_replace: bool,
/// Default values for columns
pub column_defaults: Vec<(String, Expr)>,
- /// Wheter the table is `TableType::Temporary`
+ /// Whether the table is `TableType::Temporary`
pub temporary: bool,
}
+impl CreateMemoryTable {
+ pub fn new(fields: CreateMemoryTableFields) -> Result<Self> {
Review Comment:
done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]