findepi commented on code in PR #13517:
URL: https://github.com/apache/datafusion/pull/13517#discussion_r1855231729
##########
datafusion/expr/src/logical_plan/ddl.rs:
##########
@@ -288,8 +290,234 @@ impl PartialOrd for CreateExternalTable {
}
}
+impl CreateExternalTable {
+ pub fn new(fields: CreateExternalTableFields) -> Result<Self> {
Review Comment:
> Given that what do you think then about making all the fields not `pub`
instead? I think that would be less confusing / more obvious.
This would be more breaking.
And we would need to add accessor for all these fields, for cases when
someone wants to inspect some attributes without deconstructing
> Added another check somewhere when it was processed -- for example in
[datafusion/datafusion/core/src/datasource/listing_table_factory.rs](https://github.com/apache/datafusion/blob/eaf51bab8c97341f10f6a46f2ced366a61089d7d/datafusion/core/src/datasource/listing_table_factory.rs#L54)
That could work, but where could this check be?
The link is currently in core byt the listing table is something we would
want to move out.
And this should be the core's guarantee, regardless which table provider is
used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
