findepi commented on code in PR #13517: URL: https://github.com/apache/datafusion/pull/13517#discussion_r1867399241
########## datafusion/expr/src/logical_plan/ddl.rs: ########## @@ -288,8 +290,234 @@ impl PartialOrd for CreateExternalTable { } } +impl CreateExternalTable { + pub fn try_new(fields: CreateExternalTableFields) -> Result<Self> { + let CreateExternalTableFields { Review Comment: The verification is in the `try_new()` method used by the builder. If the builder is not used, and this new `try_new` method isn't used directly either, the verification won't run. I believe the downside of not migrating may be no error message at all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org