Re: [PR] start refactoring process by setting up base + init [datafusion]

github-actions[bot] closed pull request #14306: start refactoring process by setting up base + init URL: https://github.com/apache/datafusion/pull/14306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] start refactoring process by setting up base + init [datafusion]

github-actions[bot] commented on PR #14306: URL: https://github.com/apache/datafusion/pull/14306#issuecomment-2814346773 Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or

Re: [PR] start refactoring process by setting up base + init [datafusion]

Rachelint commented on PR #14306: URL: https://github.com/apache/datafusion/pull/14306#issuecomment-2661345815 > @Rachelint this is just a reminder. Please disregard if this isn't needed. Sorry, I am back and reviewing now. -- This is an automated message from the Apache Git Service

Re: [PR] start refactoring process by setting up base + init [datafusion]

logan-keede commented on PR #14306: URL: https://github.com/apache/datafusion/pull/14306#issuecomment-2646553608 @Rachelint this is just a reminder. Please disregard if this isn't needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] start refactoring process by setting up base + init [datafusion]

Rachelint commented on PR #14306: URL: https://github.com/apache/datafusion/pull/14306#issuecomment-2624484795 Thanks @logan-keede , I will review it in next few days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] start refactoring process by setting up base + init [datafusion]

logan-keede commented on PR #14306: URL: https://github.com/apache/datafusion/pull/14306#issuecomment-2623485431 @Rachelint I have added the test to CI, Please review it whenever you can find some time. Thanks -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] start refactoring process by setting up base + init [datafusion]

logan-keede commented on PR #14306: URL: https://github.com/apache/datafusion/pull/14306#issuecomment-2616823837 > Oh, sorry... I think of some situations: > > * Contributors don't notice the README, and add new tests into `base_aggregate.slt` > * Reviewers don't notice the README

Re: [PR] start refactoring process by setting up base + init [datafusion]

Rachelint commented on code in PR #14306: URL: https://github.com/apache/datafusion/pull/14306#discussion_r193133 ## datafusion/sqllogictest/test_files/aggregate/complete_aggregate.slt: ## Review Comment: Maybe open a sub issue of https://github.com/apache/datafusion/is

Re: [PR] start refactoring process by setting up base + init [datafusion]

Rachelint commented on code in PR #14306: URL: https://github.com/apache/datafusion/pull/14306#discussion_r1931084860 ## datafusion/sqllogictest/test_files/aggregate/complete_aggregate.slt: ## Review Comment: > should I open a new issue for this or just a PR? I think

Re: [PR] start refactoring process by setting up base + init [datafusion]

logan-keede commented on code in PR #14306: URL: https://github.com/apache/datafusion/pull/14306#discussion_r1931077932 ## datafusion/sqllogictest/test_files/aggregate/complete_aggregate.slt: ## Review Comment: should I open a new issue for this or just a PR? -- This is

Re: [PR] start refactoring process by setting up base + init [datafusion]

Rachelint commented on code in PR #14306: URL: https://github.com/apache/datafusion/pull/14306#discussion_r1930941200 ## datafusion/sqllogictest/test_files/aggregate/complete_aggregate.slt: ## Review Comment: Yes, it is nice to do it in follow on prs. -- This is an auto

Re: [PR] start refactoring process by setting up base + init [datafusion]

Rachelint commented on code in PR #14306: URL: https://github.com/apache/datafusion/pull/14306#discussion_r1930931489 ## datafusion/sqllogictest/test_files/aggregate/README.md: ## @@ -0,0 +1,14 @@ +# Aggregate Tests + +# History and Context: + +Aggregate used to be (perhaps

Re: [PR] start refactoring process by setting up base + init [datafusion]

logan-keede commented on code in PR #14306: URL: https://github.com/apache/datafusion/pull/14306#discussion_r1930705477 ## datafusion/sqllogictest/test_files/aggregate/complete_aggregate.slt: ## Review Comment: > * Keep the `complete_aggregate.slt` but just make it won't be

Re: [PR] start refactoring process by setting up base + init [datafusion]

Rachelint commented on code in PR #14306: URL: https://github.com/apache/datafusion/pull/14306#discussion_r1930550742 ## datafusion/sqllogictest/test_files/aggregate/complete_aggregate.slt: ## Review Comment: 🤔 The alternative may can be following? Maybe actually make sense

Re: [PR] start refactoring process by setting up base + init [datafusion]

Rachelint commented on code in PR #14306: URL: https://github.com/apache/datafusion/pull/14306#discussion_r1930550742 ## datafusion/sqllogictest/test_files/aggregate/complete_aggregate.slt: ## Review Comment: 🤔 The alternative may can be following? Maybe actually make sense

Re: [PR] start refactoring process by setting up base + init [datafusion]

Rachelint commented on code in PR #14306: URL: https://github.com/apache/datafusion/pull/14306#discussion_r1930550742 ## datafusion/sqllogictest/test_files/aggregate/complete_aggregate.slt: ## Review Comment: 🤔 The alternative may can be following? - Keep the `comple

Re: [PR] start refactoring process by setting up base + init [datafusion]

Rachelint commented on code in PR #14306: URL: https://github.com/apache/datafusion/pull/14306#discussion_r1930550742 ## datafusion/sqllogictest/test_files/aggregate/complete_aggregate.slt: ## Review Comment: 🤔 The alternative may can be following? - Keep the `comple

Re: [PR] start refactoring process by setting up base + init [datafusion]

Rachelint commented on code in PR #14306: URL: https://github.com/apache/datafusion/pull/14306#discussion_r1930539706 ## datafusion/sqllogictest/test_files/aggregate/complete_aggregate.slt: ## Review Comment: Agree with it is most improtant to keep no tests are lost and I t

Re: [PR] start refactoring process by setting up base + init [datafusion]

logan-keede commented on code in PR #14306: URL: https://github.com/apache/datafusion/pull/14306#discussion_r1929840951 ## datafusion/sqllogictest/test_files/aggregate/complete_aggregate.slt: ## Review Comment: > It seems the tests will be executed twice, how about we just

Re: [PR] start refactoring process by setting up base + init [datafusion]

Rachelint commented on code in PR #14306: URL: https://github.com/apache/datafusion/pull/14306#discussion_r1929809252 ## datafusion/sqllogictest/test_files/aggregate/complete_aggregate.slt: ## Review Comment: How about we name it `old_aggregate.slt` or `old_testcases.slt`.

Re: [PR] start refactoring process by setting up base + init [datafusion]

Rachelint commented on PR #14306: URL: https://github.com/apache/datafusion/pull/14306#issuecomment-2614483569 It seems the tests will be executed twice, how about we just left the one complete test file? Because we will only move testcases incrementlly after this pr, seems we can en

[PR] start refactoring process by setting up base + init [datafusion]

logan-keede opened a new pull request, #14306: URL: https://github.com/apache/datafusion/pull/14306 ## Which issue does this PR close? Closes part of #13723 ## Rationale for this change refer to #14301 ## What changes are included in this PR?

Re: [PR] start refactoring process by setting up base + init [datafusion]

logan-keede commented on PR #14306: URL: https://github.com/apache/datafusion/pull/14306#issuecomment-2614418035 cc @Rachelint -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen