logan-keede commented on PR #14306: URL: https://github.com/apache/datafusion/pull/14306#issuecomment-2616823837
> Oh, sorry... I think of some situations: > > * Contributors don't notice the README, and add new tests into `base_aggregate.slt` > * Reviewers don't notice the README too, approve and merge the pr > * Finally, the `base_aggregate.slt` become different with the archived `complete_aggregate.slt` > > And it may be painful to solve such conflicts if it happen frequently. > > Maybe we should include the check in this pr before merging. And when found new cases added into `base_aggregate.slt`, we throw an error and block it in ci. > > Sorry again... No problem, I have added the diff function. still figuring out how to add this to CI. Thanks for your patience -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org