Rachelint commented on code in PR #14306:
URL: https://github.com/apache/datafusion/pull/14306#discussion_r1930550742
##########
datafusion/sqllogictest/test_files/aggregate/complete_aggregate.slt:
##########
Review Comment:
🤔 The alternative may can be following?
- Keep the `complete_aggregate.slt` but just make it won't be executed
- Perform extract and subtract for the `base_aggregate.slt`.
For example we extract `min/max` from it, and subtract them from
`base_aggregate.slt`.
And get `min_max.slt` and `base_aggregate.slt`
- Implement a simple program/script to check if `min_max.slt` +
`base_aggregate.slt` = `complete_aggregate.slt`
It seems not only `aggregate` and `string` but also some other test files
are too large, may be it can reused during sorting out them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
