logan-keede commented on code in PR #14306: URL: https://github.com/apache/datafusion/pull/14306#discussion_r1930705477
########## datafusion/sqllogictest/test_files/aggregate/complete_aggregate.slt: ########## Review Comment: > * Keep the `complete_aggregate.slt` but just make it won't be executed > * Perform extract and subtract for the `base_aggregate.slt`. This approach looks good to me. > * Implement a simple program/script to check if `min_max.slt` + `base_aggregate.slt` = `complete_aggregate.slt` This looks fun to me, I will be working on this though it might take some time so, can we merge this portion in a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
