Lordworms commented on code in PR #14844:
URL: https://github.com/apache/datafusion/pull/14844#discussion_r1972142808
##
datafusion-cli/src/helper.rs:
##
@@ -310,14 +266,13 @@ mod tests {
)?;
assert!(matches!(result, ValidationResult::Valid(None)));
-
alamb commented on code in PR #14844:
URL: https://github.com/apache/datafusion/pull/14844#discussion_r1971459393
##
datafusion-cli/src/helper.rs:
##
@@ -166,40 +154,8 @@ impl Validator for CliHelper {
impl Helper for CliHelper {}
-/// Unescape input string from readline.
-
findepi commented on code in PR #14844:
URL: https://github.com/apache/datafusion/pull/14844#discussion_r1971099360
##
datafusion-cli/tests/cli_integration.rs:
##
@@ -39,6 +39,10 @@ fn init() {
["--command", "select 1; select 2;", "--format", "json", "-q"],
"[{\"Int64(
findepi commented on PR #14844:
URL: https://github.com/apache/datafusion/pull/14844#issuecomment-2684193983
> I think you are right that this is the core question: "should
`datafusion-cli` be doing any escaping / unescaping itself?"
no, the CLI should not do thos
> If we want
Lordworms commented on code in PR #14844:
URL: https://github.com/apache/datafusion/pull/14844#discussion_r1970592527
##
datafusion-cli/src/helper.rs:
##
@@ -326,15 +326,6 @@ mod tests {
)?;
assert!(matches!(result, ValidationResult::Valid(None)));
-
alamb commented on PR #14844:
URL: https://github.com/apache/datafusion/pull/14844#issuecomment-2683322075
> I think this is correct, because postgresql treats line breaks, such as \t
\0, as plain text, but in the original design of DataFusion, \t, \0 should be
escaped, so for \1, since it
Lordworms commented on PR #14844:
URL: https://github.com/apache/datafusion/pull/14844#issuecomment-2683310903
> Hi @Lordworms -- thank you for this PR
>
> I played around with it a bit locally and something still doesn't seem
right
>
> Specifically, postgres will treat `\1` li
Lordworms commented on PR #14844:
URL: https://github.com/apache/datafusion/pull/14844#issuecomment-2677595271
--
This is an automated message from the Apache Git Service.
To respond to the messa
Lordworms commented on PR #14844:
URL: https://github.com/apache/datafusion/pull/14844#issuecomment-2677559931
I haven't find a good place to add tests, but here is the results
--
This is an a
Lordworms opened a new pull request, #14844:
URL: https://github.com/apache/datafusion/pull/14844
## Which issue does this PR close?
- Closes #13286
## Rationale for this change
## What changes are included in this PR?
## Are these changes
10 matches
Mail list logo
