Lordworms commented on code in PR #14844:
URL: https://github.com/apache/datafusion/pull/14844#discussion_r1972142808
##########
datafusion-cli/src/helper.rs:
##########
@@ -310,14 +266,13 @@ mod tests {
)?;
assert!(matches!(result, ValidationResult::Valid(None)));
- // should be invalid
let result = readline_direct(
- Cursor::new(
- r"create external table test stored as csv location
'data.csv' options ('format.delimiter' '\u{07}');"
Review Comment:
no, the check is to validate delimiter in create csv files using the
unescape function. It will be verified when the external table is created later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
