alamb commented on code in PR #14844:
URL: https://github.com/apache/datafusion/pull/14844#discussion_r1971459393
##########
datafusion-cli/src/helper.rs:
##########
@@ -166,40 +154,8 @@ impl Validator for CliHelper {
impl Helper for CliHelper {}
-/// Unescape input string from readline.
-///
-/// The data read from stdio will be escaped, so we need to unescape the input
before executing the input
-pub fn unescape_input(input: &str) -> datafusion::error::Result<String> {
Review Comment:
One thing that might have changed is that sqlparser got much more
sophistcated in handling escaping itself / added a bunch of handling for the
escaping in the parser (like maybe \u{} style syntax 🤔 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
