alamb commented on PR #14844: URL: https://github.com/apache/datafusion/pull/14844#issuecomment-2683322075
> I think this is correct, because postgresql treats line breaks, such as \t \0, as plain text, but in the original design of DataFusion, \t, \0 should be escaped, so for \1, since it cannot be escaped, an error will be thrown. I think the original purpose of this issue should be to fix single or multiple backslashes. I am not sure whether we should treat all input as plain text like postgresql. I think you are right that this is the core question: "should `datafusion-cli` be doing any escaping / unescaping itself?" If we want to behave like sqllogictest / postgres I think the answer is no. The escaping should happen with the sql supported syntax such as `b'...'` type literals Here is a proposed change to this PR that I think fixes the bug by removing unescaping in datafusion-cli: - https://github.com/Lordworms/arrow-datafusion/pull/3 I am not sure what I think about this to be honest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
