jsai28 commented on code in PR #15288:
URL: https://github.com/apache/datafusion/pull/15288#discussion_r2004177854
##
datafusion/core/tests/parquet/custom_reader.rs:
##
@@ -96,17 +97,15 @@ async fn
route_data_access_ops_to_parquet_file_reader_factory() {
let task_ctx = ses
jsai28 commented on code in PR #15288:
URL: https://github.com/apache/datafusion/pull/15288#discussion_r2001385795
##
datafusion/core/tests/sql/path_partition.rs:
##
@@ -351,18 +321,7 @@ async fn csv_projection_on_partition() -> Result<()> {
.collect()
.await?;
blaginin commented on code in PR #15288:
URL: https://github.com/apache/datafusion/pull/15288#discussion_r2004160683
##
datafusion/core/tests/parquet/custom_reader.rs:
##
@@ -96,17 +97,15 @@ async fn
route_data_access_ops_to_parquet_file_reader_factory() {
let task_ctx = s
blaginin commented on code in PR #15288:
URL: https://github.com/apache/datafusion/pull/15288#discussion_r2004184344
##
datafusion/core/tests/parquet/custom_reader.rs:
##
@@ -96,17 +97,15 @@ async fn
route_data_access_ops_to_parquet_file_reader_factory() {
let task_ctx = s
xudong963 merged PR #15288:
URL: https://github.com/apache/datafusion/pull/15288
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@data
jsai28 commented on PR #15288:
URL: https://github.com/apache/datafusion/pull/15288#issuecomment-2738184914
@blaginin Thanks for your review. I've updated the tests with the changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
jsai28 commented on code in PR #15288:
URL: https://github.com/apache/datafusion/pull/15288#discussion_r2001378037
##
datafusion/core/tests/parquet/schema.rs:
##
@@ -82,7 +69,18 @@ async fn schema_merge_ignores_metadata_by_default() {
.unwrap();
let actual = df.col
jsai28 commented on code in PR #15288:
URL: https://github.com/apache/datafusion/pull/15288#discussion_r2001384839
##
datafusion/core/tests/sql/path_partition.rs:
##
@@ -275,18 +267,7 @@ async fn csv_filter_with_file_col() -> Result<()> {
.collect()
.await?;
jsai28 commented on code in PR #15288:
URL: https://github.com/apache/datafusion/pull/15288#discussion_r2001386223
##
datafusion/core/tests/sql/path_partition.rs:
##
@@ -390,15 +349,7 @@ async fn csv_grouping_by_partition() -> Result<()> {
.collect()
.await?;
jsai28 commented on code in PR #15288:
URL: https://github.com/apache/datafusion/pull/15288#discussion_r2001376856
##
datafusion/core/tests/parquet/custom_reader.rs:
##
@@ -96,17 +97,15 @@ async fn
route_data_access_ops_to_parquet_file_reader_factory() {
let task_ctx = ses
jsai28 commented on code in PR #15288:
URL: https://github.com/apache/datafusion/pull/15288#discussion_r2001388172
##
datafusion/core/tests/sql/select.rs:
##
@@ -114,33 +72,7 @@ async fn test_prepare_statement() -> Result<()> {
let dataframe = dataframe.with_param_values(pa
jsai28 commented on code in PR #15288:
URL: https://github.com/apache/datafusion/pull/15288#discussion_r2001376856
##
datafusion/core/tests/parquet/custom_reader.rs:
##
@@ -96,17 +97,15 @@ async fn
route_data_access_ops_to_parquet_file_reader_factory() {
let task_ctx = ses
jsai28 commented on code in PR #15288:
URL: https://github.com/apache/datafusion/pull/15288#discussion_r2001387282
##
datafusion/core/tests/sql/select.rs:
##
@@ -30,23 +30,7 @@ async fn test_list_query_parameters() -> Result<()> {
.with_param_values(vec![ScalarValue::fr
jsai28 commented on code in PR #15288:
URL: https://github.com/apache/datafusion/pull/15288#discussion_r2001387628
##
datafusion/core/tests/sql/select.rs:
##
@@ -66,33 +50,7 @@ async fn test_named_query_parameters() -> Result<()> {
])?
.collect()
.awai
jsai28 commented on code in PR #15288:
URL: https://github.com/apache/datafusion/pull/15288#discussion_r2001384434
##
datafusion/core/tests/sql/path_partition.rs:
##
@@ -145,16 +146,7 @@ async fn parquet_distinct_partition_col() -> Result<()> {
.collect()
.awai
jsai28 commented on code in PR #15288:
URL: https://github.com/apache/datafusion/pull/15288#discussion_r2001379803
##
datafusion/core/tests/parquet/schema.rs:
##
@@ -153,7 +151,15 @@ async fn schema_merge_can_preserve_metadata() {
let actual = df.collect().await.unwrap();
jsai28 commented on code in PR #15288:
URL: https://github.com/apache/datafusion/pull/15288#discussion_r2001388172
##
datafusion/core/tests/sql/select.rs:
##
@@ -114,33 +72,7 @@ async fn test_prepare_statement() -> Result<()> {
let dataframe = dataframe.with_param_values(pa
jsai28 commented on code in PR #15288:
URL: https://github.com/apache/datafusion/pull/15288#discussion_r2001387282
##
datafusion/core/tests/sql/select.rs:
##
@@ -30,23 +30,7 @@ async fn test_list_query_parameters() -> Result<()> {
.with_param_values(vec