jsai28 commented on code in PR #15288:
URL: https://github.com/apache/datafusion/pull/15288#discussion_r2001385795
##########
datafusion/core/tests/sql/path_partition.rs:
##########
@@ -351,18 +321,7 @@ async fn csv_projection_on_partition() -> Result<()> {
.collect()
.await?;
- let expected = [
- "+----+------------+",
- "| c1 | date |",
- "+----+------------+",
- "| a | 2021-10-27 |",
- "| b | 2021-10-27 |",
- "| b | 2021-10-27 |",
- "| c | 2021-10-27 |",
- "| d | 2021-10-27 |",
- "+----+------------+",
- ];
- assert_batches_sorted_eq!(expected, &result);
+ assert_snapshot!(batches_to_sort_string(&result));
Review Comment:
missing inline snapshot
##########
datafusion/core/tests/sql/path_partition.rs:
##########
@@ -390,15 +349,7 @@ async fn csv_grouping_by_partition() -> Result<()> {
.collect()
.await?;
- let expected = [
- "+------------+----------+----------------------+",
- "| date | count(*) | count(DISTINCT t.c1) |",
- "+------------+----------+----------------------+",
- "| 2021-10-26 | 100 | 5 |",
- "| 2021-10-27 | 100 | 5 |",
- "+------------+----------+----------------------+",
- ];
- assert_batches_sorted_eq!(expected, &result);
+ assert_snapshot!(batches_to_sort_string(&result));
Review Comment:
missing inline snapshot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
