blaginin commented on code in PR #15288:
URL: https://github.com/apache/datafusion/pull/15288#discussion_r2004160683
##########
datafusion/core/tests/parquet/custom_reader.rs:
##########
@@ -96,17 +97,15 @@ async fn
route_data_access_ops_to_parquet_file_reader_factory() {
let task_ctx = session_ctx.task_ctx();
let read = collect(parquet_exec, task_ctx).await.unwrap();
- let expected = [
- "+-----+----+----+",
- "| c1 | c2 | c3 |",
- "+-----+----+----+",
- "| Foo | 1 | 10 |",
- "| | 2 | 20 |",
- "| bar | | |",
- "+-----+----+----+",
- ];
-
- assert_batches_sorted_eq!(expected, &read);
+ assert_snapshot!(batches_to_string(&read), @r"
Review Comment:
i think we need
```suggestion
assert_snapshot!(batches_to_sort_string(&read), @r"
```
because it was `assert_batches_sorted_eq` before?
##########
datafusion/core/src/execution/context/mod.rs:
##########
@@ -2118,14 +2122,18 @@ mod tests {
.await
.unwrap();
- let expected = [
- "+-------+",
- "| count |",
- "+-------+",
- "| 1 |",
- "+-------+",
- ];
- assert_batches_eq!(expected, &result);
+ results.extend([result]);
Review Comment:
```suggestion
results.push(result);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
