jsai28 commented on code in PR #15288:
URL: https://github.com/apache/datafusion/pull/15288#discussion_r2001388172
##########
datafusion/core/tests/sql/select.rs:
##########
@@ -114,33 +72,7 @@ async fn test_prepare_statement() -> Result<()> {
let dataframe = dataframe.with_param_values(param_values)?;
let results = dataframe.collect().await?;
- let expected = vec![
- "+----+----+",
- "| c1 | c2 |",
- "+----+----+",
- "| 1 | 1 |",
- "| 1 | 10 |",
- "| 1 | 2 |",
- "| 1 | 3 |",
- "| 1 | 4 |",
- "| 1 | 5 |",
- "| 1 | 6 |",
- "| 1 | 7 |",
- "| 1 | 8 |",
- "| 1 | 9 |",
- "| 2 | 1 |",
- "| 2 | 10 |",
- "| 2 | 2 |",
- "| 2 | 3 |",
- "| 2 | 4 |",
- "| 2 | 5 |",
- "| 2 | 6 |",
- "| 2 | 7 |",
- "| 2 | 8 |",
- "| 2 | 9 |",
- "+----+----+",
- ];
- assert_batches_sorted_eq!(expected, &results);
+ assert_snapshot!(batches_to_sort_string(&results));
Review Comment:
missing inline snapshot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
