blaginin commented on code in PR #15480:
URL: https://github.com/apache/datafusion/pull/15480#discussion_r2020030614
##
datafusion/substrait/tests/cases/roundtrip_logical_plan.rs:
##
@@ -1374,30 +1464,32 @@ async fn assert_read_filter_count(
Ok(())
}
-async fn assert_exp
blaginin commented on PR #15480:
URL: https://github.com/apache/datafusion/pull/15480#issuecomment-2764289843
Hey again, thanks for working on that 🙏
> can you merge main into this branch please? to remove extra diff
Just to explain, the current PR diff is quite large because it
alamb merged PR #15480:
URL: https://github.com/apache/datafusion/pull/15480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #15480:
URL: https://github.com/apache/datafusion/pull/15480#issuecomment-2764496936
Thanks again @qstommyshu -- I don't have any more suggestions on how to
refactor the tests
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
blaginin commented on PR #15480:
URL: https://github.com/apache/datafusion/pull/15480#issuecomment-2764291364
> Hi, @blaginin I'm not sure what exactly do you mean by merge it to main? I
see there is no conflicts with base branch so it probably means GitHub can fast
forward it?
that'
qstommyshu commented on PR #15480:
URL: https://github.com/apache/datafusion/pull/15480#issuecomment-2764290781
> Hey again, thanks for working on this 🙏
>
> > can you merge main into this branch please? to remove extra diff
>
> Just to explain, the current PR diff is quite larg
qstommyshu commented on PR #15480:
URL: https://github.com/apache/datafusion/pull/15480#issuecomment-2764305700
> Hey again, thanks for working on this 🙏
>
> > can you merge main into this branch please? to remove extra diff
>
> Just to explain, the current PR diff is quite larg
qstommyshu commented on code in PR #15480:
URL: https://github.com/apache/datafusion/pull/15480#discussion_r2020033789
##
datafusion/substrait/tests/cases/roundtrip_logical_plan.rs:
##
@@ -1374,30 +1464,32 @@ async fn assert_read_filter_count(
Ok(())
}
-async fn assert_e
qstommyshu commented on code in PR #15480:
URL: https://github.com/apache/datafusion/pull/15480#discussion_r2020033789
##
datafusion/substrait/tests/cases/roundtrip_logical_plan.rs:
##
@@ -1374,30 +1464,32 @@ async fn assert_read_filter_count(
Ok(())
}
-async fn assert_e
qstommyshu commented on PR #15480:
URL: https://github.com/apache/datafusion/pull/15480#issuecomment-2764295647
Got it, thanks for pointing that out. Just cleared up the diff tree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
blaginin commented on PR #15480:
URL: https://github.com/apache/datafusion/pull/15480#issuecomment-2764289869
Hey again, thanks for working on this 🙏
> can you merge main into this branch please? to remove extra diff
Just to explain, the current PR diff is quite large because it
xudong963 commented on PR #15480:
URL: https://github.com/apache/datafusion/pull/15480#issuecomment-2763036538
cc @blaginin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
alamb commented on PR #15480:
URL: https://github.com/apache/datafusion/pull/15480#issuecomment-2762080799
🌶️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
qstommyshu commented on PR #15480:
URL: https://github.com/apache/datafusion/pull/15480#issuecomment-2762061935
I'll do a last commit to resolve those comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
blaginin commented on PR #15480:
URL: https://github.com/apache/datafusion/pull/15480#issuecomment-2762056261
can you merge main into this branch please? to remove the diff
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
alamb commented on code in PR #15480:
URL: https://github.com/apache/datafusion/pull/15480#discussion_r2019086527
##
datafusion/substrait/tests/cases/emit_kind_tests.rs:
##
@@ -53,15 +54,15 @@ mod tests {
let ctx = add_plan_schemas_to_ctx(SessionContext::new(), &proto_p
qstommyshu commented on PR #15480:
URL: https://github.com/apache/datafusion/pull/15480#issuecomment-2761715713
Hi @alamb and @blaginin
Part2 of the substrait tests migration is done as well. Please take a look
when you have time :)
The only tests that cannot be changed to `in
qstommyshu opened a new pull request, #15480:
URL: https://github.com/apache/datafusion/pull/15480
## Which issue does this PR close?
- Closes #15398. Related #15444
## Rationale for this change
## What changes are included in this PR?
Migr
18 matches
Mail list logo
