qstommyshu commented on PR #15480: URL: https://github.com/apache/datafusion/pull/15480#issuecomment-2761715713
Hi @alamb and @blaginin Part2 of the substrait tests migration is done as well. Please take a look when you have time :) The only tests that cannot be changed to `insta` are tests in `simple_intersect_table_reuse()`and `simple_intersect()` in [this file](https://github.com/apache/datafusion/blob/main/datafusion/substrait/tests/cases/roundtrip_logical_plan.rs). I don't think it is possible to migrate these tests to `insta` because their `expected_plan_str` requires formatting variable into a string. It is not supported in Rust to generate a raw string with variable, and raw string is a required argument for `insta` inline snapshot test. So I left those tests out (I don't think it is possible to migrate them into `insta`). Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
