qstommyshu commented on PR #15480: URL: https://github.com/apache/datafusion/pull/15480#issuecomment-2764305700
> Hey again, thanks for working on this 🙏 > > > can you merge main into this branch please? to remove extra diff > > Just to explain, the current PR diff is quite large because it includes code that's already merged. Merging or rebasing would make the diff much smaller, making it easier to review. > > > Closes #15398. > > There might potentially be a few more tests to update. For example, `fn simple_intersect` (with `allow_duplicates`?). I'm not sure if `simple_intersect()` can be updated to use `insta`. It uses a parameter `syntax` to construct the `expected_plan_str`, which I don't think we can create a raw string (for inline assertion) with a variable. As I understand, `allow_duplicates` allow a snapshot to be used multiple times in a test (useful for testing in loop), probably won't help much in the case of `simple_intersect()` and `simple_intersect_table_reuse()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
