qstommyshu commented on code in PR #15480:
URL: https://github.com/apache/datafusion/pull/15480#discussion_r2020033789
##########
datafusion/substrait/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -1374,30 +1464,32 @@ async fn assert_read_filter_count(
Ok(())
}
-async fn assert_expected_plan_unoptimized(
+async fn assert_and_generate_plan(
Review Comment:
1. Updated the `assert_and_generate_plan()` to also return a `LogicalPlan`
now. If I understand it correctly (I'm not too clear about what you mean by
"convert data to string as soon as possible", I assume it means we can return a
`LogicalPlan` as `assert_snapshot` converts it to `String` internally)?
2. I renamed this function to `generate_plan_from_sql()` to suggest this
function generates a logical plan from sql.
The `assert_schema` parameter determines if it does schema assertion
internally, and the `optimized` parameter determines if we want it to generate
an optimized plan.
Hope that resolves the comment. Please let me know if I need to do further
changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
