On Mon, Aug 26, 2019 at 6:33 PM Derrick Stolee wrote:
>
> On 8/26/2019 7:52 PM, Elijah Newren wrote:
> > +WARNING
> > +---
> > +'git filter-branch' has a litany of gotchas that can and will cause
> > +history to be rewritten incorrectly (in addition to abysmal
> > +performance). These issues
On Mon, Aug 26, 2019 at 6:39 PM Derrick Stolee wrote:
>
> On 8/26/2019 7:52 PM, Elijah Newren wrote:
> > Following up on the suggestion to make git.git smaller and shed non-core
> > tools, here's an RFC series to do so with git-filter-branch. This
> > series first removes dependencies on git-filt
Thanks for your suggestions, Pratyush and Philip. I've incorporated both
of them into this reroll.
Changes since v1:
* Squashed old set into one patch
* Fixed indentation style and dangling else
* Added more documentation after discussion with Ævar
Changes since v2:
* Add testing for rebase --
When rebase is run on a branch that can be fast-forwarded, this should
automatically be done. Create test to ensure this behavior happens.
There are some cases that currently don't pass. The first case is where
a feature and master have diverged, running
"git rebase master... master" causes a full
From: Ævar Arnfjörð Bjarmason
Change "same head" introduced in the preceding commit to check whether
the rebase.c code lands in the can_fast_forward() case in, and thus
prints out an "is up to date" and aborts early.
In some of these cases we make it past that and to "rewinding head",
then do a
Before, when we rebased with a --fork-point invocation where the
fork-point wasn't empty, we would be setting options.restrict_revision.
The fast-forward logic would automatically declare that the rebase was
not fast-forwardable if it was set. However, this was painting with a
very broad brush.
Re
Before, when we had the following graph,
A---B---C (master)
\
D (side)
running 'git rebase --onto master... master side' would result in D
being always rebased, no matter what. However, the desired behavior is
that rebase should notice that this is fast-forwarda
From: Ævar Arnfjörð Bjarmason
Add tests rebasing a linear branch topology to linear rebase tests
added in 2aad7cace2 ("add simple tests of consistency across rebase
types", 2013-06-06).
These tests are duplicates of two surrounding tests that do the same
with tags pointing to the same objects. R
A common scenario is if a user is working on a topic branch and they
wish to make some changes to intermediate commits or autosquash, they
would run something such as
git rebase -i --onto master... master
in order to preserve the merge base. This is useful when contributing a
patch series
Before, can_fast_forward was written with an if-else statement. However,
in the future, we may be adding more termination cases which would lead
to deeply nested if statements.
Refactor to use a goto tower so that future cases can be easily
inserted.
Signed-off-by: Denton Liu
---
builtin/rebase
From: Ævar Arnfjörð Bjarmason
Add more stress tests for the can_fast_forward() case in
rebase.c. These tests are getting rather verbose, but now we can see
under --ff and --no-ff whether we skip work, or whether we're forced
to run the rebase.
These tests aren't supposed to endorse the status qu
Signed-off-by: Denton Liu
---
t/t3431-rebase-fork-point.sh | 53
1 file changed, 53 insertions(+)
create mode 100755 t/t3431-rebase-fork-point.sh
diff --git a/t/t3431-rebase-fork-point.sh b/t/t3431-rebase-fork-point.sh
new file mode 100755
index 00..
Do we have interested mentors for the next round of Outreachy?
The deadline for Git to apply to the program is September 5th. The
deadline for mentors to have submitted project descriptions is September
24th. Intern applications would start on October 1st.
If there are mentors who want to partici
Even though `--skip` is a valid command-line option for cherry-pick and
revert while they are in progress, it is not completed. Add this missing
option to the completion script.
Signed-off-by: Denton Liu
---
contrib/completion/git-completion.bash | 2 +-
1 file changed, 1 insertion(+), 1 deletio
Since revert and cherry-pick share the same sequencer code, they should
both accept the same command-line options. Derive the
`__git_cherry_pick_inprogress_options` and
`__git_revert_inprogress_options` variables from
`__git_sequencer_inprogress_options` so that the options aren't
unnecessarily dup
Hi Junio, thanks for the suggestion. I incorporated your suggestion.
Also, I decided to incorporate another patch (3/3) I was planning on
submitting later since both these patchsets have a common purpose:
advertising the `--skip` option better.
Before, the completion script would not complete `--
When reverting or cherry-picking, one of the options we can pass the
sequencer is `--skip`. However, unlike rebasing, `--skip` is not
mentioned as a possible option in the status message. Mention it so that
users are more aware of their options.
Signed-off-by: Denton Liu
---
t/t7512-status-help.
From: Andrey Mazo
I don't have access to my old work email since 20 Apr 2019.
Replace with my personal email address.
Signed-off-by: Andrey Mazo
---
.mailmap | 1 +
1 file changed, 1 insertion(+)
diff --git a/.mailmap b/.mailmap
index 9a5ff04753..14fa041043 100644
--- a/.mailmap
+++ b/.mailma
The usual convention is for test case names to be written between
single-quotes. Change all double-quoted test case names to single-quotes
except for one test case name that uses a sq for a contraction.
Signed-off-by: Denton Liu
---
t/t4014-format-patch.sh | 10 +-
1 file changed, 5 inse
The convention is to use indentable here-docs within test cases so that
the here-docs line up with the rest of the code within the test case.
Change here-docs from `<<\EOF` to `<<-\EOF` so that they can be indented
along with the rest of the test case.
Signed-off-by: Denton Liu
---
t/t4014-forma
Since output is silenced when running without `-v` and debugging output
is useful with `-v`, remove redirections to /dev/null as it is not
useful.
Signed-off-by: Denton Liu
---
t/t4014-format-patch.sh | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/t/t4014-format
In some cases, we were using a redirection operator to feed input into
sed. However, since sed is capable of opening its own files, make sed
open its own files instead of redirecting input into it.
Signed-off-by: Denton Liu
---
t/t4014-format-patch.sh | 28 ++--
1 file ch
Convert all instances of `cnt=$(... | wc -l) && test $cnt = N` into uses
of `test_line_count()`.
While we're at it, convert one instance of a Git command upstream of a
pipe into two commands. This prevents a failure of a Git command from
being masked since only the return code of the last member o
In check_threading(), there was a Git command in the upstream of a pipe.
In order to not lose its status code, it was saved into a file. However,
this may be confusing so rewrite to redirect IO to file. This allows us
to directly use the conventional &&-chain.
Signed-off-by: Denton Liu
---
t/t40
The usual convention for test cases is for the closing sq to be on its
own line. Move the sq onto its own line for cases that do not conform to
this style.
Signed-off-by: Denton Liu
---
t/t4014-format-patch.sh | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/t/t4014-form
For shell scripts, the usual convention is for there to be no space
after redirection operators, (e.g. `>file`, not `> file`). Remove these
spaces wherever they appear.
Signed-off-by: Denton Liu
---
t/t4014-format-patch.sh | 62 -
1 file changed, 31 insert
For test cases, the usual convention is to name expected output files
"expect", not "expected". Replace all instances of "expected" with
"expect" except for one case where the "expected" is used as the name
of a test case.
Signed-off-by: Denton Liu
---
t/t4014-format-patch.sh | 106 +
Signed-off-by: Denton Liu
---
Documentation/config/format.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/config/format.txt b/Documentation/config/format.txt
index 414a5a8a9d..cb629fa769 100644
--- a/Documentation/config/format.txt
+++ b/Documentation/config/format.txt
@@ -7
In git-format-patch.txt, we were missing some key user information.
First of all, document the special value of `--base=auto`.
Next, while we're at it, surround option arguments with <> and change
existing names such as "Message-Id" to "message id", which conforms with
how existing documentation i
Currently, there are two ways where the return codes of Git commands are
lost. The first way is when a command is in the upstream of a pipe. In a
pipe, only the return code of the last command is used. Thus, all other
commands will have their return codes masked. Rewrite pipes so that
there are no
In this reroll, I squashed Junio's suggestion into the correct patch.
Also, I took Eric's suggestion and removed the weak justification (i.e.
better error messages) from the sed patch since it doesn't really
contribute.
As one of the older parts of the Git, the tests and documentation for
format-
Signed-off-by: Denton Liu
---
t/t4014-format-patch.sh | 47 -
1 file changed, 47 deletions(-)
diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
index ca7debf1d4..3ed3feabfe 100755
--- a/t/t4014-format-patch.sh
+++ b/t/t4014-format-patch.sh
@@
Quoth the git-remote-helpers man page:
"If option check-connectivity is requested, the helper must output
connectivity-ok if the clone is self-contained and connected."
I tried doing that in a helper, but I still got a connectivity check.
Looking at the code, it looks like this only works if I su
From: "Philip.McGraw"
Avoid double-open exceptions on Windows platform when
calculating for lfs compressed size threshold
(git-p4.largeFileCompressedThreshold) comparisons.
Take new approach using the NamedTemporaryFile()
file-like object as input to the ZipFile() which
auto-deletes after implic
On Mon, Aug 26, 2019 at 10:58:11PM -0400, Theodore Y. Ts'o wrote:
> On Mon, Aug 26, 2019 at 10:27:00PM -0400, Jeff King wrote:
> > > cannot open test-results/p5302-pack-index.subtests: No such file or
> > > directory at ./aggregate.perl line 153.
> >
> > Implies that we're trying to _write_ to i
Hi, everyone
Just wanted to share with you the final report on my GSoC project:
https://matheustavares.gitlab.io/posts/gsoc-final-report I plan to
continue the project (as it isn't finished yet) and keep contributing
with whatever I can :) Thank you all for the support during this SoC!
Best,
Mat
On Mon, Aug 26, 2019 at 10:27:00PM -0400, Jeff King wrote:
> > cannot open test-results/p5302-pack-index.subtests: No such file or
> > directory at ./aggregate.perl line 153.
>
> Implies that we're trying to _write_ to it, and that the problem is that
> test-results doesn't exist. That should be
On Mon, Aug 26, 2019 at 09:29:42PM -0400, Theodore Y. Ts'o wrote:
> > > I presume that's becuase the file
> > > t/perf/test-results/p5302-pack-index.subtests is missing?
> >
> > That file should be created by running p5302. If you do:
> >
> > cd t/perf
> > rm -rf test-results
> > ./run p5
On 8/26/2019 7:52 PM, Elijah Newren wrote:
> Following up on the suggestion to make git.git smaller and shed non-core
> tools, here's an RFC series to do so with git-filter-branch. This
> series first removes dependencies on git-filter-branch (of which there
> were very few), and then deletes git-
On Mon, Aug 26, 2019 at 11:54 AM Junio C Hamano wrote:
>
> Carlo Marcelo Arenas Belón writes:
>
> > e87de7cab4 ("grep: un-break building with PCRE < 8.32", 2017-05-25)
> > added a restriction for JIT support that is no longer needed after
> > pcre_jit_exec() calls were removed.
>
> I was initial
On 8/26/2019 7:52 PM, Elijah Newren wrote:
> filter-branch suffers from a huge number of pitfalls that can result in
> incorrectly rewritten history, and many of the problems can easily go
> undetected until the new repository is in use. This can result in
> problems ranging from an even messier h
On Mon, Aug 26, 2019 at 04:50:13PM -0400, Jeff King wrote:
> On Sun, Aug 18, 2019 at 12:03:17PM -0400, Theodore Y. Ts'o wrote:
>
> > I was trying to run "make profile" on the master branch (commit
> > 5fa0f5238b: "Git 2.23") and it died in the
> >
> > $(MAKE) PROFILE=GEN perf
> >
> > dies wi
On 8/26/2019 7:52 PM, Elijah Newren wrote:
> Scripts external to git could source $(git --exec-path)/git-sh-setup (as
> we document in Documentation/git-sh-setup.txt). This will in turn
> source git-sh-i18n, which will setup some handy internationalization
> infrastructure. However, git-sh-i18n h
On 8/26/2019 7:52 PM, Elijah Newren wrote:
> fast-export and fast-import can easily handle the simple rewrite that
> was being done by filter-branch, and should be significantly faster on
> systems with a slow fork. Timings from before and after on two laptops
> that I have access to (measured via
On 8/26/2019 7:52 PM, Elijah Newren wrote:
> Test t6006.71 ("oneline with empty message") was creating two commits
> with simple commit messages, and then running filter-branch to rewrite
> the commit messages to be empty. This test was written this way because
> the --allow-empty-message option t
On Mon, Aug 26, 2019 at 11:06:29AM -0700, Junio C Hamano wrote:
> Mike Hommey writes:
>
> > Signed-off-by: Mike Hommey
> > ---
> > packfile.c | 11 +++
> > 1 file changed, 7 insertions(+), 4 deletions(-)
> >
> > Note, I'm not sure this is the right place to do it.
>
> I do not think th
--
Projeto de investimento,
Eu recebi sua mensagem e eu decidi re enviar a mensagem para você para
sua compreensão, eu estarei esperando por sua resposta urgente
Permita-me informá-lo deste negócio altamente lucrativo e isento de
riscos. É um fato que não nos conhecemos, mas como dizem, um dia
Currently, config_with_options() relies on the global the_repository
when it has to configure from a blob. A possible way to bypass this
limitation, when working with arbitrary repos, is to add their object
directories into the in-memory alternates list. That's what
submodule-config.c::config_from_
Previously, config_with_options() wouldn't handle arbitrary repositories
besides the_repository. Because of that, when retrieving .gitmodules
from the cache, config_from_gitmodules() first needed to add the object
directories of the given repo to the in-memory alternates list. But we
have repo_conf
This patchset makes more config.c functions handle arbitrary repos and
use that to remove an add_to_alternates_memory() call in
submodule-config.c. This should hopefully benefit performance and
memory.
Matheus Tavares (2):
config: allow config_with_options() to handle any repo
submodule: pass
Following up on the suggestion to make git.git smaller and shed non-core
tools, here's an RFC series to do so with git-filter-branch. This
series first removes dependencies on git-filter-branch (of which there
were very few), and then deletes git-filter-branch itself in the final
commit.
I'm more
Signed-off-by: Elijah Newren
---
.gitignore | 1 -
Documentation/git-filter-branch.txt | 461 ---
Makefile| 1 -
command-list.txt| 1 -
git-filter-branch.sh| 662
Test t6006.71 ("oneline with empty message") was creating two commits
with simple commit messages, and then running filter-branch to rewrite
the commit messages to be empty. This test was written this way because
the --allow-empty-message option to git commit did not exist at the
time. Simplify t
filter-branch suffers from a huge number of pitfalls that can result in
incorrectly rewritten history, and many of the problems can easily go
undetected until the new repository is in use. This can result in
problems ranging from an even messier history than what led folks to
filter-branch in the
Scripts external to git could source $(git --exec-path)/git-sh-setup (as
we document in Documentation/git-sh-setup.txt). This will in turn
source git-sh-i18n, which will setup some handy internationalization
infrastructure. However, git-sh-i18n hardcodes the TEXTDOMAIN, meaning
that anyone using
fast-export and fast-import can easily handle the simple rewrite that
was being done by filter-branch, and should be significantly faster on
systems with a slow fork. Timings from before and after on two laptops
that I have access to (measured via `time ./t3427-rebase-subtree.sh`,
i.e. including e
On Sun, Aug 25, 2019 at 06:47:02PM +0530, Pratyush Yadav wrote:
> On 25/08/19 05:12AM, Denton Liu wrote:
> > Before, can_fast_forward was written with an if-else statement. However,
> > in the future, we may be adding more termination cases which would lead
> > to deeply nested if statements.
> >
On 2019-08-26 at 19:57:45, Ibrahim El wrote:
> Following previous introduction mail [1], this first series of 5 patches is a
> re-write of the signing interface API in an effort to support easily the
> addition of new tools with minimal effort and also keeping backwards
> compatibility with curr
On 2019-08-26 at 19:58:10, Ibrahim El wrote:
> From: Ibrahim El Rhezzali
>
> c6a1d1c21 Duplicated signing tests using new config aliases
>
> Duplicating existing tests that are signature related and updating them to
> use the new config aliases
I don't think we want to duplicate all of these t
On 2019-08-26 at 19:58:00, Ibrahim El wrote:
> From: Ibrahim El Rhezzali
>
> 7e3e6c9e4 Added new signing interface API
>
> Adding files for the new signing interface and also support drivers for the
> two existing GPG and GPGSM X.509 tools
I'd like to see an explanation here why a new signing
On 2019-08-26 at 19:57:53, Ibrahim El wrote:
> From: Ibrahim El Rhezzali
>
> 2f8f82549 Added documentation for the new signing interface
This seems out of place. Also, your commit summary isn't in the
imperative mood. See Documentation/SubmittingPatches for more details.
> This contains a mod
This makes gitk look for lines in the commit message which start with
"Link:" or "BugLink:" followed by a http or https URL, and make the
URL clickable. Clicking on it will invoke an external web browser with
the URL.
The web browser command is by default "xdg-open" on Linux, "open" on
MacOS, and
The specification of promisor packfiles (in partial-clone.txt) states
that the .promisor files that accompany packfiles do not matter (just
like .keep files), so whenever a packfile is fetched from the promisor
remote, Git has been writing empty .promisor files. But these files
could contain more u
Hi Junio,
On Wed, 31 Jul 2019, Junio C Hamano wrote:
> "Johannes Schindelin via GitGitGadget"
> writes:
>
> > +add.interactive.useBuiltin::
>
> I am not sure if three-level name is a good thing to use here.
>
> If we have end-user controllable (like branch or remote names)
> unbounded number of
On Mon, Aug 26, 2019 at 04:50:13PM -0400, Jeff King wrote:
> On Sun, Aug 18, 2019 at 12:03:17PM -0400, Theodore Y. Ts'o wrote:
>
> > I was trying to run "make profile" on the master branch (commit
> > 5fa0f5238b: "Git 2.23") and it died in the
> >
> > $(MAKE) PROFILE=GEN perf
> >
> > dies w
On Sun, Aug 18, 2019 at 12:03:17PM -0400, Theodore Y. Ts'o wrote:
> I was trying to run "make profile" on the master branch (commit
> 5fa0f5238b: "Git 2.23") and it died in the
>
> $(MAKE) PROFILE=GEN perf
>
> dies with:
>
> cannot open test-results/p5302-pack-index.subtests: No suc
Based on a previous thread “First Git status takes 40+ minutes, when mounting
fileystem/diskimage with 50G GIT repo + 900G of builds articles”
The context is that
1. git wokspace was clone(50G)
2. some 30 platorms build(900G)
3. This tree was then copied into a new diskimage/filesystem +
> On Aug 26, 2019, at 11:33 AM, Jeff King wrote:
>
> On Mon, Aug 26, 2019 at 09:24:10AM -0700, Junio C Hamano wrote:
>
>> "Andrey Portnoy via GitGitGadget" writes:
>>
>>> Previously sprintf was the argument to the BANNED macro, where vsprintf is
>>> expected.
>>
>> Good eyes. Thanks.
>
>
> On Aug 26, 2019, at 11:33 AM, Jeff King wrote:
>
> On Mon, Aug 26, 2019 at 09:24:10AM -0700, Junio C Hamano wrote:
>
>> "Andrey Portnoy via GitGitGadget" writes:
>>
>>> Previously sprintf was the argument to the BANNED macro, where vsprintf is
>>> expected.
>>
>> Good eyes. Thanks.
>
>
From: Ibrahim El Rhezzali
8a89a97d4 Removed old gpg interface and gpg mentions in code
Removing old GPG interface and updating the code to remove gpg mentions and
make it transparent the signign tool that is used
Signed-off-by: Ibrahim El
---
Makefile | 1 -
built
From: Ibrahim El Rhezzali
2f8f82549 Added documentation for the new signing interface
This contains a model document and updated Documentation detailing new
interface and config aliases and their description
Signed-off-by: Ibrahim El
---
Documentation/config/commit.txt | 12 ++
From: Ibrahim El Rhezzali
7e3e6c9e4 Added new signing interface API
Adding files for the new signing interface and also support drivers for the two
existing GPG and GPGSM X.509 tools
Signed-off-by: Ibrahim El
---
Makefile | 3 +
signing-interface.c| 487 ++
Following previous introduction mail [1], this first series of 5 patches is a
re-write of the signing interface API in an effort to support easily the
addition of new tools with minimal effort and also keeping backwards
compatibility with current tools and configuration.
All existing tests curr
From: Ibrahim El Rhezzali
0affa9e2a Migrated to the new signing interface API
Updating the code to use the new signing interface API. Old GPG interface code
is commented and not used
Signed-off-by: Ibrahim El
---
builtin/am.c| 3 ++-
builtin/commit-tree.c | 4 ++--
builtin/co
On Thu, Aug 22, 2019 at 01:23:59PM -0700, Junio C Hamano wrote:
> I do not want a discussion to begin with a Devil's Advocate
> response, but anyway...
>
> Are we planning to go to all batteries included approach? I have a
> feeling that there are other tools (hello, "git imerge") that
> equally
Denton Liu writes:
> Hi all, it's been a while but I guess now's a good time as any to
> resurrect this topic. This is basically a resubmission of Ævar's WIP v8
> but I fixed a couple of minor whitespace issues.
>
> In addition, I opted to drop patches 9-13 from v8 since I don't think I
> can do
On Mon, Aug 26, 2019 at 12:04 PM Jeff King wrote:
>
> On Mon, Aug 26, 2019 at 10:16:48AM -0400, randall.s.bec...@rogers.com wrote:
>
> > On August 24, 2019 5:00 PM, Bryan Turner wrote:
> > > On Fri, Aug 23, 2019 at 6:59 PM wrote:
> > > >
> > > > Hi All,
> > > >
> > > > I'm trying to answer a ques
On Sun, Aug 25, 2019 at 1:06 AM Jeff King wrote:
>
> On Sun, Aug 25, 2019 at 02:57:48AM -0400, Jeff King wrote:
>
> > And I think this is actually a real bug in the current code! We keep a
> > pointer to the encoding string, which survives because of the history.
> > But that history is bounded, a
On Mon, Aug 26, 2019 at 08:42:56PM +0200, Albert Vaca Cintora wrote:
> > Why don't you wrap your clone in a script that calls chmod -R u+w .git
> > after the clone? This seems like a pretty trivial approach regardless of
> > your workflow. This works in Linux, Mac, Windows (under cygwin-bash) and
On 8/26/2019 2:16 PM, Elijah Newren wrote:
> On Mon, Aug 26, 2019 at 6:29 AM Derrick Stolee wrote:
>>
>> On 8/24/2019 1:40 AM, Elijah Newren wrote:
>>> On Thu, Aug 22, 2019 at 6:10 AM Derrick Stolee wrote:
On 8/21/2019 5:52 PM, Elijah Newren wrote:
> On Tue, Aug 20, 2019 at 8:12 AM
On Fri, Aug 23, 2019 at 10:29:00AM +0200, SZEDER Gábor wrote:
> On Fri, Aug 23, 2019 at 12:13:12AM +0530, Pratyush Yadav wrote:
> > > Does it make more sense to replace this strbuf_addstr_without_crud()
> > > setup with something more intelligent (i.e. checking for matching crud
> > > on either en
On 26/08/19 07:22AM, Junio C Hamano wrote:
> Pratyush Yadav writes:
>
>
> > Subject: Re: [PATCH] git-gui: Update in-memory config when changing config
> > options
>
> s/git-gui: Update/git-gui: update/
I fixed this in my tree, just didn't send a re-roll with it. I assumed
you will pull from
Carlo Marcelo Arenas Belón writes:
> diff --git a/grep.h b/grep.h
> index 1a044c501e..ff620d784a 100644
> --- a/grep.h
> +++ b/grep.h
> @@ -3,15 +3,6 @@
> #include "color.h"
> #ifdef USE_LIBPCRE1
> #include
> -#ifndef NO_LIBPCRE1_JIT
> -#ifdef PCRE_CONFIG_JIT
> -#define GIT_PCRE1_USE_JIT
> -
Carlo Marcelo Arenas Belón writes:
> e87de7cab4 ("grep: un-break building with PCRE < 8.32", 2017-05-25)
> added a restriction for JIT support that is no longer needed after
> pcre_jit_exec() calls were removed.
I was initially puzzled by this statement, until I realized that the
removal of pcr
On Sun, Aug 25, 2019 at 02:53:26PM +0200, René Scharfe wrote:
> strbuf_detach() has been returning a pointer to a buffer even for empty
> strbufs since 08ad56f3f0 ("strbuf: always return a non-NULL value from
> strbuf_detach", 2012-10-18). Use that feature in show_log() instead of
> having it han
On Mon, Aug 26, 2019 at 11:28:58AM -0700, Elijah Newren wrote:
> On Sun, Aug 25, 2019 at 1:08 AM Jeff King wrote:
> >
> > We read each line of the fast-import stream into the command_buf strbuf.
> > When reading a commit, we parse a line like "encoding foo" by storing a
> > pointer to "foo", but
On Mon, Aug 26, 2019 at 4:38 PM Junio C Hamano wrote:
>
> And directories (e.g. .git/objects/) are not made read-only for
> obvious reasons. Read-only files inside a writeable directory can
> be deleted just like read-write ones can be (iow, the "delete
> permission" comes from the "write permiss
On Sun, Aug 25, 2019 at 04:21:54PM +0200, René Scharfe wrote:
> > You could xstrndup(command_buf.buf, command_buf.len), which would avoid
> > a hidden strlen.
>
> xstrndup() also searches for NUL, albeit with memchr(3). xmemdupz()
> would copy without checking.
>
> I suspect the simplicity of x
On Mon, Aug 26, 2019 at 02:33:17PM -0400, Jeff King wrote:
> On Mon, Aug 26, 2019 at 09:24:10AM -0700, Junio C Hamano wrote:
>
> > "Andrey Portnoy via GitGitGadget" writes:
> >
> > > Previously sprintf was the argument to the BANNED macro, where vsprintf is
> > > expected.
> >
> > Good eyes. Than
On Mon, Aug 26, 2019 at 09:24:10AM -0700, Junio C Hamano wrote:
> "Andrey Portnoy via GitGitGadget" writes:
>
> > Previously sprintf was the argument to the BANNED macro, where vsprintf is
> > expected.
>
> Good eyes. Thanks.
There's an identical patch in:
https://public-inbox.org/git/cab
On Sun, Aug 25, 2019 at 1:08 AM Jeff King wrote:
>
> We read each line of the fast-import stream into the command_buf strbuf.
> When reading a commit, we parse a line like "encoding foo" by storing a
> pointer to "foo", but not making a copy. We may then read an unbounded
> number of other lines (
On Mon, Aug 26, 2019 at 10:16:48AM -0400, randall.s.bec...@rogers.com wrote:
> On August 24, 2019 5:00 PM, Bryan Turner wrote:
> > On Fri, Aug 23, 2019 at 6:59 PM wrote:
> > >
> > > Hi All,
> > >
> > > I'm trying to answer a question for a customer on clone performance.
> > > They are doing at le
On Mon, Aug 26, 2019 at 10:20:20AM -0700, Junio C Hamano wrote:
> Stefan Sperling writes:
>
> > The root cause of this bug seems to be that the valid assumption
> > that obj->parsed implies a successfully parsed object is broken by
> > parse_tag_buffer() because this function sets the 'parsed' f
On Mon, Aug 26, 2019 at 6:29 AM Derrick Stolee wrote:
>
> On 8/24/2019 1:40 AM, Elijah Newren wrote:
> > On Thu, Aug 22, 2019 at 6:10 AM Derrick Stolee wrote:
> >>
> >> On 8/21/2019 5:52 PM, Elijah Newren wrote:
> >>> On Tue, Aug 20, 2019 at 8:12 AM Derrick Stolee via GitGitGadget
> >>> wrote:
>
Mike Hommey writes:
> First, revision.c doesn't come with a function to clear a struct
> rev_info
> Then, revision.c kind of does nasty things to commit objects...
Yeah, these two stem from the "run once and let exit() clean things
up" design the oldest part of the system shares. Regarding
Mike Hommey writes:
> Signed-off-by: Mike Hommey
> ---
> http.c | 1 +
> 1 file changed, 1 insertion(+)
This matches what builtin/config.c::get_urlmatch() does, which makes
sense.
Thanks.
>
> diff --git a/http.c b/http.c
> index 27aa0a3192..9e33584f2d 100644
> --- a/http.c
> +++ b/http.c
> @
Mike Hommey writes:
> Signed-off-by: Mike Hommey
> ---
> packfile.c | 11 +++
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> Note, I'm not sure this is the right place to do it.
I do not think this patch is complete, given that o->packed_git
still has a non-NULL pointer. IIRC,
On Mon, Aug 26, 2019 at 10:20:20AM -0700, Junio C Hamano wrote:
> Stefan Sperling writes:
>
> > The root cause of this bug seems to be that the valid assumption
> > that obj->parsed implies a successfully parsed object is broken by
> > parse_tag_buffer() because this function sets the 'parsed' fl
Mike Hommey writes:
> The index field in the commit object is used to find the buffer
> corresponding to that commit in the buffer_slab. Resetting it first
> means free_commit_buffer is not going to free the right buffer.
>
> Signed-off-by: Mike Hommey
> ---
> commit.c | 2 +-
> 1 file changed,
1 - 100 of 154 matches
Mail list logo
