On 8/26/2019 7:52 PM, Elijah Newren wrote: > Scripts external to git could source $(git --exec-path)/git-sh-setup (as > we document in Documentation/git-sh-setup.txt). This will in turn > source git-sh-i18n, which will setup some handy internationalization > infrastructure. However, git-sh-i18n hardcodes the TEXTDOMAIN, meaning > that anyone using this infrastructure will only get translations that > are shipped with git. Allow the external scripts to specify their own > translation domain but otherwise use our infrastructure for accessing > translations. > > My original plan was to have git-filter-branch be the first testcase > using this feature, with a goal of minimizing the number of changes that > needed to be made to it when I moved it out of git.git. However, I > realized after creating this patch that no strings in git-filter-branch > are translated. However, the generalization could be useful if we move > other tools from git.git to an external location.
Hm. Maybe extract it from this series for the YAGNI principle? A noble goal, but in my opinion I'd prefer to see this be exercised by something immediately. Thanks, -Stolee
