On Sun, Jul 30, 2017 at 8:51 PM, Shawn Pearce wrote:
> 4th iteration of the reftable storage format.
> [...]
Before we commit to Shawn's reftable proposal, I wanted to explore
what a contrasting design that is not block based would look like. So
I threw together a sketch of such a design. It is n
On Fri, 28 Jul 2017 18:04:18 +0200,
Ævar Arnfjörð Bjarmason wrote:
>
> On Fri, Jul 28, 2017 at 5:58 PM, Ævar Arnfjörð Bjarmason
> wrote:
> > On Tue, Jul 25, 2017 at 7:57 AM, Takashi Iwai wrote:
> >> Some distros provide SHA1 collision detect code as a shared library.
> >> It's the very same code
On Fri, 28 Jul 2017 17:58:14 +0200,
Ævar Arnfjörð Bjarmason wrote:
>
> On Tue, Jul 25, 2017 at 7:57 AM, Takashi Iwai wrote:
> > Some distros provide SHA1 collision detect code as a shared library.
> > It's the very same code as we have in git tree, and git can link with
> > it as well; at least,
Hello all,
I have decided that moving git-subtree development off of the main git
mailing list is the best way to address the needs of git-subtree users
while providing the flexibility necessary to get it in shape for
eventual "official" status in the git project.
Over the last year and a half I
On 31 July 2017 at 23:18, Junio C Hamano wrote:
> Adam Spiers writes:
>
> > Therefore there is a risk that each new UI for higher-level workflows
> > will end up re-implementing these mid-level operations. This
> > undesirable situation could be avoided if git itself provided those
> > mid-level
DO YOU NEED ANY KIND OF LOAN CREDIT ASSISTANCE? IF YES,EMAIL US FOR MORE INFO.
---
This email is free from viruses and malware because avast! Antivirus protection
is active.
http://www.avast.com
On Mon, Jul 31, 2017 at 01:26:40PM -0700, Stefan Beller wrote:
> On Sun, Jul 30, 2017 at 4:24 PM, brian m. carlson
> wrote:
> > I realize this was worded poorly. So for my example, in this case, we'd
> > do:
> >
> > test-helper-hash-string "263 410"
> >
> > For SHA-1, we'd get "263 410". For SHA
On Mon, Jul 31, 2017 at 12:42 PM, Junio C Hamano wrote:
> Shawn Pearce writes:
>
>> ### Peeling
>>
>> References in a reftable are always peeled.
>
> This hopefully means "a record for an annotated (or signed) tag
> records both the tag object and the object it refers to", and does
> not include
On Tue, Jul 18, 2017 at 12:05 PM, Brandon Williams wrote:
> Teach 'is_staging_gitmodules_ok()' to be able to determine in the
> '.gitmodules' file has unstaged changes based on the passed in index
> instead of relying on a global varible which is set during the
variable
> submodule-config parsin
On 31/07/17 23:30, Junio C Hamano wrote:
[snip]
>
> * sd/branch-copy (2017-06-18) 3 commits
> (merged to 'next' on 2017-07-18 at 5e3b9357ea)
> + branch: add a --copy (-c) option to go with --move (-m)
> + branch: add test for -m renaming multiple config sections
> + config: create a functio
On Mon, Jul 31, 2017 at 10:56 PM, Prathamesh Chavan wrote:
> * variable head was no longer used in module_summary() and instead the strbuf
> was utilized.
Good but there might be a few problems in the way it is used. See below.
> +static int compute_summary_module_list(char *head, struct summ
I used these commands:
$ cat sem.cocci
@@
@@
- ".gitmodules"
+ GITMODULES_FILE
$ spatch --in-place --sp-file sem.cocci builtin/*.c *.c *.h
Feel free to regenerate or squash it in or have it as a separate commit.
Signed-off-by: Stefan Beller
---
submodule.c| 18 +
On Mon, Jul 31, 2017 at 12:01 PM, Stefan Beller wrote:
> On Sun, Jul 30, 2017 at 8:51 PM, Shawn Pearce wrote:
>> 4th iteration of the reftable storage format.
>>
>> You can read a rendered version of this here:
>> https://googlers.googlesource.com/sop/jgit/+/reftable/Documentation/technical/refta
On Mon, 31 Jul 2017 14:21:56 -0700
Junio C Hamano wrote:
> Jonathan Tan writes:
>
> > Besides review changes, this patch set now includes my rewritten
> > lazy-loading sha1_file patch, so you can now do this (excerpted from one
> > of the tests):
> >
> > test_create_repo server
> > test
Here are the topics that have been cooking. Commits prefixed with
'-' are only in 'pu' (proposed updates) while commits prefixed with
'+' are in 'next'. The ones marked with '.' do not appear in any of
the integration branches, but I am still holding onto them.
Even though -rc2 was scheduled for
Ævar Arnfjörð Bjarmason writes:
> So the upstream library expects you (and it's documented in their README) to
> do:
>
> #include
>
> But your patch is just doing:
>
> #include
>
> At best this seems like a trivial bug and at worst us encoding some
> Suse-specific packaging convention
On Mon, Jul 31, 2017 at 1:56 PM, Prathamesh Chavan wrote:
> This aims to make git-submodule foreach a builtin. This is the very
> first step taken in this direction. Hence, 'foreach' is ported to
> submodule--helper, and submodule--helper is called from git-submodule.sh.
> The code is split up to
Adam Spiers writes:
> Therefore there is a risk that each new UI for higher-level workflows
> will end up re-implementing these mid-level operations. This
> undesirable situation could be avoided if git itself provided those
> mid-level operations.
Let me make sure if I get your general idea ri
On Mon, Jul 31, 2017 at 1:56 PM, Prathamesh Chavan wrote:
> The submodule subcommand 'summary' is ported in the process of
> making git-submodule a builtin. The function cmd_summary() from
> git-submodule.sh is ported to functions module_summary(),
> compute_summary_module_list(), prepare_submodul
On Mon, Jul 31, 2017 at 1:56 PM, Prathamesh Chavan wrote:
> The same mechanism is used even for porting this submodule
> subcommand, as used in the ported subcommands till now.
> The function cmd_deinit in split up after porting into three
> functions: module_deinit(), for_each_submodule_list() an
Jonathan Tan writes:
> Teach sha1_file to invoke the command configured in
> extensions.lazyObject whenever an object is requested and unavailable.
>
> The usage of the hook can be suppressed through a flag when invoking
> has_object_file_with_flags() and other similar functions.
>
> This is mean
This patch adds a new subcommand called git-splice, which facilitates
higher-level workflow operations in the area of branch management, for
example moving commits from one branch into another, or decomposing
large branches into smaller, independent branches, or vice-versa.
Motivation
--
Add a new subcommand git-splice(1) which non-interactively splices the
current branch by removing a range of commits from within it and/or
cherry-picking a range of commits into it.
It's essentially a convenience wrapper around cherry-pick and
interactive rebase, but the workflow state is persiste
Jonathan Tan writes:
> Besides review changes, this patch set now includes my rewritten
> lazy-loading sha1_file patch, so you can now do this (excerpted from one
> of the tests):
>
> test_create_repo server
> test_commit -C server 1 1.t abcdefgh
> HASH=$(git hash-object server/1.t)
>
On Mon, Jul 31, 2017 at 1:56 PM, Prathamesh Chavan wrote:
> In this new version, the following changes have been made:
> * There was no good reason for using puts in the function
> print_default_remote()
> Hence, in this patch, we instead use printf to do the same, as it is what
> is generall
On Mon, Jul 31, 2017 at 1:56 PM, Prathamesh Chavan wrote:
> This aims to make git-submodule 'status' a built-in. Hence, the function
> cmd_status() is ported from shell to C. This is done by introducing
> three functions: module_status(), submodule_status() and print_status().
>
> The function mod
Teach sha1_file to invoke the command configured in
extensions.lazyObject whenever an object is requested and unavailable.
The usage of the hook can be suppressed through a flag when invoking
has_object_file_with_flags() and other similar functions.
This is meant as a temporary measure to ensure
Teach fsck to not treat missing objects provided on the CLI as an error
when extensions.lazyobject is set.
Signed-off-by: Jonathan Tan
---
builtin/fsck.c | 2 ++
t/t0410-lazy-object.sh | 16
2 files changed, 18 insertions(+)
diff --git a/builtin/fsck.c b/builtin/fsck.c
Teach fsck to not treat refs with missing targets as an error when
extensions.lazyobject is set.
For the purposes of warning about no default refs, such refs are still
treated as legitimate refs.
Signed-off-by: Jonathan Tan
---
builtin/fsck.c | 8
t/t0410-lazy-object.sh | 20 +
Currently, Git does not support repos with very large numbers of objects
or repos that wish to minimize manipulation of certain blobs (for
example, because they are very large) very well, even if the user
operates mostly on part of the repo, because Git is designed on the
assumption that every refe
Teach fsck to not treat missing objects indirectly pointed to by refs as
an error when extensions.lazyobject is set.
Signed-off-by: Jonathan Tan
---
builtin/fsck.c | 11 +++
t/t0410-lazy-object.sh | 27 +++
2 files changed, 38 insertions(+)
diff --git a/b
Besides review changes, this patch set now includes my rewritten
lazy-loading sha1_file patch, so you can now do this (excerpted from one
of the tests):
test_create_repo server
test_commit -C server 1 1.t abcdefgh
HASH=$(git hash-object server/1.t)
test_create_repo client
The submodule subcommand 'summary' is ported in the process of
making git-submodule a builtin. The function cmd_summary() from
git-submodule.sh is ported to functions module_summary(),
compute_summary_module_list(), prepare_submodule_summary() and
print_submodule_summary().
The first function modu
It does not contain the topmost superproject as the author assumed,
but the direct superproject, such that $toplevel/$sm_path is the
actual absolute path of the submodule.
Discussed-with: Ramsay Jones
Signed-off-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
Documentation/git-submodule
Port the submodule subcommand 'sync' from shell to C using the same
mechanism as that used for porting submodule subcommand 'status'.
Hence, here the function cmd_sync() is ported from shell to C.
This is done by introducing three functions: module_sync(),
sync_submodule() and print_default_remote(
Change the scope of function count_lines for allowing the function
to be reused in other parts of the code as well.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
diff.c | 2 +-
diff.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff -
As using a variable '$path' may be harmful to users due to
capitalization issues, see 64394e3ae9 (git-submodule.sh: Don't
use $path variable in eval_gettext string, 2012-04-17). Adjust
the documentation to advocate for using $sm_path, which contains
the same value. We still make the 'path' variabl
It was observed that the variable '$displaypath' was accessible but
undocumented. Hence, document it.
Discussed-with: Ramsay Jones
Signed-off-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
In this new version, the following changes have been made:
* Spelling mistake in the commit messag
The same mechanism is used even for porting this submodule
subcommand, as used in the ported subcommands till now.
The function cmd_deinit in split up after porting into three
functions: module_deinit(), for_each_submodule_list() and
deinit_submodule().
Mentored-by: Christian Couder
Mentored-by:
This aims to make git-submodule foreach a builtin. This is the very
first step taken in this direction. Hence, 'foreach' is ported to
submodule--helper, and submodule--helper is called from git-submodule.sh.
The code is split up to have one function to obtain all the list of
submodules. This functi
When running 'git submodule foreach' from a subdirectory of your
repository, nested submodules get a bogus value for $sm_path:
For a submodule 'sub' that contains a nested submodule 'nested',
running 'git -C dir submodule foreach echo $path' would report
path='../nested' for the nested submodule. T
This aims to make git-submodule 'status' a built-in. Hence, the function
cmd_status() is ported from shell to C. This is done by introducing
three functions: module_status(), submodule_status() and print_status().
The function module_status() acts as the front-end of the subcommand.
It parses subc
Function set_name_rev() is ported from git-submodule to the
submodule--helper builtin. The function get_name_rev() generates the
value of the revision name as required, and the function
print_name_rev() handles the formating and printing of the obtained
revision name.
Mentored-by: Christian Couder
Introduce function for_each_submodule_list() and
replace a loop in module_init() with a call to it.
The new function will also be used in other parts of the
system in later patches.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule
Introduce function get_submodule_displaypath() to replace the code
occurring in submodule_init() for generating displaypath of the
submodule with a call to it.
This new function will also be used in other parts of the system
in later patches.
Mentored-by: Christian Couder
Mentored-by: Stefan Bel
SUMMARY OF MY PROJECT:
Git submodule subcommands are currently implemented by using shell script
'git-submodule.sh'. There are several reasons why we'll prefer not to
use the shell script. My project intends to convert the subcommands into
C code, thus making them builtins. This will increase Git'
On 07/26, Junio C Hamano wrote:
> Stefan Beller writes:
>
> > On Tue, Jul 25, 2017 at 2:39 PM, Brandon Williams wrote:
> >> Commit aee9c7d65 (Submodules: Add the new "ignore" config option for
> >> diff and status) ...
> >
> > introduced in 2010, so quite widely spread.
> >
> >> ... introduced
On Sun, Jul 30, 2017 at 6:43 AM, Jens Lehmann wrote:
> Am 26.07.2017 um 23:06 schrieb Junio C Hamano:
>>
>> Stefan Beller writes:
>>
>>> Rereading the archives, there was quite some discussion on the design
>>> of these patches, but these lines of code did not get any attention
>>>
>>> https
Stefan Beller writes:
>> Further, remove duplicated space character.
>
> https://en.wikipedia.org/wiki/Sentence_spacing
> seems like a globally controversial thing. (I assumed
> it was some sort of local dialect before researching
> it properly)
>
> I personally do not mind one way or another reg
On Mon, Jul 31, 2017 at 1:17 PM, Ævar Arnfjörð Bjarmason
wrote:
> On Mon, Jul 31, 2017 at 1:24 AM, brian m. carlson
> wrote:
>> On Sun, Jul 30, 2017 at 11:00:19PM +, brian m. carlson wrote:
>>> Yes, basically, but a bit more generally. There will always be cases in
>>> which we need to speci
On 07/30, Prathamesh Chavan wrote:
> Thank you Brandon Williams for reviewing the previous
> patch series.
> Also, I'm sorry for repling late to your reviews. The main reason was
> to give sufficient time to prepare the next version of each patch as
> suggested.
No worries, things take time. Tha
On Sun, Jul 30, 2017 at 4:24 PM, brian m. carlson
wrote:
> On Sun, Jul 30, 2017 at 11:00:19PM +, brian m. carlson wrote:
>> Yes, basically, but a bit more generally. There will always be cases in
>> which we need to specify an object ID or an arbitrary string and the
>> behavior will need to
On Sun, Jul 30, 2017 at 9:18 AM, Kaartic Sivaraam
wrote:
> Replace the dashed version of a command with undashed
> version and quote it.
I like it, but similar as below, we'd want to go for
consistency.
>
> Further, remove duplicated space character.
https://en.wikipedia.org/wiki/Sentence_spaci
On Mon, Jul 31, 2017 at 1:24 AM, brian m. carlson
wrote:
> On Sun, Jul 30, 2017 at 11:00:19PM +, brian m. carlson wrote:
>> Yes, basically, but a bit more generally. There will always be cases in
>> which we need to specify an object ID or an arbitrary string and the
>> behavior will need to
Jeff King writes:
> On Mon, Jul 31, 2017 at 07:44:27PM +0200, Martin Ågren wrote:
>
>> On 31 July 2017 at 05:46, Jeff King wrote:
>> > On Sun, Jul 23, 2017 at 08:17:42PM +0200, Martin Ågren wrote:
>> >
>> >> On 21 July 2017 at 00:27, Junio C Hamano wrote:
>> >> > I tend to agree with you that 1
Jiang Xin writes:
> In the last round of l10n, some l10n messages from "date.c" are
> disappeared because of the l10n unfriendly PRItime macro. This issue
> has been fixed by commit fc0fd5b23b (Makefile: help gettext tools to
> cope with our custom PRItime format), so let's start new round of l1
Shawn Pearce writes:
> ### Peeling
>
> References in a reftable are always peeled.
This hopefully means "a record for an annotated (or signed) tag
records both the tag object and the object it refers to", and does
not include peeling a commit down to its tree.
> ### Reference name encoding
>
>
On Sun, Jul 30, 2017 at 8:51 PM, Shawn Pearce wrote:
> 4th iteration of the reftable storage format.
>
> You can read a rendered version of this here:
> https://googlers.googlesource.com/sop/jgit/+/reftable/Documentation/technical/reftable.md
>
> Significant changes from v3:
> - Incorporated Micha
On 31 July 2017 at 18:37, Junio C Hamano wrote:
> Jeff King writes:
>
>> But here...
>>
>>> +test_expect_success TTY 'git tag -a respects pager.tag' '
>>> +test_when_finished "git tag -d newtag" &&
>>> +rm -f paginated.out &&
>>> +test_terminal git -c pager.tag tag -am message newtag
On 31 July 2017 at 05:45, Jeff King wrote:
> On Mon, Jul 17, 2017 at 10:10:52PM +0200, Martin Ågren wrote:
>
>> One could address this in run_argv(), by making the second call to
>> execv_dashed_external() conditional on "!is_builtin()" whereas a builtin
>> would be started as "git foo". (Possibly
On 31 July 2017 at 05:46, Jeff King wrote:
> On Sun, Jul 23, 2017 at 08:17:42PM +0200, Martin Ågren wrote:
>
>> On 21 July 2017 at 00:27, Junio C Hamano wrote:
>> > I tend to agree with you that 1-3/10 may be better off being a
>> > single patch (or 3/10 dropped, as Brandon is working on losing i
On Mon, Jul 31, 2017 at 07:44:27PM +0200, Martin Ågren wrote:
> On 31 July 2017 at 05:46, Jeff King wrote:
> > On Sun, Jul 23, 2017 at 08:17:42PM +0200, Martin Ågren wrote:
> >
> >> On 21 July 2017 at 00:27, Junio C Hamano wrote:
> >> > I tend to agree with you that 1-3/10 may be better off bein
On Sun, Jul 30, 2017 at 11:51 PM, Shawn Pearce wrote:
> - Near constant time verification a SHA-1 is referred to by at least
> one reference (for allow-tip-sha1-in-want).
I think I understated the importance of this when I originally brought
up allow-tip-sha1-in-want. This is an important optim
Thanks!
I'll keep this in mind next time I send a patch.
Anthony
On Mon, Jul 31, 2017 at 9:59 AM, Junio C Hamano wrote:
> Anthony Sottile writes:
>
>> diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt
>> index 89cc0f4..43d18a4 100644
>> --- a/Documentation/diff-optio
I'm not sure if this is a bug or the intended behaviour.
Here's my minimal reproduction (using python3 to write files so I can
control line endings)
```
#!/bin/bash
set -ex
rm -rf repo
git init repo
cd repo
git config --local core.autocrlf input
python3 -c 'open("foo", "wb").write(b"1\r\n2\r\n
Anthony Sottile writes:
> diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt
> index 89cc0f4..43d18a4 100644
> --- a/Documentation/diff-options.txt
> +++ b/Documentation/diff-options.txt
> @@ -392,7 +392,7 @@ endif::git-log[]
> the diff between the preimage and `
Anthony Sottile writes:
> To be honest, I'm a bit overwhelmed by the documentation for submitting a
> patch!
>
> I tried to follow as best I could, here's my attempt (please advise).
OK ;-) Thanks for a patch. Let's nitpick.
Our titles (your "Subject:" line in the e-mail header) state the
ar
Jeff King writes:
> But here...
>
>> +test_expect_success TTY 'git tag -a respects pager.tag' '
>> +test_when_finished "git tag -d newtag" &&
>> +rm -f paginated.out &&
>> +test_terminal git -c pager.tag tag -am message newtag &&
>> +test -e paginated.out
>> +'
>
> I think this be
Jeff King writes:
> But thinking on it, the most plausible case is something like:
>
> setup_auto_pager("foo", -1);
> ...
> /* fallback to some historical compatibility name */
> setup_auto_pager("bar", 0);
>
> And it's important for the "-1" there to be a true punt, and not do
> anything
To be honest, I'm a bit overwhelmed by the documentation for submitting a patch!
I tried to follow as best I could, here's my attempt (please advise).
>From e88ad689a7587c11f270a10f191a3b6bc52a90d4 Mon Sep 17 00:00:00 2001
From: Anthony Sottile
Date: Mon, 31 Jul 2017 06:54:14 -0700
Subject: [PAT
> You may also want to look at the https://git-scm.com/book/en/v2 free
> book
> which can be translated by volunteers, and is possibly one of the
> first
> ports of call for most users (top or near-top of search engine hits)
>
Thanks for that info, I've already read that one a couple of weeks
From: "Christopher Díaz"
Hi Christopher,
I've included the Git list to keep the discussion open to all the community.
(we usually use reply all)
El dom, 30-07-2017 a las 19:01 +0100, Philip Oakley escribió:
Hi Philip,
Thank you very much for such a fast reply.
I can see two simple steps
Loan Offer at 3%, Feel Free to REPLY back to us for more info.
73 matches
Mail list logo
