Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc2

2019-02-12 Thread Justin Mclean
Hi, > While I fully intend to uphold incubator MXNet's release to the standard of > Apache, I'm curious why some TLPs adopt this while others don't. In this > case, is this still a requirement and a basis for stopping a release? Many > people put in hard work to make it happen so I hope to bring g

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc2

2019-02-12 Thread Sheng Zha
Hi Vinay, Thank you for the pointer. I will apply the same header in mxnet markdown files. While I fully intend to uphold incubator MXNet's release to the standard of Apache, I'm curious why some TLPs adopt this while others don't. In this case, is this still a requirement and a basis for stoppin

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc2

2019-02-12 Thread Vinayakumar B
Hi Sheng Zha, Check example from Hadoop's documentation. https://raw.githubusercontent.com/apache/hadoop/trunk/hadoop-common-project/hadoop-common/src/site/markdown/filesystem/filesystem.md In Hadoop's documentation all markdown files have header and none of them are excluded from RAT check. -Vin

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc2

2019-02-12 Thread Sheng Zha
Also, I looked to the TLP Apache Spark for an example on license header on markdown, and I found none [1]. Is your comment on markdown file a suggestion or a requirement? Some clarification would be much appreciated. -sz [1] https://github.com/apache/spark/search?q=Licensed+to+the+Apache+Soft

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc2

2019-02-12 Thread Sheng Zha
Hi Luciano, Thank you for the helpful feedback. As a PPMC member of Apache MXNet, I'd like to resolve this issue once for all. One thing that we can benefit from your help is narrowing down what file types are acceptable to be in whitelist. I started a pull-request for this purpose [1] (and thr

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc2

2019-02-11 Thread Luciano Resende
On Mon, Feb 11, 2019 at 3:55 PM Hen wrote: > > Did you mean: > > "The rat-exclude configuration on the project _must_ be less permissive." > > ? > What I was trying to say is that, even though MXNet has configured and is using rat, the rat-exclude then is very broad, where it excludes like (*.xml

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc2

2019-02-11 Thread Hen
Did you mean: "The rat-exclude configuration on the project _must_ be less permissive." ? (your text suggests it's an option, whereas your vote says it's required) On Sun, Feb 10, 2019 at 8:08 PM Luciano Resende wrote: > I ran RAT, and while I understand that a lot of the failures are > comin

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc2

2019-02-10 Thread Luciano Resende
I ran RAT, and while I understand that a lot of the failures are coming from the 3rdparty directory, some of those are from files that should have the ASF license header such as pom files, docker files, project documentation (yes, MD files do accept apache license headers), Maybe the rat-exclude c

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc2

2019-02-10 Thread Kellen Sunderland
I believe that's correct. I should have mentioned it was non-binding to avoid confusion. On Sun, Feb 10, 2019 at 7:05 PM Steffen Rochel wrote: > Thanks to Henri, Jason and Kellen for your feedback. > We currently have *two, binding +1 votes* (Henri, Jason) from Incubator PMC > members, so *stil

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc2

2019-02-10 Thread Steffen Rochel
Thanks to Henri, Jason and Kellen for your feedback. We currently have *two, binding +1 votes* (Henri, Jason) from Incubator PMC members, so *still don't meet the incubator release voting criteria *. I'm asking support from Incubator PMC

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc2

2019-02-10 Thread Jason Dai
+1 On Mon, Feb 11, 2019 at 9:15 AM kellen sunderland < kellen.sunderl...@gmail.com> wrote: > +1 > > On Sun, Feb 10, 2019 at 3:39 PM Hen wrote: > > > +1. > > > > On Wed, Feb 6, 2019 at 1:59 PM Steffen Rochel > > wrote: > > > > > Dear community, > > > > > > This is a call for releasing Apache MXN

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc2

2019-02-10 Thread kellen sunderland
+1 On Sun, Feb 10, 2019 at 3:39 PM Hen wrote: > +1. > > On Wed, Feb 6, 2019 at 1:59 PM Steffen Rochel > wrote: > > > Dear community, > > > > This is a call for releasing Apache MXNet (incubating) 1.4.0, release > > candidate 2 > > > > Apache MXNet (incubating) community has voted and approved t

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc2

2019-02-10 Thread Hen
+1. On Wed, Feb 6, 2019 at 1:59 PM Steffen Rochel wrote: > Dear community, > > This is a call for releasing Apache MXNet (incubating) 1.4.0, release > candidate 2 > > Apache MXNet (incubating) community has voted and approved the release. > > Vote thread: > > > https://lists.apache.org/thread.ht