On Sun, Mar 31, 2019 at 10:08 AM Justin Mclean
wrote:
> Hi,
>
> > The LICENSE file has a table that maps a file to its license "key" and
> the
> > license is then stored in the (top-level) "licenses" directory (in the
> > header of the table, there is a note about that: "text is in file in
> > li
Hi Justin,
Some more questions on the LICENSE(/NOTICE).
On Sat, Mar 30, 2019 at 2:43 AM Justin Mclean
wrote:
> I think there some more work to do on licensing here, and these will be
> needed to be fixed in a later release:
> - You are not compiling with the terms of the licenses of the softwar
Hi Justin,
On Sat, Mar 30, 2019 at 7:58 AM Justin Mclean
wrote:
> HI,
>
> > I assume we are taking about files like:
> >
> https://github.com/apache/incubator-netbeans/blob/master/java/java.hints/test/unit/data/org/netbeans/test/java/hints/AddCast1.java
>
> Those are some of the files yes but th
Hi Justin,
Thanks for the comments. One particular question/comment at this time:
On Sat, Mar 30, 2019 at 2:43 AM Justin Mclean
wrote:
> - There are a number (100’s) of source files that do not have ASF headers,
> Please run rat and please add headers to .java, .jsp and .php files that
> are mi
On Sun, May 27, 2018 at 12:20 AM, Justin Mclean
wrote:
> Hi,
>
> > I wonder where exactly (most) of these files come from.
>
> Sorry, many apologies, and my mistake as I looked at your last release by
> accident. Changing my vote to +0 (binding).
>
> I can still see the md5 hashes in the office r
Hi Justin,
I wonder where exactly (most) of these files come from. I just did:
$ wget
https://dist.apache.org/repos/dist/dev/incubator/netbeans/incubating-netbeans-java/incubating-9.0-rc1-rc1/incubating-netbeans-java-9.0-rc1-source.zip
[this is the URL from the first e-mail in this thread]
$ sha1s
On Wed, May 23, 2018 at 10:44 PM, Ate Douma wrote:
>
>
> On 2018-05-23 20:57, Emilian Bold wrote:
>
>> Ate, could we get a vote on this release?
>>
>
> Sure :-)
>
>
>> If you look at https://cwiki.apache.org/confl
>> uence/display/NETBEANS/Apache+NetBeans+9.0+RC1 we are already making
>> progress
On Mon, May 21, 2018 at 10:20 PM, Justin Mclean wrote:
> Hi,
>
> > Quote from Apache Legal FAQ:
> > https://www.apache.org/legal/resolved.html#prohibited
> >
> > "[...] For example, using a GPL'ed tool during the build is OK, however
> > including GPL'ed source code is not.[...]"
> >
> > Apache N
On Tue, Jan 23, 2018 at 8:44 AM, Justin Mclean
wrote:
[snip]
> Apache Felix is using those as well, I think?
>
> They may well do but TLP don’t always get things 100% right (the lucerne
> NOTICE file for instance) so IMO we should try and work what is the right
> hing to do here.
>
I've filled:
On Tue, Jan 23, 2018 at 8:44 AM, Justin Mclean
wrote:
> Hi,
>
> > I guess I originally misunderstood the requirements here - I though that
> > these only need to be in the top-level of a release (we are not releasing
> > the jars separatelly). Should be fairly easy to add those to jars the
> > Ne
Thanks a lot for a thorough review! Will take some time to go through that
and fix, but a few questions:
On Tue, Jan 23, 2018 at 5:20 AM, Justin Mclean
wrote:
> Hi,
>
> I did this fairly quickly so may of made a mistake or two and may of
> missed something. A number of issues here are due to ups
On Tue, Jan 23, 2018 at 1:05 AM, Justin Mclean
wrote:
> Hi,
>
> > One of the issue raised as the NOTICE file in the binary distribution. As
> > far as I can tell, it is unclear what specifically we should do about it.
> > (Yes, it contains a lot of text, but my understanding is that it is
> mostl
On Mon, Jan 22, 2018 at 1:56 PM, John D. Ament
wrote:
> >
> >
> > > - Specific call outs in the README about test data licensing not be
> > Apache
> > > license
> > >
> >
> > This is one of the things that are very unclear to me. If we are talking
> > about files like these [1][2][3][4][5][6] (th
On Mon, Jan 22, 2018 at 12:40 PM, Jochen Theodorou
wrote:
>
>
> Am 22.01.2018 um 11:01 schrieb Geertjan Wielenga:
>
>> I am not sure what the point is of spending time on putting rat exclusions
>> together if they’re simply going to be ignored when it comes to IPMC
>> members evaluating a release
On Mon, Jan 22, 2018 at 12:36 PM, John D. Ament
wrote:
> On Mon, Jan 22, 2018 at 5:33 AM Geertjan Wielenga <
> geertjan.wiele...@googlemail.com> wrote:
>
> > The very last thing you’ll find us doing is ignoring your advice. We have
> > taken everything everyone has said and suggested from the ver
On Sun, Jan 21, 2018 at 12:39 AM, Justin Mclean
wrote:
> Hi,
>
> > In many/most cases, the issues picked up by Justin are issues that are
> not
> > visible if our rat exclusions are taken into account. Now, of course,
> what
> > we can do is discuss those rat exclusions. However, a starting point
On Sat, Jan 20, 2018 at 2:14 PM, Justin Mclean wrote:
> Hi,
>
> > Could please the FAQ be updated with exact requirements (or the point
> > removed), to avoid further confusion?
>
> It [1] seems clear to me i.e. there’s an exception for test data but not
> test code.
>
Yes. I guess I wonder abou
On Sat, Jan 20, 2018 at 12:06 PM, Justin Mclean wrote:
> Hi,
>
> > Hi Justing,
>
> It’s Justin actually.
>
Opops, sorry.
>
> > Regarding the Java files and .pass files: as NetBeans is (among other
> > things) a Java IDE, it has tests that take a Java file (often very simple
> > or peculiar). T
Hi Justing,
Thanks for the comments. I guess it will take some time for us to fully go
through the list and resolve it. I have a few comments/questions inline if
I may.
On Sat, Jan 20, 2018 at 5:49 AM, Justin Mclean
wrote:
> Hi,
>
> It -1 (binding) as there may be GPL inclusions in the release
Hello,
On Tue, Sep 20, 2016 at 12:21 PM, Mark Struberg
wrote:
> git clone of the Linus' repo takes 3 minutes.
>
> The hg clone of netbeans took 5 HOURS!
>
> Also checking out all the files or swapping branches in the git repo takes
> about 45 seconds in GIT, but much longer in hg.
>
> The repo s
20 matches
Mail list logo
